Re: [Openerp-community-reviewer] [Merge] lp:~ajite/multi-company/multi-company-add-0001 into lp:multi-company

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/multi-company Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/multi-company/multi-company-action-user into lp:multi-company

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/multi-company Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how

Re: [Openerp-community-reviewer] [Merge] lp:~0s/openerp-product-variant/openerp-product-variant into lp:openerp-product-variant

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/product-variant Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-product-variant/product-variant-multi-attribute into lp:openerp-product-variant

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/product-variant Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how

Re: [Openerp-community-reviewer] [Merge] lp:~credativ/openerp-product-variant/product-variant-7.0-view-priority into lp:openerp-product-variant

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/product-variant Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-report/7_fix_1331394 into lp:purchase-report

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/purchase-reporting Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~jean-lelievre/purchase-report/move_reports into lp:purchase-report

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/purchase-reporting Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~jean-lelievre/purchase-report/product_stock_type into lp:purchase-report

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/purchase-reporting Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~jean-lelievre/purchase-report/product_inventory_warning into lp:purchase-report

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/purchase-reporting Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/purchase-report/purchase-serpentcs into lp:purchase-report

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/purchase-reporting Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/sale-financial Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_markup into lp:sale-financial

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/sale-financial Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_floor_price into lp:sale-financial

2014-08-22 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/sale-financial Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how

Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_lifestyle into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/vertical-medical Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_lab into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/vertical-medical Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_socioeconomics into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/vertical-medical Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_refactoring_step_I into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/vertical-medical Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/oemedical/oemedical into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/vertical-medical Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on

Re: [Openerp-community-reviewer] [Merge] lp:~svass/oemedical/oemedical into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Hello, The management of the project has moved to Github: https://github.com/OCA/vertical-medical If you feel this change is still needed, please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:~purchase-core-editors/purchase-wkfl/7.0

2014-08-20 Thread Alexandre Fayolle - camptocamp
@hurrinco: this won't be merged on Launchpad, as the project is now managed on github. Please migrate the MP to a github PR (cf. Pedro's comment above) -- https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/225197 Your team Purchase Core Editors is subscribed to

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-mrp-reports/7.0-add_serpentcs_mrp_repair_webkit-afe into lp:~openerp-community-reviewer/openerp-mrp-reports/7.0

2014-08-19 Thread Alexandre Fayolle - camptocamp
The proposal to merge lp:~camptocamp/openerp-mrp-reports/7.0-add_serpentcs_mrp_repair_webkit-afe into lp:~openerp-community-reviewer/openerp-mrp-reports/7.0 has been updated. Status: Needs review = Rejected For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-mrp-reports/7.0-add_serpentcs_mrp_repair_webkit-afe into lp:~openerp-community-reviewer/openerp-mrp-reports/7.0

2014-08-19 Thread Alexandre Fayolle - camptocamp
submitted to github -- https://code.launchpad.net/~camptocamp/openerp-mrp-reports/7.0-add_serpentcs_mrp_repair_webkit-afe/+merge/209044 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:~openerp-community-reviewer/openerp-mrp-reports/7.0. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~jean-lelievre/stock-logistic-report/stock_extra into lp:stock-logistic-report

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-reporting Could you resubmit this MP on the new site? -- https://code.launchpad.net/~jean-lelievre/stock-logistic-report/stock_extra/+merge/182063 Your team Stock and Logistic

Re: [Openerp-community-reviewer] [Merge] lp:~jean-lelievre/stock-logistic-report/stock_batch_move into lp:stock-logistic-report

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-reporting Could you resubmit this MP on the new site? -- https://code.launchpad.net/~jean-lelievre/stock-logistic-report/stock_batch_move/+merge/182060 Your team Stock and

Re: [Openerp-community-reviewer] [Merge] lp:~jean-lelievre/stock-logistic-report/logistics_list_report into lp:stock-logistic-report

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-reporting Could you resubmit this MP on the new site? -- https://code.launchpad.net/~jean-lelievre/stock-logistic-report/logistics_list_report/+merge/182038 Your team Stock and

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-workflow Could you resubmit this MP on the new site? -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472 Your team

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde into lp:stock-logistic-flows

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-workflow Could you resubmit this MP on the new site? -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde/+merge/215147

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-workflow Could you resubmit this MP on the new site? --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7 into lp:stock-logistic-flows

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-workflow Could you resubmit this MP on the new site? -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_picking_line_description_7/+merge/219800 Your team Stock

Re: [Openerp-community-reviewer] [Merge] lp:~sebastien.beau/stock-logistic-flows/stock-logistic-flows-61-stock_picking_better_invoicing into lp:stock-logistic-flows/6.1

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-workflow Could you resubmit this MP on the new site? --

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse Could you resubmit this MP on the new site? -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880 Your team

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-hierarchical into lp:stock-logistic-warehouse

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse Could you resubmit this MP on the new site? -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-hierarchical/+merge/223882 Your

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available into lp:stock-logistic-warehouse

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse Could you resubmit this MP on the new site? -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available/+merge/220758 Your team

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision into lp:stock-logistic-warehouse

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse Could you resubmit this MP on the new site? -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision/+merge/223881 Your

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe into lp:stock-logistic-warehouse

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse Could you resubmit this MP on the new site? -- https://code.launchpad.net/~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe/+merge/210859

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-mrp into lp:stock-logistic-warehouse

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse Could you resubmit this MP on the new site? -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-mrp/+merge/220764 Your

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse Could you resubmit this MP on the new site? -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale/+merge/220761 Your

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/7.0-port-base_product_merge into lp:stock-logistic-warehouse

2014-07-03 Thread Alexandre Fayolle - camptocamp
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-warehouse Could you resubmit this MP on the new site? -- https://code.launchpad.net/~camptocamp/stock-logistic-warehouse/7.0-port-base_product_merge/+merge/162121 Your team

Re: [Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order into lp:ocb-server

2014-06-30 Thread Alexandre Fayolle - camptocamp
https://github.com/odoo/odoo/pull/829 -- https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order/+merge/209708 Your team OpenERP Community Backports is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting

2014-06-26 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting. Requested reviews: Account Core Editors (account-core-editors) Related bugs: Bug #1334605 in Account - Budgeting: budget: tests are red https

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-forecast-prepaid into lp:account-closing

2014-06-26 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no tests please add automated tests. Additionally I'm interested in an explanation about the various comparison operators used : sometimes you use strict inequality, sometime -or-equal comparison (e.g. line 241 vs line 248). --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-bug-1296740-elbati into lp:account-consolidation/7.0

2014-06-26 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, test -- https://code.launchpad.net/~agilebg/account-consolidation/7.0-bug-1296740-elbati/+merge/212487 Your team Account Core Editors is subscribed to branch lp:account-consolidation/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh into lp:account-financial-report

2014-06-26 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no test please add an automated test which exercises the new code, so that we can at least easily check that it does not crash. -- https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh/+merge/214905 Your team Account

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-add-account_trial_balance_period_xls into lp:account-financial-report

2014-06-26 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no tests 1. please run flake8 on the code and fix the issues. There are lots of long lines, missing/superfluous spaces, as well as unused imports. 2. please add an automated test which will generate a report and ensure at least some coverage of the module.

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra into lp:account-financial-report

2014-06-26 Thread Alexandre Fayolle - camptocamp
Review: Needs Information code review, no tests I find your naming very confusing. Could you clarify what is space and what is namespace here? -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra/+merge/220527 Your team Account

Re: [Openerp-community-reviewer] [Merge] lp:~sebastien.beau/hr-timesheet/hr-timesheet-fix-project-id-not-required into lp:hr-timesheet

2014-06-24 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing resubmit there are conflict markers in the diff -- https://code.launchpad.net/~sebastien.beau/hr-timesheet/hr-timesheet-fix-project-id-not-required/+merge/224268 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools

2014-06-23 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no tests Never used it, code looks shaggy, and there are not tests. Are there known issues? In it's current state, this module is not on par with the standards of OCA and it needs care and love. If someone has use for this module and is volunteering to

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

2014-06-23 Thread Alexandre Fayolle - camptocamp
setting the MP as work in progress. Please set it back to needs review when requested changes are made. -- https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092 Your team OpenERP Community

Re: [Openerp-community-reviewer] [Merge] lp:~gdgellatly/server-env-tools/base-synchro-7.0 into lp:server-env-tools

2014-06-23 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no tests If people are willing to maintain this, then I'm not opposed to merging in server-env-tools. 2 points, though, to gain my approval: * the various size constraints seem overzealous to me (esp. server URL and domain which are obviously too short for

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-report/6.1-balance-reporting into lp:account-financial-report/6.1

2014-06-23 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing I would really love to see this code exercised by a couple of yaml tests... -- https://code.launchpad.net/~pedro.baeza/account-financial-report/6.1-balance-reporting/+merge/201166 Your team Account Report Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

2014-06-20 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no tests LGTM -- https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~ajite/multi-company/multi-company-add-0001 into lp:multi-company

2014-06-20 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing tried to install and run the tests This looks like a great module. However it needs some work before further review is done: 1. this module will cause a crash at server startup if it is present in the addons path (not necessarily installed) and the connector module is not

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/multi-company/multi-company-action-user into lp:multi-company

2014-06-20 Thread Alexandre Fayolle - camptocamp
Review: Needs Information code review, no tests Could you update the description of the module to make it clear that there is no magic done in the module. Suggestion: 'description': Defines a user to be used for automatic action This module adds a field 'automatic_action_user_id' on the

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into lp:ocb-addons

2014-06-20 Thread Alexandre Fayolle - camptocamp
The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into lp:ocb-addons has been updated. Status: Needs review = Approved For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn into lp:ocb-server

2014-06-13 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, sometest without being able to exercise that code LGTM : the connection must be closed. But I cannot find by reading the code a case where this branch is executed (i.e. a logical path in which we get len(self._connections) = self._maxconn so I'm wondering if we

Re: [Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn into lp:ocb-server

2014-06-13 Thread Alexandre Fayolle - camptocamp
thanks for the precision. -- https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn/+merge/220666 Your team OpenERP Community Backports is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into lp:openerp-product-attributes

2014-06-11 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into lp:openerp-product-attributes. Requested reviews: Product Core Editors (product-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/openerp

[Openerp-community-reviewer] [Bug 1070418] Re: budget position should support view accounts

2014-06-06 Thread Alexandre Fayolle - camptocamp
github: https://github.com/odoo/odoo/issues/372 -- You received this bug notification because you are a member of Account Core Editors, which is subscribed to a duplicate bug report (1149601). https://bugs.launchpad.net/bugs/1070418 Title: budget position should support view accounts Status

[Openerp-community-reviewer] [Bug 1108228] Re: action_stock_invoice_onshipping missing on stock.picking

2014-06-06 Thread Alexandre Fayolle - camptocamp
https://github.com/odoo/odoo/issues/385 -- You received this bug notification because you are a member of OpenERP Community Backports, which is a bug assignee. https://bugs.launchpad.net/bugs/1108228 Title: action_stock_invoice_onshipping missing on stock.picking Status in OpenERP Community

[Openerp-community-reviewer] [Bug 1146923] Re: General account should not be required on analytic entries

2014-06-06 Thread Alexandre Fayolle - camptocamp
https://github.com/odoo/odoo/issues/389 -- You received this bug notification because you are a member of Account Core Editors, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1146923 Title: General account should not be required on analytic entries Status in OpenERP

[Openerp-community-reviewer] [Bug 1181291] Re: [Trunk/7.0] Refund payment: Error occurred while validating the field(s) amount_currency

2014-06-06 Thread Alexandre Fayolle - camptocamp
https://github.com/odoo/odoo/issues/397 -- You received this bug notification because you are a member of OpenERP Community Backports, which is a bug assignee. https://bugs.launchpad.net/bugs/1181291 Title: [Trunk/7.0] Refund payment: Error occurred while validating the field(s)

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl

2014-06-04 Thread Alexandre Fayolle - camptocamp
I've fixed Lorenzo's remarks, and moved the migration script to an init method as the migration script may not be executed on initial installation -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/222111 Your team Sale Core Editors is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl

2014-06-04 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl. Requested reviews: Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c): code review + no tests Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-23 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing according to Alexis, this needs fixing -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-23 Thread Alexandre Fayolle - camptocamp
Review: Approve -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-19 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM thanks! -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319109 into lp:ocb-addons

2014-05-14 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM thanks for fixing this -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1319109/+merge/219473 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1319095 into lp:ocb-addons

2014-05-14 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no test This fix will not work on Windows. out_filename is opened on line 11 of the file, and then the pdf converter will try to open a file with the same name while the file is still open in OpenERP which will fail on windows

[Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools

2014-05-12 Thread Alexandre Fayolle - camptocamp
The proposal to merge lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools

2014-05-12 Thread Alexandre Fayolle - camptocamp
thanks for the review, Daniel. I'm setting this back to WIP until I get the time for take your comments into account. -- https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138 Your team Server Environment And Tools Core Editors is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~invitu/ocb-server/7.0 into lp:ocb-server

2014-05-12 Thread Alexandre Fayolle - camptocamp
the thing is, it is different to store a birthday (which should still be machine parseable) and a birthdate. When the field is called birthdate, I expect a date. -- https://code.launchpad.net/~invitu/ocb-server/7.0/+merge/169658 Your team OpenERP Community Backports is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into lp:openerp-rma

2014-05-06 Thread Alexandre Fayolle - camptocamp
The proposal to merge lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into lp:openerp-rma has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824 --

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl

2014-05-06 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456 into lp:hr-timesheet

2014-05-06 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456/+merge/218364 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-05-06 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep into lp:sale-wkfl

2014-05-06 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into lp:ocb-addons

2014-05-06 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order into lp:ocb-server

2014-04-25 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, test This patch breaks the yaml_import tests. Extract from the logs: TEST test_ocb70 openerp.tools.yaml_import: 2. Duplicate the parent category and verify that the children have been duplicated too and are below the new parent ERROR test_ocb70

[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl

2014-04-25 Thread Alexandre Fayolle - camptocamp
The proposal to merge lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

2014-04-25 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, test LGTM -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-nameerror-1312682 into lp:lp-community-utils

2014-04-25 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep into lp:openerp-product-attributes

2014-04-25 Thread Alexandre Fayolle - camptocamp
The proposal to merge lp:~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep into lp:openerp-product-attributes has been updated. Description changed to: add module partner_custom_attributes For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting

2014-04-24 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849 Your team Account Core Editors is subscribed to branch lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma

2014-04-24 Thread Alexandre Fayolle - camptocamp
following the comment by Alexis on 23/04/2014 I'm setting this MP as work in progress -- https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls into lp:account-financial-report

2014-04-24 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM, code wise. -- https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma

2014-04-24 Thread Alexandre Fayolle - camptocamp
The proposal to merge lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into lp:ocb-addons/6.1

2014-04-23 Thread Alexandre Fayolle - camptocamp
Actually I had completely goofed the branches (uploaded my ocb branch to openobject-addons and proposed to merge there, hence the changes related to ocb present in the old MP). Should be fixed now. Thanks for the heads up, Yannick. --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-fix-1282584 into lp:openerp-rma

2014-04-23 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-fix-1282584/+merge/207450 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into lp:ocb-addons/6.1

2014-04-23 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into lp:ocb-addons/6.1. Requested reviews: OpenERP Core Team (openerp) Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review Yannick Vaucher @ Camptocamp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix-store-fields-mdh into lp:account-budgeting

2014-04-23 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no test Your SQL request maybe works but it is not written in an efficient way (2 DISTINCT, 1 subquery). This should be written with EXISTS. And, each time you bypass the ORM to write raw SQL, $DEITY kills a kitten. $DEITY also maims a puppy if you don't

[Openerp-community-reviewer] [Bug 1190236] Re: Kanban view doesn't show constraint error message

2014-04-22 Thread Alexandre Fayolle - camptocamp
** Also affects: ocb-web Importance: Undecided Status: New ** Also affects: ocb-web/7.0 Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web

2014-04-22 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1190236 in OpenERP Community Backports (Web): Kanban view doesn't show constraint error

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons

2014-04-22 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into lp:ocb-addons. Requested reviews: Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review Related bugs: Bug #1311004 in OpenERP Community Backports (Addons

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-report/purchase_print_button into lp:purchase-report

2014-04-18 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, test LGTM -- https://code.launchpad.net/~camptocamp/purchase-report/purchase_print_button/+merge/216024 Your team Purchase Core Editors is subscribed to branch lp:purchase-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into lp:hr-timesheet

2014-04-17 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test -- https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons

2014-04-16 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Bug 1308364] Re: [7.0] [trunk] report_webkit precise mode does not take in account set_context

2014-04-16 Thread Alexandre Fayolle - camptocamp
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/7.0 Status: New = Fix Committed ** Changed in: openobject-addons Status: New = Fix Committed ** Changed

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1281290-afe into lp:ocb-server

2014-04-14 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/ocb-server/7.0-fix_1281290-afe into lp:ocb-server. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1281290 in OpenERP Community Backports (Server): Wrong currency code - Poland https

[Openerp-community-reviewer] [Bug 1281290] Re: Wrong currency code - Poland

2014-04-14 Thread Alexandre Fayolle - camptocamp
** Also affects: openobject-server Importance: Undecided Status: New ** Also affects: ocb-server Importance: Undecided Status: New ** Also affects: ocb-addons Importance: Undecided Status: New -- You received this bug notification because you are a member of

[Openerp-community-reviewer] [Bug 1281290] Re: Wrong currency code - Poland

2014-04-14 Thread Alexandre Fayolle - camptocamp
** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/7.0 Assignee: (unassigned) = Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) -- You received this bug notification because you are a member of OpenERP Community Backports Team

  1   2   3   >