[Openerp-community-reviewer] [Bug 1204920] Re: [trunk] UnboundLocalError: local variable 'partner' referenced before assignment

2014-04-16 Thread Stefan Rijnhart (Therp)
Hi Mike Nivato, I don't think the fix is released on ocb-server. The proposal is still under review. ** Changed in: ocb-server/7.0 Status: Fix Released = Fix Committed -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons

2014-04-16 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1308364 in OpenERP Addons: [7.0] [trunk] report_webkit precise mode does not take in account set_context

[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-report/purchase_print_button into lp:purchase-report

2014-04-16 Thread Vincent Renaville@camptocamp
Vincent Renaville@camptocamp has proposed merging lp:~camptocamp/purchase-report/purchase_print_button into lp:purchase-report. Requested reviews: Purchase Core Editors (purchase-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons

2014-04-16 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Bug 1308364] Re: [7.0] [trunk] report_webkit precise mode does not take in account set_context

2014-04-16 Thread Alexandre Fayolle - camptocamp
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/7.0 Status: New = Fix Committed ** Changed in: openobject-addons Status: New = Fix Committed ** Changed

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons

2014-04-16 Thread Romain Deheele - Camptocamp
Review: Approve code review, no test LGTM, Romain -- https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-report/purchase_print_button into lp:purchase-report

2014-04-16 Thread Vincent Renaville@camptocamp
The proposal to merge lp:~camptocamp/purchase-report/purchase_print_button into lp:purchase-report has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~camptocamp/purchase-report/purchase_print_button/+merge/216024 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/fix-1308364-nbi into lp:ocb-addons

2014-04-16 Thread Pedro Manuel Baeza
Review: Approve code review LGTM Regards. -- https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

2014-04-16 Thread Nicola Malcontenti - Agile BG
Tests should be ready -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management

2014-04-16 Thread Nicolas Bessi - Camptocamp
Hello, Thank for the fixes. The UPDATE NO WAIT will lock the selected rows at postgres database level. It will avoid a process using the base_location data to alter flushed entries. It will also avoiding having many concurrent instance of the wizard running on the same rows. In this case I

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde into lp:stock-logistic-flows

2014-04-16 Thread Romain Deheele - Camptocamp
The proposal to merge lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde into lp:stock-logistic-flows has been updated. Status: Needs review = Work in progress For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

2014-04-16 Thread Romain Deheele - Camptocamp
The proposal to merge lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows has been updated. Status: Needs review = Work in progress For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde into lp:stock-logistic-flows

2014-04-16 Thread Romain Deheele - Camptocamp
Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde into lp:stock-logistic-flows. Requested reviews: Leonardo Pistone - camptocamp (lpistone): code review Stock and Logistic Core Editors

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde into lp:stock-logistic-flows

2014-04-16 Thread Romain Deheele - Camptocamp
Hi Leonardo, I added some tests. Romain -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde/+merge/215147 Your team Stock and Logistic Core Editors is requested to review the proposed merge of

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

2014-04-16 Thread Romain Deheele - Camptocamp
Hi, Tests are added. SQL is removed and replaced by ORM searchs. Description has been updated. Romain -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568 Your team Stock and Logistic Core Editors is

[Openerp-community-reviewer] [Bug 1112467] Re: [7.0] search on res.groups full_name function field doesn't accept 'in' operator

2014-04-16 Thread Denis Ledoux (OpenERP)
Fix released in http://bazaar.launchpad.net/~openerp/openobject- server/7.0/revision/5282 ** Changed in: ocb-server/7.0 Status: Confirmed = Fix Released ** Changed in: openobject-server Status: Fix Committed = Fix Released -- You received this bug notification because you are a

[Openerp-community-reviewer] [Bug 1256392] Re: my task form - for leads - missing lead_id

2014-04-16 Thread OpenERP
Fix landed in 7.0 at revision 9988 revid t...@openerp.com-20140416130356-i3a5pqcib8smdx47. -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/1256392 Title: my task form - for leads -

[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584 into lp:margin-analysis

2014-04-16 Thread Guewen Baconnier @ Camptocamp
Guewen Baconnier @ Camptocamp has proposed merging lp:~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584 into lp:margin-analysis. Requested reviews: Margin Analysis Core Editors (margin-analysis-core-editors) Related bugs: Bug #1308584 in Financial controlling and

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584 into lp:margin-analysis

2014-04-16 Thread Pedro Manuel Baeza
Review: Approve code review LGTM. I avoid always I can to make a replace operation, making invisible the field instead. Regards. -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584/+merge/216124 Your team Margin Analysis Core Editors is

[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi into lp:web-addons

2014-04-16 Thread Acsone
Stéphane Bidoul (Acsone) has proposed merging lp:~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi into lp:web-addons. Requested reviews: Web-Addons Core Editors (webaddons-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi into lp:web-addons

2014-04-16 Thread Pedro Manuel Baeza
Review: Approve code review Thanks for the fix! Regards. -- https://code.launchpad.net/~acsone-openerp/web-addons/web_easy_switch_company-userform-fix-sbi/+merge/216170 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0

2014-04-16 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Abstain @Holger, took your comments into consideration Taking myself out of the Reviewer list since I have contributed. -- https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960 Your team OpenERP Community Reviewer/Maintainer is

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0

2014-04-16 Thread Sandy Carter (http://www.savoirfairelinux.com)
You have been requested to review the proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0. For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company into lp:web-addons

2014-04-16 Thread Ray Carnes
FYI: The module doesn't work for regular users and Sylvain is looking into it. Everyone - can you remember when testing modules (that you write, and that you test for suitability for merge proposals) that you test with non ADMIN users? This didn't happen for this module. My boss isn't happy I