Ray, your boss should be glad you helped the community pointing out a bug. This
is really not nice complaining about other people free (as in beer, _and_, as
in speech) work.
And don't forget :
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_get_cost_field-standard_price-1308584/+merge/216124
Your team Margin Analysis Core Editors is subscribed to branch
lp:margin-analysis.
--
Mailing list:
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Vincent Renaville@camptocamp has proposed merging
lp:~camptocamp/purchase-report/purchase_print_button into lp:purchase-report.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
I just fixed the branch according to your reviews.
Thanks.
--
https://code.launchpad.net/~openerp-community/server-env-tools/7.0-modules-from-openobject-extension/+merge/200744
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list:
Nicola Malcontenti - Agile BG has proposed merging
lp:~agilebg/hotel-management-system/7.0-bug-1308639-hurrinico into
lp:hotel-management-system/7.0.
Requested reviews:
Hotel Editors (hotel-core-editors)
Related bugs:
Bug #1308639 in Hotel Management System: mx's import problem
Review: Abstain
I suspect the modules contained in lp:hotel-management-system/7.0 are not ready
for v7
I would test the modules contained in
lp:~serpentcs/hotel-management-system/hotel-7.0 and possibly merge them into
lp:hotel-management-system/7.0
--
Maxime Chambreuil (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/sale-wkfl/sale_lot_tracking into lp:sale-wkfl.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
The proposal to merge lp:~savoirfairelinux-openerp/sale-wkfl/sale_lot_tracking
into lp:sale-wkfl has been updated.
Description changed to:
[ADD] sale_lot_tracking
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/sale-wkfl/sale_lot_tracking/+merge/216323
--
Maxime Chambreuil (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/purchase-wkfl/purchase_profit_forecast into
lp:purchase-wkfl.
Commit message:
[ADD] Add purchase profit forecast
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more
Maxime Chambreuil (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/account-invoicing/account_invoice_line_merge into
lp:account-invoicing.
Commit message:
[ADD] account_invoice_purchase_origin module
Requested reviews:
Account Core Editors
Review: Approve
On a low-level, I see that elements of curr_ids that are not in ids should not
change the result. So I approve the fix.
On the other hand, I don't get what the method does. Could you take the
occasion to add a docstring or comment, and maybe rename tid, ids, curr_ids ...
Review: Approve
Good catch
--
https://code.launchpad.net/~camptocamp/account-consolidation/fix-domain-nbi/+merge/216331
Your team Account Core Editors is subscribed to branch
lp:account-consolidation/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/report-print-send/7.0-no-lock-in-update-1308635-ls into
lp:report-print-send.
Requested reviews:
Report Printing and Sending Core Editors (report-print-send-core-editors)
Related bugs:
Bug #1308635 in Report - Printing
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/report-print-send/7.0-default-bool-required-lp1308614-ls
into lp:report-print-send.
Requested reviews:
Report Printing and Sending Core Editors (report-print-send-core-editors)
Related bugs:
Bug #1308614 in Report -
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls into
lp:report-print-send.
Requested reviews:
Report Printing and Sending Core Editors (report-print-send-core-editors)
Related bugs:
Bug #1116672 in Report - Printing and
Review: Approve code review
LGTM. It doesn't make sense to mark a boolean as required.
Regards.
--
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-default-bool-required-lp1308614-ls/+merge/216354
Your team Report Printing and Sending Core Editors is subscribed to branch
Review: Needs Fixing code review
Hi, Lionel, you can use this better form:
user = self.pool['res.users]).browse(cr, uid, uid, context=context)
Regards.
--
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls/+merge/216356
Your team Report Printing and
Hi Pedro,
I avoided this form on purpose because it's the first thing people break when
they inherit ORM methods, and I read it's getting deprecated in v8 (not sure,
can't find the reference).
Would you still like me to change it?
--
What is exactly been deprecated?
- About self.pool[], here it's a good explanation why it's better:
http://hypered.io/blog/2013-12-30-self-pool-get/
- About (cr, uid, uid... instead of (cr, uid, [uid], the explanation is simple:
ORM methods allow lists or single ids, and in this case, you save
I was talking about using a single ID sorry.
--
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls/+merge/216356
Your team Report Printing and Sending Core Editors is subscribed to branch
lp:report-print-send.
--
Mailing list:
Changed!
--
https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-user-browse-lp1116672-ls/+merge/216356
Your team Report Printing and Sending Core Editors is subscribed to branch
lp:report-print-send.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Approve code review
Uhm, I'm not aware about that deprecation, but it can be. I always avoid single
ID on read, write, and so on overrides, but I see no problem with browse
method. Do you know anyone that overrides this method?
In summary, I have no hard feeling about any form, so
About the single id thing I followed your advice.
In v8 it'll be out for read() at least according to this:
https://twitter.com/RaphaelCollet/status/403095308722139136
...but we'll need to fix a whole pile of code anyway if they deprecate it, so
one more won't make a difference.
--
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2
into lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
For more details, see:
MP: cf.
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix2/+merge/216380
www.noviat.com
Rusatiralaan 1, 1083 Brussel
+32 2 808 86 38
-Original Message-
From: boun...@canonical.com [mailto:boun...@canonical.com] On
26 matches
Mail list logo
