Thanks Yannick to point out that.
--
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Abstain
I asked myself about the way to merge origins.
A case seems not managed:
If a PO has origins A B and an other PO has B C, merge result won't be A B
C.
With standard OE processes, it's probably impossible, it's a bit a far-fetched
case, so I abstain me.
--
Review: Approve code review, no test
Hi Leonardo,
LGTM,
Romain
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is requested to review the proposed merge of
lp:~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep into
Review: Approve code review, no test
LGTM,
Romain
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_split_picking-display-button/+merge/211739
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
Your point makes sense, Romain.
I would rather leave it as it is, since:
1. This is just a refactor with a few tests added. It is probably better to
keep the existing functionality for now.
2. I'm not sure that can happen often in practice, and the implementation could
use string manipulation
** Also affects: ocb-addons
Importance: Undecided
Status: New
** Changed in: ocb-addons
Assignee: (unassigned) = Numérigraphe (numerigraphe)
** Changed in: ocb-addons
Importance: Undecided = Low
--
You received this bug notification because you are a member of OpenERP
Review: Needs Fixing code review
Hi Vincent,
Could you actualize the comment under the new created function def
print_purchase? (it doesn't mark the purchase as sent)
Thanks,
Romain
--
https://code.launchpad.net/~camptocamp/purchase-report/purchase_print_button/+merge/216024
Your team
Review: Approve code review
I update the comment ;)
--
https://code.launchpad.net/~camptocamp/purchase-report/purchase_print_button/+merge/216024
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is subscribed to branch lp:account-budgeting.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Pedro Manuel Baeza has proposed merging
lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Loïc Bellier - Numérigraphe has proposed merging
lp:~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM into lp:ocb-addons.
Requested reviews:
Lionel Sausin - Numérigraphe (lionel-sausin)
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1312045 in OpenERP Community Backports
Review: Approve
Ok for me
--
https://code.launchpad.net/~akretion-team/openerp-rma/add-crm-claim-rma-repair/+merge/215976
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Alex Comba - Agile BG has proposed merging
lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl.
Commit message:
[FIX] bug #1312024
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
following the comment by Alexis on 23/04/2014 I'm setting this MP as work in
progress
--
https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list:
Review: Approve code review, no test
LGTM, code wise.
--
https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Joël Grand-Guillaume @ camptocamp has proposed merging
lp:~camptocamp/department-mgmt/add-dep-on-project-task-jge into
lp:department-mgmt.
Requested reviews:
Department Core Editors (department-core-editors)
For more details, see:
The proposal to merge lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup
into lp:openerp-rma has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970
--
Review: Needs Information
Thanks Alex,
why did you remove the 'images' and 'sequence' items?
--
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is requested to review the proposed merge of
Alexis de Lattre has proposed merging
lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into
lp:account-financial-report/6.1.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
Related bugs:
Bug #1274194 in Account - Financial Report: Wrong
Hello,
A fix was integrated into openerp 7.0,
Thanks
revno: 10013 [merge]
revision-id: m...@openerp.com-20140424152206-m4dnmee28w3yomsq
** Changed in: openobject-addons
Status: Confirmed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Hello,
A fix for this issue was merged into openerp 7.0, at revision 9898
** Changed in: openobject-addons
Status: Confirmed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Lorenzo,
following are listed the reasons:
'images': this key doesn't compare in
https://doc.openerp.com/trunk/server/03_module_dev_01/#manifest-file-openerp-py:
also comparing https://www.openerp.com/apps/7.0/product_by_supplier/ and
https://www.openerp.com/apps/7.0/product_supplier_info/ I
Review: Approve code review
LGTM.
Regards.
--
https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Review: Needs Fixing code review, test
on_change_invoice_id function uses company_id in parameters,
you need to add the field company_id in the crm.claim view
crm_case_claims_form_view.
Regards,
Romain
--
Review: Needs Fixing code review
Hi, Joël,
The MP you have done seems good, but I see a little problem: this modification
can give the user a false impression that the department is selected by task,
and when they try to change it, they get frustrated, because it's readonly.
I advice to
Review: Approve code review
Also OK.
Thanks.
--
https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report/6.1.
--
Mailing list:
Review: Needs Fixing code review
Hi, Alex, some remarks:
- Contributors are put on 'contributors' key in manifest file as a list, not in
description.
- I prefer to add purchase as dependency that changes the place where the menu
is displayed, because this query is not useful if you don't use
Chang Phui-Hock has proposed merging lp:~codekaki/openerp-hr/7.0-hr_roster into
lp:openerp-hr.
Requested reviews:
HR Core Editors (hr-core-editors)
For more details, see:
https://code.launchpad.net/~codekaki/openerp-hr/7.0-hr_roster/+merge/217116
Add duty roster module. It is useful when
Review: Approve code review
tested the 7.0 branche
--
https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report/6.1.
--
Mailing list:
Review: Approve code review and test
Thanks!
--
https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Review: Needs Fixing test
@ehdem
l205: Can you put CMIS versions (1.0 or 1.1, not sure) ? 1.7 is a Magento
version.
Thanks
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
Review: Needs Fixing test
I got a stacktrace instead of an error message when testing the connection:
Server Traceback (most recent call last):
File /home/max/openerp/cmis/bzr/web/addons/web/session.py, line 89, in send
return openerp.netsvc.dispatch_rpc(service_name, method, args)
File
test
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
test
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_read/+merge/212260
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Hi Jöel,
This mainly adds a referenced field for project_id.department_id.
I believe that there is interest in having a future module adding a
department_id as a real Task attribute.
Because of this, I support Pedro's opinion on renaming the 'department_id'
field to 'project_department_id'.
--
35 matches
Mail list logo
