** Also affects: ocb-server
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Server).
https://bugs.launchpad.net/bugs/1157839
Title:
[7.0] users with
The proposal to merge lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into
lp:openerp-rma has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824
--
The proposal to merge lp:~camptocamp/openerp-rma/rma-fix-lp1311509_rde into
lp:openerp-rma has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311509_rde/+merge/216824
--
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Alexis de Lattre has proposed merging
lp:~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456 into
lp:hr-timesheet.
Requested reviews:
HR Core Editors (hr-core-editors)
Related bugs:
Bug #1316456 in HR - Timesheet Management: hr_timesheet_task : can't save
new task : Analytic
Katja Matthes has proposed merging
lp:~initos.com/sale-wkfl/7.0-add-sale_exception_warning into lp:sale-wkfl.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~initos.com/sale-wkfl/7.0-add-sale_exception_warning/+merge/218365
Add
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456/+merge/218364
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list:
Review: Approve code review
LGTM.
Regards.
--
https://code.launchpad.net/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456/+merge/218364
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list:
Review: Approve code review, no test
Makes sense.
--
https://code.launchpad.net/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456/+merge/218364
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list:
- l282: syntax
- l177 typo
- can you please run flake8 on the module? there are some little issues here
and there.
- (non-blocking) if some methods are copied to just override a small thing, it
would help to have a precise reference to the original one.
- there are a couple of very long methods
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list:
Martin, can you please reconsider your review? your points should be fixed now.
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Review: Abstain
I abstain for the moment until I can review the MP.
--
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list:
Mohammad Alhashash has proposed merging
lp:~alhashash/ocb-addons/7.0-bug-1164630-rounding_check_in_partial_picking into
lp:ocb-addons.
Requested reviews:
OpenERP Community Backports (ocb)
For more details, see:
** Branch linked: lp:~alhashash/openobject-
addons/7.0-bug-1164630-rounding_check_in_partial_picking
** Branch linked: lp:~alhashash/ocb-
addons/7.0-bug-1164630-rounding_check_in_partial_picking
** Branch unlinked: lp:~openerp-dev/openobject-addons/trunk-
bug-1164630-Ravikant
** Also affects:
Thanks Leonardo,
I cleaned the code according to the flake8 recommandations, except lines length.
I prefer to leave lengths as it is to easily identify original code if
necessary.
Very long methods come from OpenERP core, and are not (easily) hookables for
the moment.
--
Anyway to rearrange the buttons? Put the change image and Save button under the
image should be much more proper since it push the names to the right a lot and
leave a large blank under it.
--
https://code.launchpad.net/~parthiv-patel/web-addons/web-addons/+merge/179846
Your team Web-Addons
Review: Approve
thanks romain
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde/+merge/215147
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
Review: Needs Fixing
l.416 Missing context propagation
Spelling:
You wrote OpenErp a few times. This should be OpenERP.
The description is oddly formulated, you may want it proofread.
Flake8:
cmis_write/__openerp__.py:58:26: W291 trailing whitespace
cmis_write/ir_attachment.py:125:5: E265 block
Still no unittests
--
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:knowledge-addons/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Fixing
l.471 Still severe bug and injection potential
Try:
filename = sql%' OR '1' = '1' OR '%injection
CMIS must provide a code escape function, otherwise use OpenERP's. It is
important that you don't do this manually.
https://en.wikipedia.org/wiki/Sql_injection
There are also
Review: Approve code review
ok, code-wise
--
https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Leonardo Pistone - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/7.0-fix-field-acl-lep into
lp:openerp-product-attributes.
Requested reviews:
Product Core Editors (product-core-editors)
Related bugs:
Bug #1316672 in OpenERP Product Attributes:
Laurent Mignon (Acsone) has proposed merging
lp:~lmi/ocb-addons/7.0-opw-596916-rgo into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports (ocb)
Related bugs:
Bug #1214866 in OpenERP Community Backports (Addons): [7.0][addons] no
multicompany support for lots
** Also affects: ocb-addons
Importance: Undecided
Status: New
** Changed in: ocb-addons
Assignee: (unassigned) = Laurent Mignon (Acsone) (lmi)
--
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community
Review: Approve code review
Thanks for the MP.
Regards.
--
https://code.launchpad.net/~lmi/ocb-addons/7.0-opw-596916-rgo/+merge/218476
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Mathieu Benoit has proposed merging
lp:~savoirfairelinux-openerp/purchase-wkfl/purchase_profit_forecast-missing-security-access
into lp:purchase-wkfl.
Requested reviews:
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)
Joao Alfredo Gama Batista (joao-gama)
For more details,
29 matches
Mail list logo
