Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0_1184983_compute_display_name into lp:partner-contact-management

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Needs Information Doesn't the module firstname_display_name_trigger already does this job? There is already a trigger in it to recompute display_name. -- https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_1184983_compute_display_name/+merge/220629 Your team Partner and

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0_1184983_compute_display_name into lp:partner-contact-management

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Disapprove firstname_display_name_trigger should already fix this issue. Thus I disapprove it. -- https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_1184983_compute_display_name/+merge/220629 Your team Partner and Contact Core Editors is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse

2014-05-23 Thread Lionel Sausin - Numérigraphe
Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse with lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available as a prerequisite. Requested reviews: Stock and Logistic

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available into lp:stock-logistic-warehouse

2014-05-23 Thread Lionel Sausin - Numérigraphe
Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available into lp:stock-logistic-warehouse. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-mrp into lp:stock-logistic-warehouse

2014-05-23 Thread Lionel Sausin - Numérigraphe
Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-mrp into lp:stock-logistic-warehouse with lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale as a prerequisite. Requested reviews: Stock and

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing Aggreed with Raphaël, Please provide a bug report and the same MP on official branch Thus the bug report will link ocb and official branch fixes. Cheers -- https://code.launchpad.net/~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank/+merge/208021 Your team

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-fix-button-visibility into lp:purchase-wkfl

2014-05-23 Thread Leonardo Pistone - camptocamp
Review: Approve lgtm thanks -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-button-visibility/+merge/205304 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-fix-button-visibility into lp:purchase-wkfl

2014-05-23 Thread noreply
The proposal to merge lp:~camptocamp/purchase-wkfl/7.0-fix-button-visibility into lp:purchase-wkfl has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-button-visibility/+merge/205304 --

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse

2014-05-23 Thread Lionel Sausin - Numérigraphe
The proposal to merge lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse has been updated. Description changed to: Add stock_available_sale: take sale quotations into account in the stock quantity available to promise stock_available

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web

2014-05-23 Thread Yann Papouin
Please do not forgot the MP against official branch -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1261332_better_report_name/+merge/219901 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons

2014-05-23 Thread Alexis de Lattre
I won't do a bug report on the official branch myself and a new MP because it will certainly be ignored and I don't have motivation nor time (cf https://lists.launchpad.net/banking-addons-drivers/msg00053.html). I did this bug report and MP on OCB because other members of the banking-addons

[Openerp-community-reviewer] [Bug 1261322] Re: [6.1][7.0][trunk] Default report filename is useless in daily use

2014-05-23 Thread Yann Papouin
** Also affects: ocb-web Importance: Undecided Status: New ** Also affects: ocb-web/6.1 Importance: Undecided Status: New ** Also affects: ocb-web/7.0 Importance: Undecided Status: New ** Changed in: ocb-web/6.1 Assignee: (unassigned) = Yann Papouin

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into lp:ocb-addons

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test It should be fine. If employee has no department_id, employee. Employee.department_id will return browse_null and browse_null.id will return False -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 Your

[Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt

2014-05-23 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 --

[Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt

2014-05-23 Thread noreply
The proposal to merge lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 --

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Approve Thanks for the changes Pedro LGTM -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into lp:openerp-reporting-engines

2014-05-23 Thread noreply
The proposal to merge lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into lp:openerp-reporting-engines has been updated. Status: Needs review = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-23 Thread Alexis de Lattre
This MP fixes the bug... but I still get a crash when I try to update a partner and add a SIREN + NIC. On a recent ocb 7.0 with an up-to-date lp:account-financial-tools merged with lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde, I get this crash : Server

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-23 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing according to Alexis, this needs fixing -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-23 Thread Alexis de Lattre
The bug is in the invalidation function _get_partner_change in company.py : the invalidation function should be : def _get_partner_change(self, cr, uid, ids, context=None): return self.pool['res.company'].search( cr, uid, [('partner_id', 'in', ids)], context=context)

[Openerp-community-reviewer] [Bug 1322248] Re: GTK client assertion error

2014-05-23 Thread Daniel Campos (Avanzosc)
** Project changed: ocb-addons = ocb-server -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Server). https://bugs.launchpad.net/bugs/1322248 Title: GTK client assertion error Status in OpenERP

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-23 Thread Alexis de Lattre
Review: Approve code review and test Thanks Yannick for applying the fix. I have tested the new branch and it works well. -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-23 Thread Alexandre Fayolle - camptocamp
Review: Approve -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-23 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools has been updated. Status: Needs review = Approved For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools

2014-05-23 Thread noreply
The proposal to merge lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools has been updated. Status: Approved = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Approve -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1261332_better_report_name/+merge/219901 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools

2014-05-23 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools has been updated. Status: Needs review = Approved For more details, see:

[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools

2014-05-23 Thread noreply
The proposal to merge lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools has been updated. Status: Approved = Merged For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries

2014-05-23 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries has been updated. Status: Needs review = Approved For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries

2014-05-23 Thread noreply
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries has been updated. Status: Approved = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing I set as need fixing after Frederic's comment -- https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch

[Openerp-community-reviewer] [Bug 1322248] Re: GTK client assertion error

2014-05-23 Thread Pedro Manuel Baeza
Hi, Daniel, this error is specific of GTK client, and this one is not supported on OCB, only web client. Regards. ** Changed in: ocb-server Status: New = Invalid -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test LGTM thanks for the contrib! -- https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report

2014-05-23 Thread Pedro Manuel Baeza
Review: Needs Information This method has been removed from 8.0 version, so I'm wondering if it's convenient to change this in 7 to revert back again on 8. Regards. -- https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240 Your team Account Report

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report

2014-05-23 Thread Laurent Mignon (Acsone)
HI, Finally not sure if it's the right way to solve our problem since Odoo has decided to remove the call to migration scripts on first install of a module :( https://bugs.launchpad.net/openobject-server/+bug/1314680 Regards, lmi --

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report

2014-05-23 Thread Yannick Vaucher @ Camptocamp
Review: Needs Information You are right forgot that sudden move from Odoo At least it fixes this issue in 7.0 but this would be more effort when porting to 8.0. Thus I revert my review as we need to find an other way of ensuring values are defined. BTW shouldn't store be computed when