Re: [Openerp-community-reviewer] [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

2014-06-04 Thread Lorenzo Battistini - Agile BG
On 06/03/2014 10:35 PM, Sergio Corato wrote: Hi Nicola, Lorenzo, Holger, what about delete commercial_month field and put this code instead? if line.months != 0: And in the view set the field days required if months if false and viceversa: field name=months

Re: [Openerp-community-reviewer] [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

2014-06-04 Thread Sergio Corato
Ciao Lorenzo, they aren't mutually exclusive, in this way only one of them is needed. But it would be better to set field days invisibile if months are set. 2014-06-04 8:03 GMT+02:00 Lorenzo Battistini - Agile BG lorenzo.battist...@agilebg.com: On 06/03/2014 10:35 PM, Sergio Corato wrote:

Re: [Openerp-community-reviewer] [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

2014-06-04 Thread Sergio Corato
In everyway, I overwritten the function (instead of overriden) and cover the case of 'days' too (for other purposes). 2014-06-04 8:12 GMT+02:00 Sergio Corato sergiocor...@gmail.com: Ciao Lorenzo, they aren't mutually exclusive, in this way only one of them is needed. But it would be better

Re: [Openerp-community-reviewer] [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

2014-06-04 Thread Lorenzo Battistini - Agile BG
On 06/04/2014 08:18 AM, Sergio Corato wrote: In everyway, I overwritten the function (instead of overriden) and cover the case of 'days' too (for other purposes). 2014-06-04 8:12 GMT+02:00 Sergio Corato sergiocor...@gmail.com: Ciao Lorenzo, they aren't mutually exclusive, in this way only

Re: [Openerp-community-reviewer] [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

2014-06-04 Thread Nicola Riolini - Micronaet
Hi all, my intention is XOR fileds, so mutually exclusive, I dont' like in this case hide days if month is written or other attrs operation, this because at start time user see all two fields so he thinks that both are writable. I prefer a check to let choose the method, but I'm open to new

Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

2014-06-04 Thread Lorenzo Battistini - Agile BG
Review: Approve code review -- https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl

2014-06-04 Thread Alexandre Fayolle - camptocamp
I've fixed Lorenzo's remarks, and moved the migration script to an init method as the migration script may not be executed on initial installation -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/222111 Your team Sale Core Editors is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl

2014-06-04 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl. Requested reviews: Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c): code review + no tests Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review,

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/add-partner_relation into lp:partner-contact-management

2014-06-04 Thread Alexis de Lattre
@Holger I had a quick look at your code. Let's try to look at it together tomorrow or Friday to see what's common, what's different, and see if we can enhance the partner_relation module with some ideas from your module. --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-forecast-prepaid into lp:account-closing

2014-06-04 Thread Benoit Guillot - http://www.akretion.com
Review: Approve code review no test LDTM -- https://code.launchpad.net/~akretion-team/account-closing/70-forecast-prepaid/+merge/210066 Your team Account Core Editors is requested to review the proposed merge of lp:~akretion-team/account-closing/70-forecast-prepaid into lp:account-closing. --