[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into lp:sale-wkfl

2014-06-26 Thread Lorenzo Battistini - Agile BG
The proposal to merge lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into lp:sale-wkfl has been updated. Status: Needs review = Work in progress For more details, see:

[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into lp:sale-wkfl

2014-06-26 Thread Alex Comba - Agile BG
Alex Comba - Agile BG has proposed merging lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into lp:sale-wkfl. Commit message: [ADD] module 'sale_line_quantity_properties_based' Requested reviews: Lorenzo Battistini - Agile BG (elbati) Sale Core Editors

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting

2014-06-26 Thread Matthieu Dietrich @ camptocamp
Review: Approve LGTM. -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix_red_test-afe/+merge/224581 Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/vre_account_invoice_report into lp:account-invoice-report

2014-06-26 Thread Vincent Renaville@camptocamp
Vincent Renaville@camptocamp has proposed merging lp:~camptocamp/account-invoice-report/vre_account_invoice_report into lp:account-invoice-report. Requested reviews: Account Core Editors (account-core-editors) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~invitu/project-service/7.0-issue_task-dr-synctaskissue into lp:project-service

2014-06-26 Thread invitu
invitu has proposed merging lp:~invitu/project-service/7.0-issue_task-dr-synctaskissue into lp:project-service. Requested reviews: Project Core Editors (project-core-editors) For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting

2014-06-26 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting. Requested reviews: Account Core Editors (account-core-editors) Related bugs: Bug #1334605 in Account - Budgeting: budget: tests are red

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting

2014-06-26 Thread Romain Deheele - Camptocamp
Review: Approve code review LGTM too, Romain -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix_red_test-afe/+merge/224602 Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting

2014-06-26 Thread noreply
The proposal to merge lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix_red_test-afe/+merge/224602 --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/vre-budget-responsible-group into lp:account-budgeting

2014-06-26 Thread noreply
The proposal to merge lp:~camptocamp/account-budgeting/vre-budget-responsible-group into lp:account-budgeting has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/account-budgeting/vre-budget-responsible-group/+merge/223705 --

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-forecast-prepaid into lp:account-closing

2014-06-26 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no tests please add automated tests. Additionally I'm interested in an explanation about the various comparison operators used : sometimes you use strict inequality, sometime -or-equal comparison (e.g. line 241 vs line 248). --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep into lp:sale-wkfl

2014-06-26 Thread Romain Deheele - Camptocamp
Hi, I commited needed changes about my last comment. I added too : to populate the merged order, provide id of dest_address instead of browse_record Regards, Romain -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756 Your team Sale Core Editors is

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep into lp:sale-wkfl

2014-06-26 Thread Romain Deheele - Camptocamp
Review: Abstain As I commited too, I change my review to : Abstain -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-bug-1296740-elbati into lp:account-consolidation/7.0

2014-06-26 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, test -- https://code.launchpad.net/~agilebg/account-consolidation/7.0-bug-1296740-elbati/+merge/212487 Your team Account Core Editors is subscribed to branch lp:account-consolidation/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

[Openerp-community-reviewer] [Bug 1334657] [NEW] Infinitie loop in procurement.order's _procure_confirm

2014-06-26 Thread arthru
Public bug reported: An infinite loop is present in procurement.order's method _procure_confirm if a procurement is in the state confirmed, with the procure method make_to_order, and it's date_planned is less than a date. ** Affects: ocb-addons Importance: Undecided Status: New --

[Openerp-community-reviewer] [Merge] lp:~arthru/ocb-addons/fix-1334657 into lp:ocb-addons

2014-06-26 Thread arthru
arthru has proposed merging lp:~arthru/ocb-addons/fix-1334657 into lp:ocb-addons. Requested reviews: OpenERP Community Backports (ocb) For more details, see: https://code.launchpad.net/~arthru/ocb-addons/fix-1334657/+merge/224623 Fix the bug lp:1334657 : makes it possible to exit the loop --

[Openerp-community-reviewer] [Merge] lp:~arthru/ocb-addons/fix-1334665 into lp:ocb-addons

2014-06-26 Thread arthru
arthru has proposed merging lp:~arthru/ocb-addons/fix-1334665 into lp:ocb-addons. Requested reviews: OpenERP Community Backports (ocb) For more details, see: https://code.launchpad.net/~arthru/ocb-addons/fix-1334665/+merge/224625 This fixes the bug #1334665 --

Re: [Openerp-community-reviewer] [Merge] lp:~arthru/ocb-addons/fix-1334665 into lp:ocb-addons

2014-06-26 Thread Raphaël Valyi - http : //www . akretion . com
Review: Approve Hello, one could wonder if it wouldn't be better to return the value of the _procure_confirm or _procure_orderpoint_confirm above. But as there are two methods and not just one, we couldn't just favor the return value of just one of the two methods. Moreover, the return value

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-add-base-class-for-carrier-configs into lp:carriers-deliveries

2014-06-26 Thread David BEAL (ak)
Thank you florian, Ok for me -- https://code.launchpad.net/~akretion-team/carriers-deliveries/7-add-base-class-for-carrier-configs/+merge/224598 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~arthru/ocb-addons/fix-1334665 into lp:ocb-addons

2014-06-26 Thread Pedro Manuel Baeza
Review: Approve code review As stated by Raphael, it's the best question. Regards -- https://code.launchpad.net/~arthru/ocb-addons/fix-1334665/+merge/224625 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~arthru/ocb-addons/fix-1334665 into lp:ocb-addons

2014-06-26 Thread Pedro Manuel Baeza
s/question/solution -- https://code.launchpad.net/~arthru/ocb-addons/fix-1334665/+merge/224625 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh into lp:account-financial-report

2014-06-26 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no test please add an automated test which exercises the new code, so that we can at least easily check that it does not crash. -- https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh/+merge/214905 Your team Account

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-consolidation/7.0-fix_1334639-afe into lp:account-consolidation

2014-06-26 Thread Lorenzo Battistini - Agile BG
Review: Resubmit wrong target -- https://code.launchpad.net/~camptocamp/account-consolidation/7.0-fix_1334639-afe/+merge/224629 Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/account-consolidation/7.0-fix_1334639-afe into lp:account-consolidation.

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-add-account_trial_balance_period_xls into lp:account-financial-report

2014-06-26 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no tests 1. please run flake8 on the code and fix the issues. There are lots of long lines, missing/superfluous spaces, as well as unused imports. 2. please add an automated test which will generate a report and ensure at least some coverage of the module.

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra into lp:account-financial-report

2014-06-26 Thread Alexandre Fayolle - camptocamp
Review: Needs Information code review, no tests I find your naming very confusing. Could you clarify what is space and what is namespace here? -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra/+merge/220527 Your team Account

[Openerp-community-reviewer] [Bug 1197467] Re: duplicate inventory lines produce wrong posted inventories

2014-06-26 Thread Lionel Sausin - Numérigraphe
** Also affects: ocb-addons Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1197467 Title: duplicate

[Openerp-community-reviewer] [Bug 1197467] Re: duplicate inventory lines produce wrong posted inventories

2014-06-26 Thread Launchpad Bug Tracker
** Branch linked: lp:~numerigraphe-team/ocb-addons/7.0-inventory-refuse- duplicate-lines -- You received this bug notification because you are a member of Stock and Logistic Core Editors, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1197467 Title: duplicate inventory

[Openerp-community-reviewer] [Bug 1197467] Re: duplicate inventory lines produce wrong posted inventories

2014-06-26 Thread Lionel Sausin - Numérigraphe
Unfortunately we somehow missed Cedric Le Brouster's patch so we can't test it in time four our own inventory. So as a preventive measure I've pushed a branch that takes the preventive route again, and forbids duplicate lines. ** Tags added: inventory -- You received this bug notification

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0

2014-06-26 Thread Sandy Carter (http://www.savoirfairelinux.com)
Diff comments: === added directory 'cmis_write' === added file 'cmis_write/__init__.py' --- cmis_write/__init__.py1970-01-01 00:00:00 + +++ cmis_write/__init__.py2014-05-29 22:13:35 + @@ -0,0 +1,26 @@ +# -*- encoding: utf-8 -*-

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_journal_report_xls-namespace-extra into lp:account-financial-report

2014-06-26 Thread Luc De Meyer (Noviat)
Namespace means python namespace. Luc www.noviat.com Rusatiralaan 1, 1083 Brussel +32 2 808 86 38 -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Alexandre Fayolle - camptocamp Sent: donderdag 26 juni 2014 16:21 To: