https://github.com/odoo/odoo/pull/829
--
https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order/+merge/209708
Your team OpenERP Community Backports is subscribed to branch lp:ocb-server.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Loïc Bellier - Numérigraphe has proposed merging
lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons.
Requested reviews:
Lionel Sausin - Numérigraphe (lionel-sausin)
Laetitia Gangloff (Acsone) (laetitia-gangloff)
OpenERP Community Backports (ocb)
Related bugs:
Review: Approve co-author
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty/+merge/223929
Your team OpenERP Community Backports is requested to review the proposed merge
of lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into
lp:ocb-addons.
Review: Abstain
This seems to fix the rounding issues we still encountered with precision=0.01.
It's still not the exact same rounding rules as the computation of
qty_available but it should be close enough.
--
Review: Abstain co-author
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty/+merge/223929
Your team OpenERP Community Backports is requested to review the proposed merge
of lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into
lp:ocb-addons.
Review: Needs Information
Hi Yannick,
so this is already on the v7 on github. Now that OCB migration to github is in
progress,
should we merge that in ocb on launchpad?
Other than that, I would approve the change.
Thanks!
--
The proposal to merge
lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase
into lp:~account-core-editors/account-financial-tools/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
The proposal to merge
lp:~akretion-team/account-financial-tools/account-financial-tools-check-deposit
into lp:~account-core-editors/account-financial-tools/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
The project has moved to Github https://github.com/OCA/account-financial-tools.
Please resubmit your MP on github using following procedure
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub.
I put this MP in rejected in the meanwhile.
Regards
--
The project has moved to Github https://github.com/OCA/account-financial-tools.
Please resubmit your MP on github using following procedure
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub.
I put this MP in rejected in the meanwhile.
Regards
--
The proposal to merge
lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh
into lp:~account-core-editors/account-financial-tools/7.0 has been updated.
Status: Needs review = Rejected
For more details, see:
Review: Disapprove
Hi Vincent,
Being an invoice an official document, It is a good idea to store the report
generated when the invoice was confirmed.
If, for example, the customer data, the product name, taxes, company
name/header change, the invoice document should not change. The current
This project is now hosted on https://github.com/OCA/carriers-deliveries.
Please move your proposal there if you still want to merge it once fixed. This
guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
This project is now hosted on https://github.com/OCA/carriers-deliveries.
Please move your proposal there if you still want to merge it once fixed. This
guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
(sorry David should have merged it
This project is now hosted on https://github.com/OCA/carriers-deliveries.
Please move your proposal there if you still want to merge it once fixed. This
guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
This project is now hosted on https://github.com/OCA/carriers-deliveries.
Please move your proposal there if you still want to merge it once fixed. This
guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Note to myself
This project is now hosted on https://github.com/OCA/carriers-deliveries.
Please move your proposal there if you still want to merge it once fixed. This
guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
--
Review: Disapprove code review
I also agree with Leonardo.
Regards.
--
https://code.launchpad.net/~camptocamp/account-invoice-report/vre_account_invoice_report/+merge/224593
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list:
The proposal to merge
lp:~camptocamp/account-invoice-report/vre_account_invoice_report into
lp:account-invoice-report has been updated.
Status: Needs review = Rejected
For more details, see:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list:
The proposal to merge
lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into
lp:account-invoice-report has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109
--
The proposal to merge
lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into
lp:account-invoice-report has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109
--
Thanks for the fix.
--
https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Replay isn't working yet and passing from lp to github will make us having to
replay all the MP we did.
I think that while we don't have OCB fully working on github we can fill the
gap by merging that kind of MP in OCB on launchpad.
--
The proposal to merge
lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into
lp:account-invoice-report has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge
lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into
lp:account-invoice-report has been updated.
Status: Approved = Merged
For more details, see:
I merge this before migration to github. Missing 1 approve but only touch
translation so this is not critical.
--
https://code.launchpad.net/~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation/+merge/214179
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
Thanks Leatitia for this MP
--
https://code.launchpad.net/~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation/+merge/214179
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list:
The proposal to merge
lp:~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address
into lp:account-invoice-report has been updated.
Status: Needs review = Approved
For more details, see:
Please merge here on LP for the coming days, not on GitHub. The OCB branches
will be overwritten by the final migration.
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1311087-rgo/+merge/224247
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
This project is now hosted on https://github.com/OCA/account-invoice-reporting.
Please move your proposal there if you still want to merge it once fixed. This
guide may help you
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
Sorry Lorenzo didn't had the
Hi Yannick,
does the migration still needed even if the MP has 3 approves?
I remain awaiting your confirmation before to proceed it. Thank you in advance.
--
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and
Sorry for having a bit rushed the migration of this branch. One way or the
other we must replicate this MP as a PR on github, now. Can you do this and
putting this MP as reference, the PR will be merged fast as it was already
approved.
--
Ok, no problem!
I will migrate it to github asap. Thank you.
--
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is subscribed to branch
Review: Approve
Thanks a lot Stefan.
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1311087-rgo/+merge/224247
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve
Romain,
I approve your changes, thanks
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
This MP introduced a bug
If first purchase order has no origin, it will raise
...
if not porder.origin in order_infos['origin'] and not order_infos['origin']
in porder.origin: TypeError: argument of type 'bool' is not iterable
because order_infos['origin'] will contains False
--
Public bug reported:
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1091268
-purchase-merge-no-origin-duplicates/+merge/210169
Introduced a bug:
When first purchase order has no origin, it will raise the following
error:
OpenERP Server Error Client Traceback (most recent call
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons.
Commit message:
Fix purchase order do_merge w/ 1st origin empty introduced on OCB on rev 10009
Requested reviews:
Yann Papouin (yann-papouin)
OpenERP Community Backports (ocb)
Review: Disapprove
Personally I think this merge proposal is tackling the problem from the wrong
end.
If we do not have an origin for a purchase order, the value for origin should
be NULL, not an empty string.
The original code that introduced the bug should be amended to account for the
The proposal to merge
lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase
into lp:~account-core-editors/account-financial-tools/7.0 has been updated.
Status: Rejected = Work in progress
For more details, see:
Submitted on github: https://github.com/OCA/account-financial-tools/pull/4
--
https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase/+merge/219849
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
Ok I though empty string were store as Null as zero value for integer. Just
check and it seems I'm wrong. I'll add a check instead of forcing to empty
string.
Thanks for the review
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028
Your team OpenERP Community
@Ronald, I changed the fix according to your review
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
44 matches
Mail list logo
