Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list:
Review: Approve code review
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list:
Review: Needs Fixing
- id is not a great variable name, python has id() already.
- wouldn't it be the same to write result = list(ids) at line 21?
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community
- wouldn't it be the same to write result = list(ids) at line 21?
`list(ids)` wouldn't keep the order of ids.
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community Backports Team is requested to review
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into
lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1302630 in OpenERP Community Backports (Addons): [trunk/7.0]
Review: Approve code review
same as
https://code.launchpad.net/~camptocamp/openobject-addons/7.0_fix-document-search-order-by_rde/+merge/214483
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community
7 matches
Mail list logo