Review: Approve
Romain,
I approve your changes, thanks
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Hi,
I commited needed changes about my last comment.
I added too : to populate the merged order, provide id of dest_address
instead of browse_record
Regards,
Romain
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is
Review: Abstain
As I commited too, I change my review to : Abstain
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list:
Review: Needs Fixing test
Hi Leonardo,
In l.23
the call of super _key_fields_for_grouping returns a tuple object.
To add the element 'dest_adress_id' in l.24,
we need : return field_list + ('dest_address_id', )
Regards,
Romain
--
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review, no test
Hi Leonardo,
LGTM,
Romain
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is requested to review the proposed merge of
lp:~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep into
this depends on
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756
Your team Sale Core Editors is requested to review the proposed merge of
7 matches
Mail list logo
