Review: Approve
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
The proposal to merge
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
into lp:stock-logistic-flows has been updated.
Status: Needs review = Merged
For more details, see:
Review: Needs Fixing
Need fixing.
Set has a better performance than list and it should avoid duplicate.
Please see inline comment
Diff comments:
=== added directory 'picking_dispatch_wave'
=== added file 'picking_dispatch_wave/__init__.py'
--- picking_dispatch_wave/__init__.py 1970-01-01
https://wiki.python.org/moin/TimeComplexity
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
Thanks Nicolas,
I made changes accordingly.
I add a condition : only assigned pickings are selected.
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is
Review: Approve tests
Ok translations works now
Thanks for the changes.
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch
Thanks Yannick,
I've reworked terms and translation.
Romain
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
Review: Needs Fixing code review, no test
Shouldn't *_to_done private method be *_to_do or _to_be_done ?
Here are few remarks about translations:
* After installatation on fresh install with last code Wizard fields and label
aren't translated. (But this may not be related to this MP)
* In
Review: Approve code review, test
LGTM
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
The proposal to merge
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
into lp:stock-logistic-flows has been updated.
Status: Needs review = Work in progress
For more details, see:
Hi,
Tests are added.
SQL is removed and replaced by ORM searchs.
Description has been updated.
Romain
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is
Review: Needs Fixing code review, no test
Needs fixing:
* convert the description in __openerp__.py to Restructured Text
* please add a test
* I'm concerned the SQL query may bypass the multicompany security rules
* NEVER DO SQL PARAMETER SUBSTITUTION WITH THE % OPERATOR
--
The proposal to merge
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
into lp:stock-logistic-flows has been updated.
Status: Needs review = Work in progress
For more details, see:
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
into lp:stock-logistic-flows.
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details, see:
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
into lp:stock-logistic-flows.
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details, see:
15 matches
Mail list logo