Re: [Openerp-community-reviewer] [Merge] lp:~gdgellatly/server-env-tools/base-synchro-7.0 into lp:server-env-tools

2014-06-23 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, no tests If people are willing to maintain this, then I'm not opposed to merging in server-env-tools. 2 points, though, to gain my approval: * the various size constraints seem overzealous to me (esp. server URL and domain which are obviously too short for

Re: [Openerp-community-reviewer] [Merge] lp:~gdgellatly/server-env-tools/base-synchro-7.0 into lp:server-env-tools

2014-01-22 Thread Raphaël Valyi - http : //www . akretion . com
Review: Abstain Hello, I would say we could give a chance for people interested to support it until something better is made. Like many, I will probably not invest on it, if I invest on that I would invest on something different indeed. But if it does the job for some people... It isn't a lot

Re: [Openerp-community-reviewer] [Merge] lp:~gdgellatly/server-env-tools/base-synchro-7.0 into lp:server-env-tools

2014-01-22 Thread Joël Grand-Guillaume
Hi, I'm then also in favor of keeping this module if 2 entities are together to maintain it. Just for those who may miss that : https://code.launchpad.net/~openerp-community/openobject-addons/elico-7.0 ElicoCorp has made a synchronization tools based on the generic connector we built as a

Re: [Openerp-community-reviewer] [Merge] lp:~gdgellatly/server-env-tools/base-synchro-7.0 into lp:server-env-tools

2014-01-20 Thread Joël Grand-Guillaume
Review: Needs Information Hi, First of all, thank you a lot for all this work, my further comment doesn't criticize any of your investment in here. As this module has been abandoned by OpenERP, I'm not sure it's good to have it in our community modules. For what I know about this module he

Re: [Openerp-community-reviewer] [Merge] lp:~gdgellatly/server-env-tools/base-synchro-7.0 into lp:server-env-tools

2014-01-01 Thread Graeme Gellatly
Oops, meant to mention the insertion of the cr.commit() after each object is synced within the main synchronise method of the wizard. I don't really know any other way of doing it. The RPCProxy commits on each record. Provided one record commits correctly it is highly unlikely future records