Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Johannes Berg
On Wed, 2011-04-06 at 11:21 +0200, Antonio Ospite wrote: + if (regulator_is_enabled(vcc)) { + dev_dbg(pdev-dev, Regulator already enabled\n); + rfkill_data-reg_enabled = 1; + } + rfkill_init_sw_state(rf_kill, !rfkill_data-reg_enabled); + + ret =

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Antonio Ospite
On Wed, 06 Apr 2011 11:29:38 +0200 Johannes Berg johan...@sipsolutions.net wrote: On Wed, 2011-04-06 at 11:21 +0200, Antonio Ospite wrote: + if (regulator_is_enabled(vcc)) { + dev_dbg(pdev-dev, Regulator already enabled\n); + rfkill_data-reg_enabled = 1; + } +

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Johannes Berg
On Wed, 2011-04-06 at 16:06 +0200, Antonio Ospite wrote: + if (regulator_is_enabled(vcc)) { + dev_dbg(pdev-dev, Regulator already enabled\n); + rfkill_data-reg_enabled = 1; + } + rfkill_init_sw_state(rf_kill, !rfkill_data-reg_enabled); + + ret =

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Johannes Berg
On Wed, 2011-04-06 at 23:11 +0900, Mark Brown wrote: On Wed, Apr 06, 2011 at 11:21:19AM +0200, Antonio Ospite wrote: + tristate Generic rfkill regulator driver + depends on RFKILL || !RFKILL That looks *odd*. That's normal for rfkill -- if RFKILL==n then this can be anything since

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Antonio Ospite
On Wed, 06 Apr 2011 16:09:28 +0200 Johannes Berg johan...@sipsolutions.net wrote: On Wed, 2011-04-06 at 16:06 +0200, Antonio Ospite wrote: + if (regulator_is_enabled(vcc)) { + dev_dbg(pdev-dev, Regulator already enabled\n); +

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Antonio Ospite
On Wed, 6 Apr 2011 23:11:33 +0900 Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Apr 06, 2011 at 11:21:19AM +0200, Antonio Ospite wrote: + tristate Generic rfkill regulator driver + depends on RFKILL || !RFKILL That looks *odd*. Taken from Documentation/rfkill.txt

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Johannes Berg
On Wed, 2011-04-06 at 16:29 +0200, Antonio Ospite wrote: On Wed, 6 Apr 2011 23:11:33 +0900 Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Apr 06, 2011 at 11:21:19AM +0200, Antonio Ospite wrote: + tristate Generic rfkill regulator driver + depends on RFKILL || !RFKILL

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Joey Lee
Hi Antonio, 於 三,2011-04-06 於 16:24 +0200,Antonio Ospite 提到: On Wed, 06 Apr 2011 16:09:28 +0200 Johannes Berg johan...@sipsolutions.net wrote: On Wed, 2011-04-06 at 16:06 +0200, Antonio Ospite wrote: + if (regulator_is_enabled(vcc)) { + dev_dbg(pdev-dev,

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Johannes Berg
On Wed, 2011-04-06 at 20:12 +0200, Paul Bolle wrote: On Wed, 2011-04-06 at 16:21 +0200, Johannes Berg wrote: On Wed, 2011-04-06 at 23:11 +0900, Mark Brown wrote: On Wed, Apr 06, 2011 at 11:21:19AM +0200, Antonio Ospite wrote: + tristate Generic rfkill regulator driver +

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread John W. Linville
On Wed, Apr 06, 2011 at 08:12:22PM +0200, Paul Bolle wrote: On Wed, 2011-04-06 at 16:21 +0200, Johannes Berg wrote: On Wed, 2011-04-06 at 23:11 +0900, Mark Brown wrote: On Wed, Apr 06, 2011 at 11:21:19AM +0200, Antonio Ospite wrote: + tristate Generic rfkill regulator driver

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Paul Bolle
On Wed, 2011-04-06 at 14:38 -0400, John W. Linville wrote: The syntax may seem strange, It does! but basically it just says don't let me by y if RFKILL is m ... but, besides that, I can be any value. So in effect it's shorthand for depends on RFKILL=y || RFKILL=m m || RFKILL=n

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Johannes Berg
On Wed, 2011-04-06 at 22:10 +0200, Paul Bolle wrote: On Wed, 2011-04-06 at 14:38 -0400, John W. Linville wrote: The syntax may seem strange, It does! but basically it just says don't let me by y if RFKILL is m ... but, besides that, I can be any value. So in effect it's shorthand for

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Johannes Berg
On Wed, 2011-04-06 at 22:15 +0200, Johannes Berg wrote: On Wed, 2011-04-06 at 22:10 +0200, Paul Bolle wrote: On Wed, 2011-04-06 at 14:38 -0400, John W. Linville wrote: The syntax may seem strange, It does! but basically it just says don't let me by y if RFKILL is m ... but,

Re: [PATCH] rfkill: Regulator consumer driver for rfkill

2011-04-06 Thread Johannes Berg
On Wed, 2011-04-06 at 22:17 +0200, Johannes Berg wrote: On Wed, 2011-04-06 at 22:15 +0200, Johannes Berg wrote: On Wed, 2011-04-06 at 22:10 +0200, Paul Bolle wrote: On Wed, 2011-04-06 at 14:38 -0400, John W. Linville wrote: The syntax may seem strange, It does! but