Re: [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR

2011-05-10 Thread Sergei Shtylyov
Hello. On 10-05-2011 0:11, Antonio Ospite wrote: Don't wrap regulator_get() inside an #ifdef CONFIG_REGULATOR anymore, as now (since be1a50d) Need the summary of that commit cited too -- for the human readers. it correctly degenerates and returns NULL when the regulator framework is

Re: [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR

2011-05-10 Thread Russell King - ARM Linux
On Tue, May 10, 2011 at 10:02:14PM +0200, Antonio Ospite wrote: I was blindly trusting code already in mainline again, and for that I apologize, I finally took the time to look at the implementation of IS_ERR() and test its use, and being IS_ERR(NULL) true it is not what we want indeed, see

Re: [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR

2011-05-10 Thread Mark Brown
On Tue, May 10, 2011 at 10:02:14PM +0200, Antonio Ospite wrote: So, I am going to remove the ifdefs anyway but use IS_ERR_OR_NULL(); how does that sound? Am I still missing anything? Looks good to me. Or changing the regulator_get() stub to return an error (-ENOSYS?) might be worth it? No,