Re: [openib-general] [PATCH 05/17] ehca: InfiniBand query and multicast functionality

2006-03-03 Thread Hoang-Nam Nguyen
Hello Hal! Yes, will fix that. Good catch. Thanks! Mit freundlichen Gruessen/Kind Regards Hoang-Nam Nguyen Hal Rosenstock [EMAIL PROTECTED

Re: [openib-general] [PATCH 11/17] ehca: completion queue

2006-03-08 Thread Hoang-Nam Nguyen
Roland, Yes, that all makes sense. Will change my code appropriately. Thanks! Hoang-Nam Nguyen Roland Dreier [EMAIL PROTECTED

Re: [openib-general] RE: static rate encoding changes

2006-04-11 Thread Hoang-Nam Nguyen
Hoang-Nam Nguyen Index: src/userspace/libibverbs/include/infiniband/verbs.h === --- src/userspace/libibverbs/include/infiniband/verbs.h (revision 6377) +++ src/userspace/libibverbs/include/infiniband/verbs.h (working copy

[openib-general] patch: ibv_query_qp() causes segmentation fault if init_attr is NULL

2006-05-11 Thread Hoang-Nam Nguyen
; + init_attr-cap.max_recv_sge = resp.max_recv_sge; + init_attr-cap.max_inline_data = resp.max_inline_data; + init_attr-sq_sig_all = resp.sq_sig_all; + } return 0; } Thanks! Mit freundlichen Gruessen/Kind Regards Hoang-Nam Nguyen

Re: [openib-general] EHCA broken for 2.6.16?

2006-06-02 Thread Hoang-Nam Nguyen
-Nam Nguyen [EMAIL PROTECTED] wrote on 02.06.2006 03:57:08: Okay guys, what's up this time? Kernel 2.6.16.. CC [M] drivers/infiniband/hw/ehca/ehca_main.o In file included from drivers/infiniband/hw/ehca/ehca_qes.h:47, from drivers/infiniband/hw/ehca/ipz_pt_fn.h:46

Re: [openib-general] [PATCH] Fix some compile issues with libehca

2006-06-02 Thread Hoang-Nam Nguyen
Hi, will incorporate those patches in our code. They should be correct for both 64/32 bit version of libehca. Thanks! Hoang-Nam Nguyen [EMAIL PROTECTED] wrote on 02.06.2006 08:43:46: Hi, Heres a patch to fix some warnings about missing prototypes (memset etc), and one compile error due

Re: [openib-general] [PATCH 13/13] IB/ehca: makefiles/kconfig

2006-08-18 Thread Hoang-Nam Nguyen
the code that depends on them being different. Yes, that's true. Those defines are unnecessary. We'll throw them out. Thx Hoang-Nam Nguyen ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] [PATCH 02/13] IB/ehca: includes

2006-08-30 Thread Hoang-Nam Nguyen
are appreciated! Regards Hoang-Nam Nguyen ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] [PATCH 02/13] IB/ehca: includes

2006-08-30 Thread Hoang-Nam Nguyen
Hi Tziporet! RC3 is almost closed (going to be out tomorrow). Following this mail I wish to know if we need to update ehca for RC4. I'm generating a patch against OFED git tree ehca_branch and could provide you with a patch today if that makes sense to you. In the meanwhile we've made some local

Re: [openib-general] [PATCH 02/13] IB/ehca: includes

2006-08-30 Thread Hoang-Nam Nguyen
2006-08-30 20:01:34.0 +0200 @@ -4,6 +4,7 @@ * module start stop, hca detection * * Authors: Heiko J Schick [EMAIL PROTECTED] + * Hoang-Nam Nguyen [EMAIL PROTECTED] * * Copyright (c) 2005 IBM Corporation * @@ -47,7 +48,7 @@ MODULE_LICENSE(Dual BSD/GPL

Re: [openib-general] OFED 1.1 status

2006-09-08 Thread Hoang-Nam Nguyen
Hello Tziporet! First sorry for this late response regarding ehca build test in OFED 1.1 rc3. 1) The userspace lib dir for libehca contains only a few c-files, but no header files. On svn dir branches/1.1/src/userspace/libehca/src/ I saw all files needed. Please correct this for rc4! Will you

Re: [openib-general] [PATCH 2.6.19-rc1] ehca firmware interface based on Anton Blanchard's new hvcall interface

2006-09-23 Thread Hoang-Nam Nguyen
Hi Roland, Anyway both Paul and I merged with Linus today, so the hcall cleanup and ehca are both upstream. It would be great if you could do a quick check to make sure that ehca works in Linus's current git tree. I compiled Linus's git tree and did some basic tests successfully with ehca

[openib-general] [PATCH 2.6.19-rc1] ehca: fix ehca_probe if module loaded after ib_ipoib

2006-10-02 Thread Hoang-Nam Nguyen
. In addition to that this patch contains a very small format improvement in our tracing function. Thanks! Nam Nguyen Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_main.c | 36 +++- ehca_tools.h |2 +- 2 files changed, 20 insertions(+), 18 deletions

Re: [openib-general] [PATCH 2.6.19-rc1] ehca: fix ehca_probe if module loaded after ib_ipoib

2006-10-02 Thread Hoang-Nam Nguyen
Looks OK but your mailer mangled the patch. Please resend in a form that can be applied... please send unrelated changes as separate patches. So this should come as two patches -- one to fix the device registration, and one to change your debug formatting. ok, will resend those two patches

[openib-general] [PATCH 2.6.19-rc1 1/2] ehca: fix ehca device registration

2006-10-02 Thread Hoang-Nam Nguyen
! Nam Nguyen Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_main.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_main.c infiniband_work/drivers/infiniband/hw/ehca/ehca_main.c

[openib-general] [PATCH 2.6.19-rc1 2/2] ehca: improved ehca debug format

2006-10-02 Thread Hoang-Nam Nguyen
Hi, here is the 2nd patch of ehca with a small format improvement in ehca debug function. Thanks! Nam Nguyen Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_tools.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca

[openib-general] [PATCH ofed-1.1 1/2] ehca: fix ehca device registration

2006-10-02 Thread Hoang-Nam Nguyen
know what I did wrong. Anyway I created this patch against the dir openib-1.1 extracted from ofed-1.1-rc6/SOURCES/openib-1.1.tgz. Hope that it still works for you. Thanks! Nam Nguyen Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_main.c | 35 +++ 1

[openib-general] [PATCH ofed-1.1 2/2] ehca: improved ehca debug format

2006-10-02 Thread Hoang-Nam Nguyen
-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_tools.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -Nurp openib-1.1_orig/drivers/infiniband/hw/ehca/ehca_tools.h openib-1.1_work/drivers/infiniband/hw/ehca/ehca_tools.h --- openib-1.1_orig/drivers/infiniband/hw/ehca/ehca_tools.h

[openib-general] OFED-1.1-rc7 and mthca on ppc64: compile warnings

2006-10-11 Thread Hoang-Nam Nguyen
Just saw those warnings when I compiled kernel 2.6.18 on ppc64 using OFED-1.1-rc7 code with mthca and ehca selected. CC [M] drivers/infiniband/hw/mthca/mthca_qp.o drivers/infiniband/hw/mthca/mthca_qp.c: In function `mthca_arbel_post_send': drivers/infiniband/hw/mthca/mthca_qp.c:1870: warning:

Re: [openib-general] [openfabrics-ewg] OFED 1.1 release schedule

2006-10-16 Thread Hoang-Nam Nguyen
tomorrow this should be ok for us. Regards Hoang-Nam Nguyen ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] ibv_reg_mr failure with pvfs on ehca?

2006-10-17 Thread Hoang-Nam Nguyen
kernel version? Thanks! Hoang-Nam Nguyen ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

[openib-general] [PATCH OFED-1.1-rc7] libehca configure.in and config.h.in: fix missing check of libsysfs.h

2006-10-18 Thread Hoang-Nam Nguyen
Hello, below is a patch of configure.in and config.h.in in libehca. It checks the presence of libsysfs.h properly. Unfortunately I recognized this bug lately after I've fixed the openib.spec issues and tested ofed on a clean system. Thanks! Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED

Re: [openib-general] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs

2006-10-18 Thread Hoang-Nam Nguyen
Hi, Do we really want generated files in svn? Why? No. I was unsure if it's in ofed branch. And you're right, no need to. Ignore this! Thanks Nam ___ openib-general mailing list openib-general@openib.org

Re: [openib-general] ibv_reg_mr failure with pvfs on ehca?

2006-10-19 Thread Hoang-Nam Nguyen
Hello Troy and Kyle! Kyle wrote: Our app writes out a file once, then reads it in many times through the pvfs2 system. In the pvfs2 layers, there is memory caching done at the network level, so memory is registered by the app, and attempts are made to re-register and/or re-use these

Re: [openib-general] test results from Mellanox, Voltaire, QLogic, and IBM for OFED 1.1 rc7?

2006-10-19 Thread Hoang-Nam Nguyen
Hi, What testing did these companies do with rc7? Still testing rc7. Will post our results probably today evening. Regards! Nam ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To

Re: [openib-general] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs

2006-10-19 Thread Hoang-Nam Nguyen
Hi Vlad! Can this patch be saved for the next OFED-1.2 release? Note: OFED installation script checks that sysfsutils package installed. As Michael indicated in previous email configure is a generated file from autogen.sh. And I'm not sure if your packaging script does generate it automatically

Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs

2006-10-19 Thread Hoang-Nam Nguyen
Hi, The release is closed. We only updating the documents now (will be closed in the coming few hours only). Since ehca is in technology preview state these issues are not blockers. Please document all issues in ehca release_notes (or send me parts you want to include). Even though ehca is in

Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs

2006-10-19 Thread Hoang-Nam Nguyen
Hi Vlad, The code that fixes lib/lib64 issue on ppc64 and libehca.so to be in libehca RPM is in OFED-1.1. Thanks! Can you pls confirm if configure.in and config.h.in are in OFED-1.1 as well? Regards Nam ___ openib-general mailing list

Re: [openib-general] [openfabrics-ewg] test results from Mellanox, Voltaire, QLogic, and IBM for OFED 1.1 rc7?

2006-10-20 Thread Hoang-Nam Nguyen
Hi, attached please find the test results of OFED 1.1 pre1 in conjunction with IBM eHCA on POWER5. One comment: the build+installation tests were succeeded with pre1 as we had to apply patches for openib.spec, libehca/configure.in and libehca/config.h.in on our test systems. As Vlad explained in

Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs

2006-10-20 Thread Hoang-Nam Nguyen
Hi Vladimir! No, the updated configure.in and config.h.in are not in OFED-1.1. In any case, I believe that most of the checks you have added to configure scripts are provided by OFED installation scripts. So, in case OFED installation fails, ehca configure would fail as well. Created a

Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs

2006-10-22 Thread Hoang-Nam Nguyen
Hello Tziporet! I regret that some of the latest patches could not be included in the final release, but the main issue was that the patches came too late. Why didn't you tell me that when I reported you, Vladimir and Michael, also via direct emails asking for help, about the issues with ofed

Re: [openib-general] ibv_reg_mr failure with pvfs on ehca?

2006-10-22 Thread Hoang-Nam Nguyen
Hi Troy! The netpipe code is available with mercurial by: hg clone http://source.scl.ameslab.gov/hg/netpipe3-pvfs-dev Once you have pvfs2-1.5.1 installed, you should be able to do 'make pvfs' in the netpipe3-pvfs-dev directory and build NPpvfs. The command line arguments I used to reproduce

Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs

2006-10-23 Thread Hoang-Nam Nguyen
Hello Tziporet! I suggest that you fix what you want and create 1.0.1.1. You can place it in the svn releases area and direct people that need ehca to this version. We did something similar when we published 1.0.1 for which we added SLES9 SP3 support. Please place it on

Re: [openib-general] ibv_reg_mr failure with pvfs on ehca?

2006-10-23 Thread Hoang-Nam Nguyen
Hello Troy! The netpipe code is available with mercurial by: hg clone http://source.scl.ameslab.gov/hg/netpipe3-pvfs-dev Once you have pvfs2-1.5.1 installed, you should be able to do 'make pvfs' in the netpipe3-pvfs-dev directory and build NPpvfs. The command line arguments I used to

Re: [openib-general] ibv_reg_mr failure with pvfs on ehca?

2006-10-24 Thread Hoang-Nam Nguyen
Hi Kyle! And, setting the debug_level flag definitely caused the server to not respond... I rebooted and tried it again, same thing, setting the debug_level flag causes the server to crash. (I can still login, but cannot execute anything, e.g. 'ls', it seems all the cpu's are spinning)

[openib-general] [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode

2006-11-05 Thread Hoang-Nam Nguyen
for objects with 4k length and 4k alignment in order to alloc/free firmware control blocks in 64k page mode. In 4k page mode those wrappers just are defines of get_zeroed_page() and free_page(). Thanks! Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_hca.c| 17

[openib-general] [PATCH 2.6.19 2/4] ehca: hcp_phyp.c: correct page mapping in 64k page mode

2006-11-05 Thread Hoang-Nam Nguyen
Hello Roland! This is another patch of ehca for 64k page support. It fixes a bug that maps 4k aligned addresses in 64k page mode in a wrong way. Thanks! Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- hcp_phyp.c |5 +++--0018_64kpage_ioremap.patch 1 files changed, 3 insertions

[openib-general] [PATCH 2.6.19 3/4] ehca: Kconfig: activate scaling code as default to prevent drop packets (UD)

2006-11-05 Thread Hoang-Nam Nguyen
-Nam Nguyen [EMAIL PROTECTED] --- Kconfig |1 + 1 files changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/ehca/Kconfig b/drivers/infiniband/hw/ehca/Kconfig index 922389b..727b10d 100644 --- a/drivers/infiniband/hw/ehca/Kconfig +++ b/drivers/infiniband/hw/ehca/Kconfig @@ -10,6 +10,7

[openib-general] [PATCH 2.6.19 4/4] ehca: ehca_av.c use constant for max mtu

2006-11-05 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca, mainly a code change to adhere to kernel coding style. It defines and uses a constant EHCA_MAX_MTU instead hardcoded value. Thanks! Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_av.c |5 ++--- hipz_hw.h |2 ++ 2 files changed

Re: [openib-general] [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode

2006-11-06 Thread Hoang-Nam Nguyen
Hi Arnd, This seems broken. You have a constructor for newly allocated objects, but there is no destructor and it seems that objects passed to ehca_free_fw_ctrlblock are not guaranteed to be initialized either. I'd simply move the memset into the alloc function and get rid of the constructor

Re: [openib-general] [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode

2006-11-06 Thread Hoang-Nam Nguyen
Hi Roland! Arnd wrote: This seems broken. You have a constructor for newly allocated objects, but there is no destructor and it seems that objects passed to ehca_free_fw_ctrlblock are not guaranteed to be initialized either. I'd simply move the memset into the alloc function and get rid of

Re: [openib-general] [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode

2006-11-06 Thread Hoang-Nam Nguyen
[EMAIL PROTECTED] wrote on 06.11.2006 15:58:39: Maybe you want to make sure that ehca_alloc_fw_ctrlblock() always returns a void pointer, so you can avoid all the casts in your code? static inline void *ehca_alloc_fw_ctrlblock(void) { return (void *)get_zeroed_page(GFP_KERNEL); } Yes,

Re: [openib-general] [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode

2006-11-06 Thread Hoang-Nam Nguyen
Hi Roland! As Arnd stated I need to fix this ctor issue. Do you prefer me to resend all patches in proper format (non-mangled inline) or just this one bug fix? I have the rest of the patches, so you just need to resend a fixed version of this one. BTW see my previous response about

Re: [openib-general] ehca build on 2.6.18.2??

2006-11-13 Thread Hoang-Nam Nguyen
Troy Benjegerdes wrote: Um. So I built openib-1.1 from the OFED-1.1 tarball, and now I get: * p5l9:/usr/src/openib-1.1/src/userspace/libehca# ibv_devinfo libibverbs: Warning: no userspace device-specific driver found for uverbs0 driver search path: /usr/local/lib/infiniband

[openib-general] [PATCH 2.6.20] ehca: use proper flag for get_zeroed_page() to prevent BUG:scheduling while atomic...

2007-01-09 Thread Hoang-Nam Nguyen
data block. Use of GFP_ATOMIC prevents this issue. Since this has a good chance of crashing the kernel every time HCA error data is fetched, it would be great if you pushed this patch upstream. Regards Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_hca.c|8

[openib-general] [PATCH 2.6.21 0/8] ehca: remove use of do_mmap() from kernel space and minor cleanup

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland and Christoph H.! Here is a set of patches for ehca, whose main purpose is to remove unproper use of do_mmap() in ehca kernel space as suggested by Christoph H. Other small changes are: * Remove dead prototype declarations (those without code implementation) * Use SLAB_ defines

Re: [openib-general] [PATCH 2.6.21 0/8] ehca: remove use of do_mmap() from kernel space and minor cleanup

2007-01-11 Thread Hoang-Nam Nguyen
Please ignore this. Pushed the send button to fast again. Regards Nam On Thursday 11 January 2007 18:07, Hoang-Nam Nguyen wrote: Hello Roland and Christoph H.! Here is a set of patches for ehca, whose main purpose is to remove unproper use of do_mmap() in ehca kernel space as suggested

[openib-general] [PATCH/RFC 2.6.21 0/5] ehca: remove use of do_mmap() from kernel space

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland and Christoph H.! Here is a set of patches for ehca, whose main purpose is to remove unproper use of do_mmap() in ehca kernel space as suggested by Christoph H. Other small changes are: * Remove dead prototype declarations (those without code implementation) Now detail on mmap()

[openib-general] [PATCH/RFC 2.6.21 1/5] ehca: declaration of queue structures

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland and Christoph H.! This is a patch for ehca structs. It enhances completion queue and queue pair with use counters for associated mmap-ed resources, ie. hardware register block and queue pages. Furthermore it removes redundant prototypes. Thanks Nam Signed-off-by Hoang-Nam Nguyen

[openib-general] [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland and Christoph H.! This is a patch for ehca_cq.c. It removes all direct calls of do_mmap()/munmap() when creating and destroying a completion queue respectively. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c | 65

[openib-general] [PATCH/RFC 2.6.21 4/5] ehca: queue pair: remove use of do_mmap()

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland and Christoph H.! This is a patch for ehca_qp.c. It removes all direct calls of do_mmap()/munmap() when creating and destroying a queue pair respectively. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_qp.c | 78

[openib-general] [PATCH/RFC 2.6.21 5/5] ehca: ehca_main.c: version numbering

2007-01-11 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca_main.c. It mainly updates ehca version appropriately. Also the abi_version is increased in order to distinguish this from earlier releases. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_main.c |6 +++--- 1 files changed, 3

Re: [openib-general] [openfabrics-ewg] Reminder: OFED 1.2 coordination meeting next Monday at 9am PST

2007-01-12 Thread Hoang-Nam Nguyen
Hello Tziporet and others from ofed board! I wish to know if and how ehca could transition from preview tech to production state for ofed 1.2, especially what do we need to accomplish in order to achieve that. If you could point me to a written procedure for that, it would be great. Thanks! Nam

Re: [openib-general] [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-12 Thread Hoang-Nam Nguyen
() in ehca_irq.c. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - ehca_irq.c |4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_cq.c infiniband_work/drivers/infiniband/hw/ehca/ehca_cq.c

Re: [openib-general] [PATCH/RFC 2.6.21 3/5] ehca: completion queue: remove use of do_mmap()

2007-01-12 Thread Hoang-Nam Nguyen
Hi, + if (my_cq-ownpid != cur_pid) { + ehca_err(device, Invalid caller pid=%x ownpid=%x +cq_num=%x, +cur_pid, my_cq-ownpid, my_cq-cq_number); + return -EINVAL; + } (for

[openib-general] [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

2007-01-17 Thread Hoang-Nam Nguyen
. Thanks! Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_uverbs.c | 266 +++--- 1 file changed, 146 insertions(+), 120 deletions(-) diff -Nurp infiniband/drivers/infiniband/hw/ehca/ehca_uverbs.c infiniband_work/drivers

Re: [openib-general] [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

2007-01-18 Thread Hoang-Nam Nguyen
No problem. Will resend the full patch set for 2.6.21. Thanks Nam [EMAIL PROTECTED] wrote on 18.01.2007 13:56:01: I've kind of lost the plot here. How does this patch fit in with the previous series of patches you posted? Does it replace them or go on top of them? Can please you resend me

Re: [openib-general] [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

2007-01-19 Thread Hoang-Nam Nguyen
[EMAIL PROTECTED] wrote on 18.01.2007 16:26:58: qpnum is actually only required from poll cq if srq is supported. so ehca can just fill in NULL. actually the IB spec requires QPN in the work completion if either SRQ or base queue management extensions are supported. I'm not sure why

[openib-general] [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-19 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b

[openib-general] [PATCH 2.6.20 1/2] ehca: ehca_cq.c: fix unproper use of yield within spinlock context

2007-01-19 Thread Hoang-Nam Nguyen
Hello Roland! This is a patch for ehca_cq.c that fixes unproper use of yield within spinlock context. Thanks Nam Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehca_cq.c b

Re: [openib-general] [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-20 Thread Hoang-Nam Nguyen
hmm, code line too long. please ignore the previous patch. here is the one with correct length of code line. Thanks Nam This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Signed-off-by Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c |4 +++- 1

Re: [openib-general] [PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin_unlock in irq handler

2007-01-22 Thread Hoang-Nam Nguyen
I think the right thing to do is restructure this function so you don't have lines starting 6 tab stops to the right. Yes. Have reworked this irq handler and still struggling with testing. When we feel comfortable with the test result, we'll post it here (soon) and hopefully it is easier to

[openib-general] [PATCH 2.6.21 0/4] ehca: remove do_mmap() and some bug fixes

2007-01-23 Thread Hoang-Nam Nguyen
Hello Roland! Here is a patch set for ehca as a result of previous disscussions and comments: 1. fix improper use of yield within spinlock context 2. fix mismatched use of spin_unlock in irq handler 3. remove do_mmap() 4. remove obsolete prototypes PS: I've sent the first two recently for 2.6.20,

[openib-general] [PATCH 2.6.21 1/4] ehca: fix improper use of yield with spinlock held

2007-01-23 Thread Hoang-Nam Nguyen
Here is a patch for ehca_cq.c that fixes improper use of yield with spinlock held. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_cq.c

[openib-general] [PATCH 2.6.21 2/4] ehca: fix mismatched use of spin_unlock in irq handler

2007-01-23 Thread Hoang-Nam Nguyen
Here is a patch for ehca_irq.c that fixes mismatched use of spin_unlock in irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff -Nurp infiniband_orig/drivers/infiniband/hw/ehca/ehca_irq.c

[openib-general] [PATCH 2.6.21 3/4] ehca: remove do_mmap()

2007-01-23 Thread Hoang-Nam Nguyen
-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 15 +- ehca_cq.c | 65 ++--- ehca_iverbs.h |8 - ehca_main.c|6 ehca_qp.c | 78 ++- ehca_uverbs.c | 395 +++-- 6 files changed, 204 insertions(+), 363

Re: [openib-general] [openfabrics-ewg] modules compilation status for OFED 1.2

2007-01-24 Thread Hoang-Nam Nguyen
Hi Tziporet! ehca driver (Nam) - SLES9, Redhat EL4 up4, SLES10 SP1, 2.6.19 Backport for SLES9 and RHEL4.4/5 is doable only with a kernel patch in order to get ibmebus running, which is a prereq for ehca. Since ofed-1.1 build process compiles the components out of kernel tree, such one kernel

Re: [openib-general] [openfabrics-ewg] modules compilation status for OFED 1.2

2007-01-24 Thread Hoang-Nam Nguyen
Hi, We stay with same build process but the backport patches give a solution for such cases. Michael Tsirkin can help you how we solved such problems with other kernel code we needed. I need to be more specific here: ibmebus requires two symbols in arch/ppc64/kernel/dma.c to be exported, which

[openib-general] [PATCH ofed-1.2 0/6] ehca (kernel space) patches for ofed-1.2

2007-01-26 Thread Hoang-Nam Nguyen
Hello Vladimir! Here is a patch set for ehca device driver with the following changes: * Fix yield with spinlock held (this has been queued for 2.6.20) * Fix mismatched unlock in irq handler (this has been queued for 2.6.20) * Remove mmap (this has been queued for 2.6.21) * Remove obsolete

[openib-general] [PATCH ofed-1.2 1/6] ehca: fix yield with spinlock held and mismatched unlock

2007-01-26 Thread Hoang-Nam Nguyen
ehca_cq.c: fix yield with spinlock held ehca_irq.c: fix mismatched unlock Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_cq.c |5 - ehca_irq.c |3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff -Nurp ofed_1_2_jan26/drivers/infiniband/hw/ehca/ehca_cq.c

[openib-general] [PATCH ofed-1.2 2/6] ehca: remove do_mmap and obsolete prototypes

2007-01-26 Thread Hoang-Nam Nguyen
Remove do_mmap and obsolete prototypes Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 29 +--- ehca_cq.c | 65 ++--- ehca_iverbs.h | 10 - ehca_main.c|8 - ehca_qp.c | 78 ++- ehca_uverbs.c | 395

[openib-general] [PATCH ofed-1.2 3/6] ehca: backport 2.6.16

2007-01-26 Thread Hoang-Nam Nguyen
backport hvcall for 2.6.16 Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- hvcall.h | 142 +++ 1 files changed, 142 insertions(+) diff -Nurp ofed_1_2_jan26/kernel_addons/backport/2.6.16/include/asm/hvcall.h ofed_1_2_nam

[openib-general] [PATCH ofed-1.2 4/6] ehca: backport sles10

2007-01-26 Thread Hoang-Nam Nguyen
backport hvcall for sles10 Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- hvcall.h | 142 +++ 1 files changed, 142 insertions(+) diff -Nurp ofed_1_2_jan26/kernel_addons/backport/2.6.16_sles10/include/asm/hvcall.h

[openib-general] [PATCH ofed-1.2 5/6] ehca: backport 2.6.18

2007-01-26 Thread Hoang-Nam Nguyen
backport hvcall for 2.6.18 Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- hvcall.h | 32 1 files changed, 32 insertions(+) diff -Nurp ofed_1_2_jan26/kernel_addons/backport/2.6.18/include/asm/hvcall.h ofed_1_2_nam/kernel_addons/backport/2.6.18

Re: [openib-general] [openfabrics-ewg] modules compilation status for OFED 1.2

2007-01-27 Thread Hoang-Nam Nguyen
Hi Michael! I need to be more specific here: ibmebus requires two symbols in arch/ppc64/kernel/dma.c to be exported, which means one really needs to rebuild and install the patched kernel. As far as I understood from Michael, when we looked at ofed-1.1, that approach is not supported by

Re: [openib-general] [Patch ofed1.2 0/3]libehca: cleanup and adjust mmap

2007-01-28 Thread Hoang-Nam Nguyen
This 3 patches changes the libehca coding style to kernel coding and kernel tracing style.The userspace mmap code needs to be adjusted to the changed userspace mapping introduced in kernel patch [PATCH/RFC 2.6.21 0/5] ehca: remove use of do_mmap() from kernel space. Note that ofed 1.2 has

Re: [openib-general] OFED 1.2 release - to be reviewed in the meeting today

2007-01-29 Thread Hoang-Nam Nguyen
Hi, This looks pretty similar to ofed-1.1/SVN release procedure. What about discussed idea of per package release by maintainers? I guess there's no conflict: maintainers can make ofed_1_2 point to their release. But I agree we need maintainers' buy-in and commitment to schedule that

Re: [openib-general] [openfabrics-ewg] [PATCH ofed-1.2 0/6] ehca (kernel space) patches for ofed-1.2

2007-01-29 Thread Hoang-Nam Nguyen
[EMAIL PROTECTED] wrote on 27.01.2007 17:11:34: PS2: For backport on 2.6.16 resp. SLES10 I saw that there is a hvcall.h under backport/2.6.16/include/linux. However that one is not sufficient for ehca and include/linux is the wrong place. Hence, I'm patching a new one under include/asm. If

Re: [openib-general] [openfabrics-ewg] [PATCH ofed1.2 2/2] libehca: change path to ehca.driver for make dist

2007-01-29 Thread Hoang-Nam Nguyen
applied both patches ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] [openfabrics-ewg] [PATCH ofed-1.2 0/6] ehca (kernel space) patches for ofed-1.2

2007-01-30 Thread Hoang-Nam Nguyen
Can someone from iser group please check this? On pseries hvcall.h is placed under include/asm which is a link to include/asm-ppc resp include/asm-powerpc. I don't think that we did anything with this in iSER. Erez Erez, thanks for this info. Vladimir, please remove include/linux/hvcall.h

[openib-general] [PATCH ofed-1.2 alpha rel] ehca: reworked irq handler to support NAPI consistently

2007-01-30 Thread Hoang-Nam Nguyen
: Roland, this patch is aligned with ofed-1.2 only. I'l send this patch for 2.6.21 separately next week. Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 18 +++-- ehca_eq.c |1 ehca_irq.c | 202

Re: [openib-general] [openfabrics-ewg] Minutes for January 29, 2007 teleconference about OFED 1.2 release integration and build procedures

2007-01-31 Thread Hoang-Nam Nguyen
Hi, 3. Each git maintainer: open ofed_1_2 branch till Feb 1. created branch ofed_1_2 for libehca. Regards Nam ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit

Re: [openib-general] RFC ofed 1 2 kernel file structure

2007-02-07 Thread Hoang-Nam Nguyen
I could clone it: Should be I could not clone it ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] RFC ofed 1 2 kernel file structure

2007-02-07 Thread Hoang-Nam Nguyen
Hi Michael, Repost. Could everyone please look at git://git.openfabrics.org/~mst/newofed.git and tell me whether this looks acceptable? I could clone it: $git clone git://git.openfabrics.org/~mst/newofed.git fatal: Unable to look up git.openfabrics.org (Temporary failure in name resolution)

Re: [openib-general] [PATCH ofed-1.2] libehca: fix build error with disable-libcheck option

2007-02-08 Thread Hoang-Nam Nguyen
This patch fix libehca build errors if disable-libcheck option is choosen. Applied ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit

[openib-general] [PATCH 2.6.21-rc1 0/5] ehca patch set for 2.6.21-rc1

2007-02-14 Thread Hoang-Nam Nguyen
Hello Roland! Here is a patch set for ehca with the following changes resp. bug fixes: * Reworked irq handler to avoid/reduce missed irq events * Fix race condition bug in find_next_online_cpu() and other potential locking issue of scaling code * Allow scaling code to be configurable

[openib-general] [PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca with the reworked irq handler. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 18 +++-- ehca_eq.c |1 ehca_irq.c | 200 - ehca_irq.h |1

[openib-general] [PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch fixes a race condition in find_next_cpu_online() and some other locking issues in scaling code. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c | 68 + 1 files changed, 33 insertions

[openib-general] [PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

2007-02-14 Thread Hoang-Nam Nguyen
Hi, here is a patch for ehca that allows users to en/disable scaling code when loading ib_ehca module. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c | 47

[openib-general] [PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion()

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch removes yield() and uses wait_for_completion() in order to wait for running completion handlers finished before destroying associated completion queue. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h |3 +++ ehca_cq.c |3

[openib-general] [PATCH 2.6.21-rc1 5/5] ehca: query_port() returns LINK_UP instead UNKNOWN

2007-02-14 Thread Hoang-Nam Nguyen
Hi, this patch sets port phys state as a result of ehca_query_port() to LINK_UP. On pSeries ehca actually represents a logical HCA, whose phys/link state always is LINK_UP. Thanks Nam Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_hca.c |3 +++ 1 files changed, 3 insertions

Re: [openib-general] 32-bit build for ppc64 is required

2007-02-14 Thread Hoang-Nam Nguyen
Hi, Well, this is not by design: AFAIK on x86_64 both types of libraries are installed. So, it seems to be an issue with the build script. Will talk to Vlad. But I still do not see how installing 32 bit binaries alongside the 64 bit ones is useful, and I do not think other packages provide

Re: [openib-general] 32-bit build for ppc64 is required

2007-02-14 Thread Hoang-Nam Nguyen
Hi Vlad, prefix/lib (32bit libraries) should be created on ppc64 as well. Check that you have sysfsutils 32bit RPM installed. I don't have ppc64 here to check. The current ofed-1.2 package does not, while ofed-1.1.1 has done. It looks like that the one fix we did for ofed-1.1.1 were away. If I

Re: [openib-general] 32-bit build for ppc64 is required

2007-02-14 Thread Hoang-Nam Nguyen
Hi, Still, using non-standard hacks like bin32 does not sound like a good idea. I think the actual issue is there is no common approach for this on various platforms. Maybe an option to *only* make 32 bit userspace might make sense though. Something like --disable-32bit, --disable-64bit. This

Re: [openib-general] 32-bit build for ppc64 is required

2007-02-14 Thread Hoang-Nam Nguyen
So, what you suggest is - build 2 types of libraries, but on PPC make binaries 32 bit? That's easy - do others agree to this approach? No, for execs please create 32bit and 64bit on PPC. Another option is to build binaries with whatever type of binary gcc without extra flags generates by

Re: [openib-general] 32-bit build for ppc64 is required

2007-02-15 Thread Hoang-Nam Nguyen
And the customers can pick the one(s) they like. I see your point regarding QA effort. Is it really twice? Probably more - I'm reasonably sure most scripts written so far assume stuff is installed in prefix/bin, so testing harness etc would need to be changed. And how to make sure the

Re: [openib-general] [PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-15 Thread Hoang-Nam Nguyen
Looks fine but this patch at least has serious whitespace damage... please resend a fixed version. Sorry for this. Resending the patches 1-5. Nam ___ openib-general mailing list openib-general@openib.org

[openib-general] [PATCH 2.6.21-rc1 1/5] ehca: reworked irq handler to avoid/reduce missed irq events

2007-02-15 Thread Hoang-Nam Nguyen
reworked irq handler to avoid/reduce missed irq events Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_classes.h | 18 +++- ehca_eq.c |1 ehca_irq.c | 214 +++-- ehca_irq.h |1 ehca_main.c| 28

[openib-general] [PATCH 2.6.21-rc1 2/5] ehca: fix race condition/locking issues in scaling code

2007-02-15 Thread Hoang-Nam Nguyen
fix a race condition in find_next_cpu_online() and some other locking issues in scaling code Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- ehca_irq.c | 68 + 1 files changed, 33 insertions(+), 35 deletions(-) diff --git

[openib-general] [PATCH 2.6.21-rc1 3/5] ehca: allow en/disabling scaling code via module parameter

2007-02-15 Thread Hoang-Nam Nguyen
allow users to en/disable scaling code when loading ib_ehca module Signed-off-by: Hoang-Nam Nguyen [EMAIL PROTECTED] --- Kconfig|8 ehca_classes.h |1 + ehca_irq.c | 47 +-- ehca_main.c|4 4 files changed

  1   2   >