Re: [Review request] Make Cell.updateItem(item, empty) public, rather than protected

2013-07-09 Thread Tom Schindl
Hi, I must not (although most of the code out there which specialized Cell kept it protected and hence is broken) and all I did was to point out that this is and will be a breaking changeing. Whether this justifies breaking code is up to the openjfx team, simply saying it does not break

Re: [Review request] Make Cell.updateItem(item, empty) public, rather than protected

2013-07-09 Thread Tom Schindl
Whether this justifies breaking code is up to the openjfx team, simply saying it does not break compatibility to get some API approved is not the way to go. I don't want to imply that Jonathan did this! I know it was an oversight. Tom

Re: [API Review]: Add 'fxml.version' to System Properties (Was: FXML version number)

2013-07-09 Thread Danno Ferrin
I think mixing FXML versions in one FXML document is a bad idea, so my proposal of a version attribute would only show at the root of the document applying to all elements of that document, seeing the fx:version attribute anywhere else should be considered a strict validation error, so the

Re: Validate cell, or request a cell update

2013-07-09 Thread Richard Bair
I think this is different. The idea was that you would bind state on the cell to the item it is representing, so that it is automatically updated when needed and then there is no need to manually poke it. If the data item isn't observable, then you need a way to manually poke it. Richard On

Re: Validate cell, or request a cell update

2013-07-09 Thread Werner Lehmann
Ok - this means that in Cell.updateItem I would have to add a (weak?) listener to the item's state property. If the cell is reused for another item I would have to remove the old listener first. My only concern is that this will be done a lot when scrolling through the list. Thanks... If the

Re: [API Review]: Node validation

2013-07-09 Thread David Grieve
Since there is already a requestLayout() which defers to the next pulse, what about demandLayout()? Or why can't getBoundsInParent() or getBoundsInLocal() do this? Even with this function, there is still the problem where the dimensions of a node won't be right if called before the node is

Re: [API Review]: Node validation

2013-07-09 Thread Tom Schindl
On 09.07.13 22:59, David Grieve wrote: Since there is already a requestLayout() which defers to the next pulse, what about demandLayout()? then I would go for forceLayout() Tom

CFV: New OpenJFX Committer: Danno Ferrin

2013-07-09 Thread Richard Bair
I hereby nominate Danno Ferrin to OpenJFX Committer. Danno has been actively submitting patches and following up to make sure they get integrated for the past 8 months or so (the first patch I found was on this issue: https://javafx-jira.kenai.com/browse/RT-26719). He has maintained a

CFV: New OpenJFX Committer: Debra Masada

2013-07-09 Thread Richard Bair
I hereby nominate Debbie Masada to OpenJFX Committer. Debbie is a member of the samples team and works on Ensemble and other sample applications, adding functionality etc. as necessary. Some of her recent changes can be seen here. http://hg.openjdk.java.net/openjfx/8/master/rt/log?rev=masada

CFV: New OpenJFX Committer: Alexander Kouznetsov

2013-07-09 Thread Richard Bair
I hereby nominate Alexander Kouznetsov to OpenJFX Committer. Alex is a member of the samples team, but also contributes to the core platform itself and to J1 demos. His recent work can be seen here: http://hg.openjdk.java.net/openjfx/8/master/rt/log?rev=kouznetsov Votes are due by Jul 23,

CFV: New OpenJFX Committer: Oleg Mazurov

2013-07-09 Thread Richard Bair
I hereby nominate Oleg Mazurov to OpenJFX Committer. Oleg has been a key behind-the-scenes contributor to JavaFX performance. Some of his contributions can be counted in code http://hg.openjdk.java.net/openjfx/8/master/rt/log?rev=mazurov But much more in terms of performance profiling and

Re: CFV: New OpenJFX Committer: Danno Ferrin

2013-07-09 Thread David Hill
On 7/9/13 Jul 9, 6:03 PM, Richard Bair wrote: I hereby nominate Danno Ferrin to OpenJFX Committer. vote: yes Danno has been actively submitting patches and following up to make sure they get integrated for the past 8 months or so (the first patch I found was on this issue:

Re: CFV: New OpenJFX Committer: Debra Masada

2013-07-09 Thread David Hill
On 7/9/13 Jul 9, 6:07 PM, Richard Bair wrote: I hereby nominate Debbie Masada to OpenJFX Committer. vote: yes Debbie is a member of the samples team and works on Ensemble and other sample applications, adding functionality etc. as necessary. Some of her recent changes can be seen here.

Re: CFV: New OpenJFX Committer: Alexander Kouznetsov

2013-07-09 Thread David Hill
On 7/9/13 Jul 9, 6:09 PM, Richard Bair wrote: I hereby nominate Alexander Kouznetsov to OpenJFX Committer. vote: yes Alex is a member of the samples team, but also contributes to the core platform itself and to J1 demos. His recent work can be seen here:

Re: CFV: New OpenJFX Committer: Alexander Kouznetsov

2013-07-09 Thread Paru Somashekar
vote: yes -Paru. On 7/9/13 3:09 PM, Richard Bair wrote: I hereby nominate Alexander Kouznetsov to OpenJFX Committer. Alex is a member of the samples team, but also contributes to the core platform itself and to J1 demos. His recent work can be seen here:

Re: CFV: New OpenJFX Committer: Debra Masada

2013-07-09 Thread Paru Somashekar
vote: yes -Paru. On 7/9/13 3:07 PM, Richard Bair wrote: I hereby nominate Debbie Masada to OpenJFX Committer. Debbie is a member of the samples team and works on Ensemble and other sample applications, adding functionality etc. as necessary. Some of her recent changes can be seen here.

hg: openjfx/8/controls/rt: 5 new changesets

2013-07-09 Thread hang . vo
Changeset: 53ab58d87489 Author:jgiles Date: 2013-07-10 10:14 +1200 URL: http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/53ab58d87489 RT-30593: TableView.TableViewSelectionModel changes in Lombard are not back compatible with previous versions !