Review request:

2013-11-18 Thread Daniel Blaukopf
Hi Assaf and Dave, Would you review a fix for the ChalkBoard Electronics 7” touch screen? https://javafx-jira.kenai.com/browse/RT-34338 The patch is in the JIRA comments. Thanks, Daniel

H/V resize cursors in a JFXPanel

2013-11-18 Thread Werner Lehmann
Hi, still on FX2 I am plagued with a bug that prevents getting h-resize (split) cursor in a JFXPanel. This is a known and acknowledged issue, see [#RT-26235] SplitPane in JFXPanel: Mouse cursor not changed I have looked some more into this and noticed that this really seems to affect the

hg: openjfx/8/graphics/rt: RT-34340 x86egl build broken

2013-11-18 Thread hang . vo
Changeset: 8eb44bb11764 Author:Daniel Blaukopf daniel.blauk...@oracle.com Date: 2013-11-18 14:31 +0200 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/8eb44bb11764 RT-34340 x86egl build broken ! buildSrc/x86egl.gradle

Use of plugins in WebView

2013-11-18 Thread Philipp Dörfler
How impossible would be the use of plugins such as the Adobe Acrobat Reader or the Mac OS X embedded PDF preview in Safari for WebView? Does the embedded WebKit engine include an implementation of that plugin API or has that been omitted? Also: How hard would it be to embed the respective

Re: discussion about touch events

2013-11-18 Thread Assaf Yavnai
I have a question, Would it be possible to search only the nodes that have been registered for touch events notifications instead of the entire tree? (if it's not already been done) Of course if one choose to register the root node as the listener, we will have to go all over the nodes, but

Re: Two Level Focus

2013-11-18 Thread mick.fleming
Hi John, However, if you do click on it with the mouse (by selecting one of its items), focus is stuck there and cannot be moved anymore with just the 5 buttons. when you click on a two_level control with a mouse it goes straight into 'internal mode', as at this stage it's obvious that

Re: Use of plugins in WebView

2013-11-18 Thread Peter Zhelezniakov
How impossible would be the use of plugins such as the Adobe Acrobat Reader or the Mac OS X embedded PDF preview in Safari for WebView? Does the embedded WebKit engine include an implementation of that plugin API or has that been omitted? It has been omitted. The hardest part is to funnel all

Re: Use of plugins in WebView

2013-11-18 Thread Philipp Dörfler
And especially a HWND is what I’m looking for. So I guess anything requiring a HWND is just not usable within an JFX App at all? :/ Am 18.11.2013 um 15:01 schrieb Peter Zhelezniakov peter.zheleznia...@oracle.com: How impossible would be the use of plugins such as the Adobe Acrobat Reader or

Re: Review request for RT-34236 FXMLLoader throws java.lang.InternalError: CallerSensitive annotation expected at frame 1

2013-11-18 Thread Mark Howe
This is a slightly dialed back version. Basically the same thing as the first webrev except left the API for setEmbeddedLauncher, because that is used by some app.s Kevin and David please review http://cr.openjdk.java.net/~kcr/RT-34236.1/ On Nov 14, 2013, at 7:08 PM, Mark Howe

Re: Review request for RT-34236 FXMLLoader throws java.lang.InternalError: CallerSensitive annotation expected at frame 1

2013-11-18 Thread David DeHaven
Looks fine to me. -DrD- Thanks Mark. Can you please add this information to the JIRA (including the link to the new webrev) ? -- Kevin Mark Howe wrote: This is a slightly dialed back version. Basically the same thing as the first webrev except left the API for setEmbeddedLauncher,

Re: Review request for RT-34236 FXMLLoader throws java.lang.InternalError: CallerSensitive annotation expected at frame 1

2013-11-18 Thread Kevin Rushforth
Please add that to the JIRA, then. For FX, all discussion should happen there. See https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews -- Kevin David DeHaven wrote: Looks fine to me. -DrD- Thanks Mark. Can you please add this information to the JIRA (including the link to the

hg: openjfx/8/graphics/rt: RT-34249: [WebView] HTMLEditor broken in Spanish (es) locale.

2013-11-18 Thread hang . vo
Changeset: be4d63bf55bb Author:leifs Date: 2013-11-18 11:00 -0800 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/be4d63bf55bb RT-34249: [WebView] HTMLEditor broken in Spanish (es) locale. ! modules/web/src/main/java/com/sun/javafx/scene/web/skin/HTMLEditorSkin.java

Re: H/V resize cursors in a JFXPanel

2013-11-18 Thread Stephen F Northover
Hi Werner, This is all great information. If you can prove that RT-26235 is a dup or related to RT32507, please indicate in the bug reports. Also note the inconsistency. Please add me to the watchers list if not already there. Thanks, Steve On 2013-11-18 7:38 AM, Werner Lehmann wrote:

hg: openjfx/8/graphics/rt: 8 new changesets

2013-11-18 Thread hang . vo
Changeset: ac4d9e43d517 Author:Felipe Heidrich felipe.heidr...@oracle.com Date: 2013-11-18 11:21 -0800 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/ac4d9e43d517 RT-34346: TextAlignment center ceased to work !

hg: openjfx/8/graphics/rt: RT-34338 Chalkboard Electronics touch screen declared as ID_INPUT_TABLET is not recognised

2013-11-18 Thread hang . vo
Changeset: 68e5bc52a094 Author:Daniel Blaukopf daniel.blauk...@oracle.com Date: 2013-11-18 21:03 +0200 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/68e5bc52a094 RT-34338 Chalkboard Electronics touch screen declared as ID_INPUT_TABLET is not recognised Reviewed-by:

hg: openjfx/8/graphics/rt: RT-34158: NPE when pressing both mouse keys in FXCanvas

2013-11-18 Thread hang . vo
Changeset: 2650ad7e53bf Author:snorthov Date: 2013-11-18 16:24 -0500 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/2650ad7e53bf RT-34158: NPE when pressing both mouse keys in FXCanvas Summary: The fix was to stop check both the button and the event mask Reviewed-by:

review RT-31517: Scenegraph: bug in SVGPath fill with LinearGradient

2013-11-18 Thread Felipe Heidrich
Hi all, During the review the scope of RT-31517 has grown to possibly affect all fill and stroke operations executed by prism (when gradients are used). See https://javafx-jira.kenai.com/browse/RT-31517 for details and let us know of your opinion. Thanks Felipe

Show case: JFX on iOS and Android

2013-11-18 Thread Tobias Bley
For all who do not follow me on twitter: a few screenshots concerning JFX on iOS and Android: http://blog.software4java.com/?p=148#comment-4629 Best regards, Tobi -- Tobias Bley Chief Executive Officer Tel +49 351 - 264 49 86

Re: Show case: JFX on iOS and Android

2013-11-18 Thread David Ray
Awesome work Tobias! :) On Nov 18, 2013, at 4:02 PM, Tobias Bley t...@ultramixer.com wrote: For all who do not follow me on twitter: a few screenshots concerning JFX on iOS and Android: http://blog.software4java.com/?p=148#comment-4629 Best regards, Tobi -- Tobias Bley Chief

Code Review Request For RT-34226: Shading of PhongMaterial Boxes appears unnatural

2013-11-18 Thread Chien Yang
Kevin and Jim, Please review this simple fix. I have also included the report test case this change: JIRA: https://javafx-jira.kenai.com/browse/RT-34226 Webrev: http://cr.openjdk.java.net/~ckyang/RT-34226/webrev.00/ Thanks, - Chien

RE: Show case: JFX on iOS and Android

2013-11-18 Thread Pedro Duque Vieira
Hi Tobias, What's the performance, bugs/crashes in your apps? Did you advance anything in regards to what the community as already done. If so are you going to contribute back to the community effort? Thanks, best regards, -- Pedro Duque Vieira

hg: openjfx/8/graphics/rt: Fix to RT-34226: Shading of PhongMaterial Boxes appears unnatural

2013-11-18 Thread hang . vo
Changeset: 267dbc0bb8a4 Author:Chien Yang chien.y...@oracle.com Date: 2013-11-18 15:48 -0800 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/267dbc0bb8a4 Fix to RT-34226: Shading of PhongMaterial Boxes appears unnatural Reviewed-by: kcr +

Re: Proportional paint object behavior inconsistent and needs to change

2013-11-18 Thread Scott Palmer
I would lean towards using the stroke bounds for both. Those being the real bounds, and resulting in less mis-aligned gradients. Always calculate the stroke bounds as if the shape will be stroked, so it doesn't affect Canvas. If you don't want that to affect the bounds used for a gradient fill

Re: Proportional paint object behavior inconsistent and needs to change

2013-11-18 Thread Jim Graham
Hi Scott, That's an odd take on it. It wouldn't be readily obvious to a developer why their background rectangle had the gradient a little off if they never planned to ever stroke it. Also, keep in mind that while it might be slightly more expensive to calculate tight bounds than loose

Re: Use of plugins in WebView

2013-11-18 Thread Peter Zhelezniakov
On 11/18/2013 06:20 PM, Philipp Dörfler wrote: And especially a HWND is what I’m looking for. So I guess anything requiring a HWND is just not usable within an JFX App at all? :/ I'm not a Glass expert, but I'd expect such platform-specific data to be well hidden from a JavaFX developer.

Re: Proportional paint object behavior inconsistent and needs to change

2013-11-18 Thread Kevin Rushforth
I haven't thought through all of the implications, but my initial take is the same as Jim's. Namely, that using the fill bounds for proportional paints is the most consistent and will have the least degree of unpleasant surprises. -- Kevin Jim Graham wrote: Felipe mentioned recently that we

Re: Proportional paint object behavior inconsistent and needs to change

2013-11-18 Thread Scott Palmer
It wasn't clear from your original message that the stroke bounds were much more expensive. Given that additional info I don't think my idea is practical. That makes it harder to decide. I like your choice of fill bounds to ease the ability to align the gradients, but I don't like the idea of

hg: openjfx/8/graphics/rt: 3 new changesets

2013-11-18 Thread hang . vo
Changeset: 06e92c423984 Author:hudson Date: 2013-11-14 08:07 -0800 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/06e92c423984 Added tag 8.0-b116 for changeset 5faf1a0ea511 ! .hgtags Changeset: dae901206261 Author:mv157916 Date: 2013-11-14 10:49 -0800 URL:

Re: Proportional paint object behavior inconsistent and needs to change

2013-11-18 Thread Jasper Potts
I agree with Scott, it seems bad if gradient doesn't match stroke bounds when applied to stroke. Jasper On Nov 18, 2013, at 9:36 PM, Scott Palmer swpal...@gmail.com wrote: It wasn't clear from your original message that the stroke bounds were much more expensive. Given that additional