Re: Running Web-Tests from eclipse

This looks good to me. Thanks, Robert Am Mi., 15. Jan. 2020 um 07:15 Uhr schrieb Nir Lisker : > I updated the eclipse instructions. Have a look. > > Thanks, > Nir > > On Tue, Jan 14, 2020 at 1:01 PM Robert Lichtenberger < > r.lichtenber...@gmail.com> wrote: > >> As a follow-up to the long

Re: Running Web-Tests from eclipse

I updated the eclipse instructions. Have a look. Thanks, Nir On Tue, Jan 14, 2020 at 1:01 PM Robert Lichtenberger < r.lichtenber...@gmail.com> wrote: > As a follow-up to the long thread on using an IDE. I just found out that > running test.javafx.scene.web.WebViewTest is not possible with >

Re: RFR: 8236753: Animations do not play backwards after being stopped

> On Jan 14, 2020, at 11:50 AM, Ambarish Rapte wrote: > > On Fri, 10 Jan 2020 00:39:53 GMT, Kevin Rushforth wrote: > >>> I'll review this next week. This seems a fine candidate for openjfx14, so >>> it (along with a couple other pending reviews that can be for 14) will be a >>> good test

Re: RFR: Request to backport patches into JFX-11

Approved. -- Kevin On 1/14/2020 9:46 AM, Johan Vos wrote: Hi Kevin, I ask permission to backport the following issues into 11-dev: JDK-8231590 : Update location of jfx repo to GitHub in third-party legal files JDK-8231854

RFR: Request to backport patches into JFX-11

Hi Kevin, I ask permission to backport the following issues into 11-dev: JDK-8231590 : Update location of jfx repo to GitHub in third-party legal files JDK-8231854 : Change Mercurial to git in

Re: [11][13] RFR: Request to backport October 2019 CPU changes

Approved. On Tue, Jan 14, 2020, 18:04 Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the changes from the just-released > January 2020 CPU to 11-dev and 13-dev. > > https://cr.openjdk.java.net/~kcr/cpu-2001-sync/11-dev/webrev/ > > This is a straight backport (patch

Re: [14] RFR: Request to sync January 2020 CPU changes into jfx [jfx14 branch]

Approved. On Tue, Jan 14, 2020, 18:03 Kevin Rushforth wrote: > Johan and Phil, > > I request approval to sync changes from to the just-released January > 2020 CPU release into the 'jfx14' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: > >

[11][13] RFR: Request to backport October 2019 CPU changes

Hi Johan, I request approval to backport the changes from the just-released January 2020 CPU to 11-dev and 13-dev. https://cr.openjdk.java.net/~kcr/cpu-2001-sync/11-dev/webrev/ This is a straight backport (patch applies cleanly) of the four FX fixes that went into the January CPU. The

[14] RFR: Request to sync January 2020 CPU changes into jfx [jfx14 branch]

Johan and Phil, I request approval to sync changes from to the just-released January 2020 CPU release into the 'jfx14' branch of the 'jfx' repo. Here is the aggregate set of changes for the fixes: https://github.com/kevinrushforth/jfx/compare/f907026...16cea41 The aggregate diffs are empty,

Re: RFR: 8236753: Animations do not play backwards after being stopped

On Fri, 10 Jan 2020 00:39:53 GMT, Kevin Rushforth wrote: >> I'll review this next week. This seems a fine candidate for openjfx14, so it >> (along with a couple other pending reviews that can be for 14) will be a >> good test of targeting a PR to the stabilization branch. >> >> I also request

Backport 8224636 to OpenJFX 11

Hi Kevin, I request permission to backport JDK-8224636 to OpenJFX 11 (11-dev). The patch applies clean. - Johan

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

On Tue, 14 Jan 2020 14:55:31 GMT, Robert Lichtenberger wrote: >> Oh, I see the problem. In addition to rebasing you need to exclude any >> commits that are from the `master` branch and are not your. So what you >> really need to do is: >> >> git rebase -i upstream/jfx14 >> >> git push

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

On Tue, 14 Jan 2020 14:43:03 GMT, Kevin Rushforth wrote: >> Partially reviewed, Need to re-check after the change of branch. > > Oh, I see the problem. In addition to rebasing you need to exclude any > commits that are from the `master` branch and are not your. So what you > really need to do

Re: [Rev 03] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

> As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews > and a fix

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

On Tue, 14 Jan 2020 14:13:45 GMT, Guru Hb wrote: >> The pull request has been updated with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. > > Partially reviewed, Need to re-check after the change of

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

On Tue, 14 Jan 2020 14:00:08 GMT, Kevin Rushforth wrote: >> I've rebased my branch like this: >> git fetch upstream >> git rebase upstream/jfx14 >> git pull >> git push >> and changed the base branch of this PR to jfx14. Hope that was the correct >> way to do this ;-). > > Your branch still

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

On Tue, 14 Jan 2020 14:13:54 GMT, Robert Lichtenberger wrote: >> As documented in JDK-8236912, WebView did not check whether the idMap really >> contained a mapping for the given button, making it prone to errors, when >> things are extended (as has happened here). >> >> The fix consists of

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

> As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews > and a fix

Re: [Rev 02] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

On Tue, 14 Jan 2020 12:56:32 GMT, Robert Lichtenberger wrote: >> NOTE that this PR is not yet ready for integration. In addition to needing >> one more reviewer (me), there is the open question of which branch it should >> be targeted to. >> >> @effad I think that this should go into

Re: [Rev 01] RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

> As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two test cases that show the problem in unfixed WebViews > and a fix

Re: RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

On Tue, 14 Jan 2020 12:16:14 GMT, Kevin Rushforth wrote: >> +1, Looks good to me. > > @effad - The extra commits and merge are no problem, provided that you want > to get this into openjfx15. > > However, if you intend to get this into openjfx14, as currently targeted in > JBS, then you will

Re: RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

On Tue, 14 Jan 2020 12:12:37 GMT, Guru Hb wrote: >> As documented in JDK-8236912, WebView did not check whether the idMap really >> contained a mapping for the given button, making it prone to errors, when >> things are extended (as has happened here). >> >> The fix consists of two test cases

Re: RFR: 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5

On Tue, 14 Jan 2020 12:01:11 GMT, Robert Lichtenberger wrote: > As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two

Re: RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

How strange: Other commits to the master branch of my forked repository (relating to another issue, already integrated into OpenJFX) are also showing up here. But the change really only consists of 542ff60e which contains the fix for JDK-8236912. My older contributions were not checked into a

Re: RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

On Tue, 14 Jan 2020 12:01:11 GMT, Robert Lichtenberger wrote: > As documented in JDK-8236912, WebView did not check whether the idMap really > contained a mapping for the given button, making it prone to errors, when > things are extended (as has happened here). > > The fix consists of two

RFR: 8236912: Preventing NPE when clicking WebView with forward/back mouse buttons

As documented in JDK-8236912, WebView did not check whether the idMap really contained a mapping for the given button, making it prone to errors, when things are extended (as has happened here). The fix consists of two test cases that show the problem in unfixed WebViews and a fix which works

Re: Removing unneeded imports from testcode

As a general rule, we avoid unrelated fixes. If your fix needed to add any new import, then I don't mind removing unused ones at the same time. If not, then you can either leave it as-is or file a cleanup issue. -- Kevin For test fixes, I don't mind On 1/14/2020 3:40 AM, Robert

Removing unneeded imports from testcode

I'm in the process of preparing a fix for JDK-8236912 and I (or rather eclipse) have noticed that WebViewTest contains an import of java.util.concurrent.FutureTask that is not needed. What is the correct way of handling such things: * Including them into the Pull-Request for the fix of JDK-8236912

Re: RFR: WIP: 8236651: Simplify and update glass gtk backend

On Mon, 6 Jan 2020 22:57:31 GMT, Thiago Milczarek Sayao wrote: >> This sort of enhancement needs to be discussed on the openjfx-dev mailing >> list first. While the WIP PR might be used to illustrate what you have in >> mind to propose, it is premature to actually review the implementation

Running Web-Tests from eclipse

As a follow-up to the long thread on using an IDE. I just found out that running test.javafx.scene.web.WebViewTest is not possible with -Djavafx.toolkit=test.com.sun.javafx.pgstub.StubToolkit. The test simply fails to start (waiting forever for

Re: "Using an IDE" Page outdated

> > Did you end up reverting the .classpath and .project files? > I started over, not importing as gradle but as java projects. I also just found https://openjfx-dev.openjdk.java.narkive.com/AVCV7WXg/problem-running-tests-in-module-controls-inside-eclipse and with Tom's hint: > i run them with

Re: "Using an IDE" Page outdated

> > The blank final field dialog may not have been initialized Dialog.java This is mentioned in the note under "Configure Eclipse to use the latest JDK". Did you end up reverting the .classpath and .project files? On Tue, Jan 14, 2020 at 10:37 AM Robert Lichtenberger <

Re: "Using an IDE" Page outdated

I think the issue there is https://bugs.eclipse.org/bugs/show_bug.cgi?id=507629 as Nir commented there as well I'm fairly sure this is the one you see ;-) Tom On 14.01.20 09:47, Tom Schindl wrote: > On 14.01.20 09:36, Robert Lichtenberger wrote: >> I've just simply removed the two missing source

Re: "Using an IDE" Page outdated

On 14.01.20 09:36, Robert Lichtenberger wrote: > I've just simply removed the two missing source folders and only one > error remains: > * The blank final field dialog may not have been initialized Dialog.java > /controls/src/main/java/javafx/scene/control line 521 > which seems to me like an

Re: "Using an IDE" Page outdated

I've just simply removed the two missing source folders and only one error remains: * The blank final field dialog may not have been initialized Dialog.java /controls/src/main/java/javafx/scene/control line 521 which seems to me like an error within the eclipse compiler. Ignoring this error, I've

Re: "Using an IDE" Page outdated

Well those are created by the build not? I have to confess, that I did not setup Eclipse for OpenJFX-Development lately but I'm fairly certain those directories are generated by the build. Tom On 14.01.20 09:11, Robert Lichtenberger wrote: > I've tried to import using "General" -> "Existing

Re: "Using an IDE" Page outdated

I think your errors come from the note under "Using Gradle" in the Eclipse instructions. Gradle doesn't know how to create the correct Eclipse files, so it overrides the ones in the repo with its incorrect ones. Try to revert the changes to .project and .classpath files. You might still get a few

Re: "Using an IDE" Page outdated

I've tried to import using "General" -> "Existing Projects in Workspace" but get lots of errors as well. When reducing the imported projects to base, graphics and controls: * base is ok * graphics has these errors: Description Resource Path Location Type Project 'graphics' is missing required