Then I will take approach 1 for now.
Remind me again, which JBS bug you are planning to use to fix this issue?
https://bugs.openjdk.java.net/browse/JDK-8236858
On Wed, Jan 22, 2020 at 1:31 AM Kevin Rushforth
wrote:
> This got buried in my inbox, and I missed seeing it.
>
> I'll respond
On Tue, 21 Jan 2020 21:37:54 GMT, Alexander Matveev
wrote:
>> Fix JDK-8237078
>> replace the objc_msgSend call with a direct objC call.
>> The fix works on XCode 10.1 and XCode 11.3
>>
>> Tested using
>> java -Djfxmedia.platforms=OSXPlatform
>> with MediaPlayer playing an mp3.
>
> Looks
This got buried in my inbox, and I missed seeing it.
I'll respond inline.
On 1/10/2020 6:45 PM, Nir Lisker wrote:
I forgot to bring up https://bugs.openjdk.java.net/browse/JDK-8200206,
which is also relevant to this discussion. The solution to that one is
probably allowing only 1 parent,
On Mon, 20 Jan 2020 11:24:05 GMT, Frederic Thevenet
wrote:
>> Looks good to me.
>> Below is just an observation about time taken by the API,
>> Platform: Windows10, `maxTextureSize`: 4096
>> For a snapshot of (4096 * n, 4096 * n): each call to `doSnapshotTile()`
>> takes ~100 ms, and each
On Mon, 20 Jan 2020 11:10:07 GMT, Johan Vos wrote:
> Fix JDK-8237078
> replace the objc_msgSend call with a direct objC call.
> The fix works on XCode 10.1 and XCode 11.3
>
> Tested using
> java -Djfxmedia.platforms=OSXPlatform
> with MediaPlayer playing an mp3.
Looks good.
-
Hi,
I see where you are coming from but IMHO JavaFX should focus on being a
Graphic and UI-Toolkit and not leak any patterns into the core API.
These are just by 2 cents so other might have another opinion.
Tom
On 21.01.20 20:59, Michael Strauß wrote:
> 1. Abstract:
> Controls that are derived
1. Abstract:
Controls that are derived from ButtonBase generally represent an operation
that is triggered by the control.
In many cases, the control also reflects whether the operation can
currently be invoked (i.e. whether the control is enabled or disabled), or
whether the operation is currently
On Tue, 21 Jan 2020 19:57:56 GMT, Nir Lisker wrote:
>> The private field `lastPlayFinished` is responsible for 2 cases where an
>> animation in `STOPPED` status does not play after `play()` is called if the
>> rate is negative:
>>
>> 1. When the animation is created, it is `STOPPED` and
On Mon, 20 Jan 2020 10:00:55 GMT, Robert Lichtenberger
wrote:
> Test simulates a single mouse-released event.
> Fix simply guards against the null case.
@arapte - can you review this?
The only question I have is whether is is expected that `dragTabHeader` can be
null. If we understand why it
On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote:
> Updated GTK Webkit 2.26 (609.1) into jfx.
Everything looks good to me.
Here are a couple things I noticed that may warrant a follow-up issue to
address them:
1. Unimplemented methods:
* FileSystemJava.cpp:
* truncateFile
On Tue, 21 Jan 2020 18:02:14 GMT, Kevin Rushforth wrote:
>> Updated GTK Webkit 2.26 (609.1) into jfx.
>
> A sanity check of the patch looks good to me: I did a build / test on all
> three platforms. I'll do a bit more testing, and also review the
> JavaFX-specific files, before completing my
On Mon, 20 Jan 2020 11:10:07 GMT, Johan Vos wrote:
> Fix JDK-8237078
> replace the objc_msgSend call with a direct objC call.
> The fix works on XCode 10.1 and XCode 11.3
>
> Tested using
> java -Djfxmedia.platforms=OSXPlatform
> with MediaPlayer playing an mp3.
I verified the fix, and
On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote:
> Updated GTK Webkit 2.26 (609.1) into jfx.
A sanity check of the patch looks good to me: I did a build / test on all three
platforms. I'll do a bit more testing, and also review the JavaFX-specific
files, before completing my review.
To the
Updated GTK Webkit 2.26 (609.1) into jfx.
-
Commits:
- 8b48b1e0: 8233942: Update to 609.1 version of WebKit
Changes: https://git.openjdk.java.net/jfx/pull/91/files
Webrev: https://webrevs.openjdk.java.net/jfx/91/webrev.00
Issue: https://bugs.openjdk.java.net/browse/JDK-8233942
14 matches
Mail list logo
