On Sat, 7 Mar 2020 00:30:21 GMT, Tom Schindl
wrote:
>> That doesn't seem right. The additional fields are captured in the
>> anonymous class anyway (same as in lambdas).
>>
>> On Sat, Mar 7, 2020 at 1:53 AM Tom Schindl wrote:
>>
>>> I can somehow remember asking Richard Bair why JavaFX
On Fri, 6 Mar 2020 23:35:56 GMT, Nir Lisker wrote:
>> I note that this also changes the wrapper property objects from anonymous
>> subclasses of XPropertyBase to SimpleXProperty. This is more than
>> just a readability cleanup. It's probably fine for this case, but that's why
>> I
On Sat, 7 Mar 2020 00:22:59 GMT, Nir Lisker wrote:
>> I can somehow remember asking Richard Bair why JavaFX internally does not
>> use Simple* but creates the anonymous subclasses and he said it's memory
>> reason - Simple* uses more memory because of the additional fields
>
> That doesn't
On Fri, 6 Mar 2020 23:35:56 GMT, Nir Lisker wrote:
>> I note that this also changes the wrapper property objects from anonymous
>> subclasses of XPropertyBase to SimpleXProperty. This is more than
>> just a readability cleanup. It's probably fine for this case, but that's why
>> I
On Fri, 6 Mar 2020 23:12:57 GMT, Kevin Rushforth wrote:
>> A simple readability cleanup for the files that were changed in #113.
>>
>> Note that the boolean property has an `instanceof` check that doesn't exist
>> in the other properties.
>
> I note that this also changes the wrapper property
On Fri, 6 Mar 2020 22:43:50 GMT, Nir Lisker wrote:
> A simple readability cleanup for the files that were changed in #113.
>
> Note that the boolean property has an `instanceof` check that doesn't exist
> in the other properties.
I note that this also changes the wrapper property objects from
On Fri, 6 Mar 2020 11:47:42 GMT, Ajit Ghaisas wrote:
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>>
>> Fix : Added the missed out RTL checks to the key mappings in
>> TableViewBehaviorBase class.
>>
>> Testing : Modified unit tests in TableViewKeyInputTest to take orientation
On Fri, 6 Mar 2020 17:51:08 GMT, Nir Lisker wrote:
> Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors.
>
> [CSR](https://bugs.openjdk.java.net/browse/JDK-8240689)
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/140
On Fri, 6 Mar 2020 20:45:23 GMT, Kevin Rushforth wrote:
>> Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors.
>>
>> [CSR](https://bugs.openjdk.java.net/browse/JDK-8240689)
>
> Marked as reviewed by kcr (Lead).
@arapte can you also review this?
-
PR:
On Wed, 4 Mar 2020 14:11:42 GMT, Erik Helin wrote:
>> Please ignore this comment, this is for debugging Skara that might have some
>> mailing list mirroring issues
>
> Please ignore this comment as well, it is also for debugging issues with
> Skara and mailman :email:
@aghaisas can you
Changeset: cfa11934
Author:Kevin Rushforth
Date: 2020-03-06 19:19:17 +
URL: https://git.openjdk.java.net/jfx/commit/cfa11934
8236685: [macOs] Remove obsolete file dialog subclasses
Reviewed-by: arapte, prr
!
On Wed, 4 Mar 2020 20:27:46 GMT, Kevin Rushforth wrote:
> This is a follow-on to
> [JDK-8234474](https://bugs.openjdk.java.net/browse/JDK-8234474).
>
> This fix removes the custom subclasses of NSSavePanel and NSOpenPanel that
> are optionally used by the glass implementation of file open,
On Fri, 6 Mar 2020 18:22:24 GMT, Nir Lisker wrote:
>> Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors.
>>
>> [CSR](https://bugs.openjdk.java.net/browse/JDK-8240689)
>
> Why was the rfr label not reinstated?
@edvbld @rwestberg This is affected by
On Fri, 6 Mar 2020 17:51:08 GMT, Nir Lisker wrote:
> Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors.
>
> [CSR](https://bugs.openjdk.java.net/browse/JDK-8240689)
Why was the rfr label not reinstated?
-
PR: https://git.openjdk.java.net/jfx/pull/140
Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors.
[CSR](https://bugs.openjdk.java.net/browse/JDK-8240689)
-
Commits:
- 7548c723: Initial commit
Changes: https://git.openjdk.java.net/jfx/pull/140/files
Webrev:
On Fri, 6 Mar 2020 15:16:43 GMT, Johan Vos wrote:
> Add release notes for JavaFX 14 release
> Fix for JDK-8240631
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/139
Add release notes for JavaFX 14 release
Fix for JDK-8240631
-
Commits:
- 9db2ff25: Add release notes for JavaFX 14 release
Changes: https://git.openjdk.java.net/jfx/pull/139/files
Webrev: https://webrevs.openjdk.java.net/jfx/139/webrev.00
Issue:
This might fix the issue, but I’d like to understand better what the root of
the problem is. My concern is that this fix might cause a performance
regression.
I’m using the code in JDK-8177945. I want to look at what TableView does when
it adds a cell. Is there something about the selected
On Fri, 6 Mar 2020 06:00:36 GMT, Robert Lichtenberger
wrote:
>> I have exactly the same question.
>>
>> In general, it's better to work with the author of an existing PR instead of
>> creating a new one. If the original PR #73 is completely stalled, then it
>> might make sense, but not until
On Sun, 1 Mar 2020 12:24:06 GMT, Jeanette Winzenburg
wrote:
>> @kleopatra is right about the need to handle the case where the orientation
>> of a node changes. As for the test, I think the idea of parameterizing it
>> with LTR, RTL is good. I haven't reviewed it in detail, but added one
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480
>
> Fix : Added the missed out RTL checks to the key mappings in
> TableViewBehaviorBase class.
>
> Testing : Modified unit tests in TableViewKeyInputTest to take orientation as
> a parameter. The Left/Right key press tests have been
On Thu, 5 Mar 2020 21:47:35 GMT, Kevin Rushforth wrote:
>> the api is in a related issue (should be noted in the issue above). The
>> use-cases mentioned in the isssue: it's a do-once scenario with the skin
>> (and its subclasses) as the only user: multiple listeners can be registered,
>>
> Issue JDK-8088198, where an exception would be thrown when trying to capture
> a snapshot whose final dimensions would be larger than the running platform's
> maximum supported texture size, was addressed in openjfx14.
> The fix, based around the idea of capturing as many tiles of the maximum
On Fri, 6 Mar 2020 08:28:34 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java
> line 1527:
>
>> 1526: private int computeOptimumTileSize(int size, int
On Wed, 4 Mar 2020 20:27:46 GMT, Kevin Rushforth wrote:
> This is a follow-on to
> [JDK-8234474](https://bugs.openjdk.java.net/browse/JDK-8234474).
>
> This fix removes the custom subclasses of NSSavePanel and NSOpenPanel that
> are optionally used by the glass implementation of file open,
Regarding expected behaviour: in native combo boxes / dropdowns on Mac the TAB
key is doing nothing when the popup is open. If you want to select an item you
need to use the arrow keys. So I guess that is what I would expect for
navigating the element. But that does not mean that the key event
On Wed, 12 Feb 2020 13:21:03 GMT, Frederic Thevenet
wrote:
> Issue JDK-8088198, where an exception would be thrown when trying to capture
> a snapshot whose final dimensions would be larger than the running platform's
> maximum supported texture size, was addressed in openjfx14.
> The fix,
Changeset: f25e8cf2
Author:Ambarish Rapte
Date: 2020-03-06 08:23:04 +
URL: https://git.openjdk.java.net/jfx/commit/f25e8cf2
8212034: Potential memory leaks in jpegLoader.c in error case
Reviewed-by: jvos, kcr
! modules/javafx.graphics/src/main/native-iio/jpegloader.c
29 matches
Mail list logo
