On Sun, 12 Apr 2020 21:21:07 GMT, John Hendrikx wrote:
> This is a solution for 8242548. There was zero test coverage, so I added a
> few tests for this as well.
This pull request has now been integrated.
Changeset: 7b061900
Author:John Hendrikx
Committer: Ajit Ghaisas
URL:
On Tue, 5 May 2020 05:47:30 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Mon, 11 May 2020 04:30:28 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Wed, 6 May 2020 14:18:06 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
On Tue, 5 May 2020 11:19:55 GMT, Ambarish Rapte wrote:
>> Mostly refactoring in preparation of the upcoming fixes. The changes might
>> look like a lot, but it's mostly rearranging
>> of methods. Summery of changes:
>> ### Animation
>> * Added `isNearZero` and `areNearEqual` methods that deal
Hello All,
I am hoping to get some help with setting up a TableView. What I want is a
simple two column table with each column containing Strings. I want to be
able to double click to create a new row if I double clicked on empty
space. And I want to be able to edit any cell already in the table.
On Fri, 10 Apr 2020 10:26:06 GMT, Tom Schindl wrote:
> Extract keystate and add to the existing modifier mask, to support eg
> multi-select
>
> https://bugs.openjdk.java.net/browse/JDK-8202296
This pull request has now been integrated.
Changeset: 435671ee
Author:Tom Schindl
Committer:
On Tue, 12 May 2020 17:58:09 GMT, John Hendrikx wrote:
> I'm fine with doing a fix, but I need to know which one. Avoiding NPE's and
> silently doing nothing is IMHO not very
> desirable as this will give the user of the API no feedback that something
> went wrong.
> So I would prefer to fix
On Tue, 12 May 2020 13:44:53 GMT, Ajit Ghaisas wrote:
>> Marked as reviewed by kcr (Lead).
>
> @hjohn, this PR is ready to be merged.
> You need to comment /integrate on this PR as instructed by the bot above. I
> will sponsor it once you do it.
Sorry I figured only a committer was allowed to
On Mon, 11 May 2020 22:27:27 GMT, Nir Lisker wrote:
> As I started my review I noticed that `unbind` does not null-check its
> argument `dependencies` like `bind` does and it
> can lead to NPEs. If it is out of scope for this PR to fix this, a new issue
> should be filed.
I'm fine with doing
On Tue, 12 May 2020 15:56:32 GMT, Nir Lisker wrote:
> The fix looks correct and the tests pass. I just wonder why the change to
> reflection-based construction with
> `bindingMockClassConstructor`?
The Parameterized test constructs some standard Binding objects to run multiple
tests with.
On Tue, 12 May 2020 16:51:08 GMT, Rony G. Flatscher
wrote:
>> I think the approach proposed in this PR is the best solution for this
>> enhancement. Go ahead and remove the `WIP` from
>> the title, and we can proceed with the review.
>> The interface and behavior change will need to be
Hi Kevin,
in the meantime I have tried to come up with a formulation for the
"Introduction to FXML"
specification about the new compile processing instruction which is brief and
complete. While being
there I fixed a typo in the document and added a missing language processing
instruction to an
On Fri, 28 Feb 2020 17:46:58 GMT, Rony G. Flatscher
wrote:
> TODO: ADD DESCRIPTION OF PROPOSED FIX HERE.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jfx/pull/129
On Sat, 9 May 2020 15:15:52 GMT, Kevin Rushforth wrote:
>> test units for: compile PI+fallback
>>
>> tests/system/src/testscriptapp2/java/mymod/myapp2/FXMLScriptDeployment2Compile_Off.java
>> ... use compile PI to set off compilation of scripts; each script code
>>
On Wed, 22 Apr 2020 16:33:47 GMT, Rony G. Flatscher
wrote:
>> This WIP adds the ability for a fallback in case compilation of scripts
>> fails, in which case a warning gets issued
>> about this fact and evaluation of the script will be done without
>> compilation. Because of the fallback
On Mon, 20 Apr 2020 12:45:30 GMT, Rony G. Flatscher
wrote:
> This WIP adds the ability for a fallback in case compilation of scripts
> fails, in which case a warning gets issued
> about this fact and evaluation of the script will be done without
> compilation. Because of the fallback scripts
This WIP adds the ability for a fallback in case compilation of scripts fails,
in which case a warning gets issued
about this fact and evaluation of the script will be done without compilation.
Because of the fallback scripts get
compiled with this version by default. It extends PR 187
On Mon, 11 May 2020 22:27:27 GMT, Nir Lisker wrote:
>>> I will review this too anyway.
>>
>> Thank you. That will be helpful.
>
> As I started my review I noticed that `unbind` does not null-check its
> argument `dependencies` like `bind` does and it
> can lead to NPEs. If it is out of scope
On Thu, 7 May 2020 21:15:02 GMT, Joeri Sykora wrote:
> Adds support for building static libraries of the OpenJFX modules for the
> Windows platform. Building static libraries
> is done by providing the gradle property `-PSTATIC_BUILD=true`.
> Changes include:
>
> - add static flags for the
On Fri, 1 May 2020 12:33:36 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo in comment
>
> Marked as reviewed by kcr (Lead).
@hjohn, this PR is ready to be merged.
You need to
On Thu, 7 May 2020 21:15:02 GMT, Joeri Sykora wrote:
> Adds support for building static libraries of the OpenJFX modules for the
> Windows platform. Building static libraries
> is done by providing the gradle property `-PSTATIC_BUILD=true`.
> Changes include:
>
> - add static flags for the
> Issue :
> https://bugs.openjdk.java.net/browse/JDK-8244418
>
> Root Cause :
> Incorrect assumption about menu list size.
>
> Fix :
> Added check for empty menu list before trying to access it.
>
> Test :
> Added a unit test that fails before fix and passes after it.
Ajit Ghaisas has updated
On Fri, 8 May 2020 13:51:34 GMT, Jeanette Winzenburg
wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review_fixes
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuBarSkin.java
> line 485:
On Tue, 12 May 2020 12:03:36 GMT, Tom Schindl wrote:
>> Looks good to me. I verified that the new test fails without your fix and
>> passes with your fix.
>>
>> In case anyone else is looking at this and wants to run the test, it isn't
>> enabled by default, so you need to run it
>> like
On Mon, 11 May 2020 12:50:48 GMT, Jose Pereda wrote:
> With this PR, we pass directly the 16-bit unsigned short for a character
> (unicode value) to the Java layer, avoiding
> the cast with the C++ 8-bit char, that fails for non-ascii characters like
> euro (€) or quote (").
> We also avoid
On Tue, 28 Apr 2020 22:36:47 GMT, Kevin Rushforth wrote:
>> Tom Schindl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.
>>
>> Fix whitespace errors
>
> Looks
On Mon, 11 May 2020 12:50:48 GMT, Jose Pereda wrote:
> With this PR, we pass directly the 16-bit unsigned short for a character
> (unicode value) to the Java layer, avoiding
> the cast with the C++ 8-bit char, that fails for non-ascii characters like
> euro (€) or quote (").
> We also avoid
28 matches
Mail list logo
