Integrated: 8254964: Fix default values in Spinner class

2020-10-20 Thread Nir Lisker
On Sun, 18 Oct 2020 11:30:47 GMT, Nir Lisker wrote: > Added 2 `@defaultValue` and fixed the incorrect default for `editable`. Also > corrected a typo that doesn't show anyway > in the docs. This pull request has now been integrated. Changeset: a3699381 Author:Nir Lisker URL:

Re: RFR: 8254964: Fix default values in Spinner class

2020-10-20 Thread Kevin Rushforth
On Sun, 18 Oct 2020 11:30:47 GMT, Nir Lisker wrote: > Added 2 `@defaultValue` and fixed the incorrect default for `editable`. Also > corrected a typo that doesn't show anyway > in the docs. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/323

Re: [11][15] RFR: Request to backport October 2020 CPU changes

2020-10-20 Thread Johan Vos
Approved. On Tue, Oct 20, 2020 at 6:46 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the changes from the just-released > October 2020 CPU to 11-dev (for 11.0.9) and the jfx15 branch of jfx (for > 15.0.1). > >

RE: RFR: Request to sync October 2020 CPU changes into jfx

2020-10-20 Thread Ambarish Rapte
Looks good to me, +1. -Original Message- From: Kevin Rushforth Sent: Tuesday, October 20, 2020 9:36 PM To: Johan Vos ; Ambarish Rapte ; openjfx-dev@openjdk.java.net Subject: RFR: Request to sync October 2020 CPU changes into jfx Johan and Ambarish, I request approval to sync changes

[11][15] RFR: Request to backport October 2020 CPU changes

2020-10-20 Thread Kevin Rushforth
Hi Johan, I request approval to backport the changes from the just-released October 2020 CPU to 11-dev (for 11.0.9) and the jfx15 branch of jfx (for 15.0.1). https://cr.openjdk.java.net/~kcr/cpu-2010-sync/11-dev/webrev/ https://github.com/kevinrushforth/jfx/compare/4b75750...15-cpu-2010-sync

Re: RFR: Request to sync October 2020 CPU changes into jfx

2020-10-20 Thread Johan Vos
Approved. On Tue, Oct 20, 2020 at 6:07 PM Kevin Rushforth wrote: > Johan and Ambarish, > > I request approval to sync changes from to the just-released October > 2020 CPU release into the 'master' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: > >

RFR: Request to sync October 2020 CPU changes into jfx

2020-10-20 Thread Kevin Rushforth
Johan and Ambarish, I request approval to sync changes from to the just-released October 2020 CPU release into the 'master' branch of the 'jfx' repo. Here is the aggregate set of changes for the fixes: https://github.com/kevinrushforth/jfx/compare/01ba6e1e41...cpu-2010-sync NOTE: Since this

Re: Can't load fxml on Macos

2020-10-20 Thread Michael Hall
> On Oct 20, 2020, at 8:56 AM, Davide Perini > wrote: > > GUIManager.class.getResource Not finding it? Not sure why that would be different OS X though. Recently moved a (non-jfx) project to Eclipse and had to change class.getResourceAsStream to ClassLoader.getResourceAsStream. Because

Re: Can't load fxml on Macos

2020-10-20 Thread Davide Perini
I'm creating my binary file using JPackage but I don't signed the binary. can this be the problem. why a simple line like this FXMLLoader fxmlLoader =new FXMLLoader(GUIManager.class.getResource( fxml + Constants.FXML)); return null if it works on WIndows and Linux? Thanks Davide Il

Re: Can't load fxml on Macos

2020-10-20 Thread Dirk Lemmermann
I worked with JavaFX on MacOS since 2013 and except for issues related to font rendering I never got the impression that MacOS is the black sheep. I also happen to know that many of the developers that are working on JavaFX use MacOS. Dirk > On Oct 20, 2020, at 12:28 PM, Davide Perini >

[jfx15] Integrated: 8255042: Change JavaFX release version in jfx15 branch to 15.0.1

2020-10-20 Thread Johan Vos
On Tue, 20 Oct 2020 08:12:41 GMT, Johan Vos wrote: > Increase release version to 15.0.1 > Fix for JDK-8255042 This pull request has now been integrated. Changeset: 86ff5dea Author:Johan Vos URL: https://git.openjdk.java.net/jfx/commit/86ff5dea Stats: 1 line in 1 file changed: 0

Re: Can't load fxml on Macos

2020-10-20 Thread Tom Schindl
Well, you don't give a enough information (no stacktrace, no context, ...). If you have reproducable code please share it (with the current information provided I highly doubt this is an issue in Java/JavaFX). Tom Am 20.10.20 um 12:28 schrieb Davide Perini: Hi all, this code works well on

RFR: 8255002: Many javafx.controls unit tests have incorrect name containing impl_*

2020-10-20 Thread Ajit Ghaisas
It is a test cleanup work. Issue : Many unit tests in javafx.controls module have incorrect naming that use text "impl_" in names and comments. The test code correctly avoids using impl_* methods (as they were removed in JDK 9), but test names still have "impl_" in them. Fix : These tests are

Re: [jfx15] RFR: 8255042: Change JavaFX release version in jfx15 branch to 15.0.1

2020-10-20 Thread Kevin Rushforth
On Tue, 20 Oct 2020 08:12:41 GMT, Johan Vos wrote: > Increase release version to 15.0.1 > Fix for JDK-8255042 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/325

Can't load fxml on Macos

2020-10-20 Thread Davide Perini
Hi all, this code works well on both Windows and Linux running Java 15 on JavaFX 15. FXMLLoader fxmlLoader =new FXMLLoader(GUIManager.class.getResource( fxml + Constants.FXML)); return fxmlLoader.load(); It doesn't work on Macos returning a nullpointer exception. Any idea? Why Macos is

Re: RFR: 8254605: repaint on Android broken [v2]

2020-10-20 Thread Florian Kirmaier
On Mon, 19 Oct 2020 18:26:43 GMT, Ambarish Rapte wrote: >> Marked as reviewed by kcr (Lead). > > Reverting #153 seems right, I don't have any specific comments. Please go > ahead and merge the change. @johanvos @jperedadnr A unit-test would be great, otherwise, it would be very hard to fix the

[jfx15] RFR: 8255042: Change JavaFX release version in jfx15 branch to 15.0.1

2020-10-20 Thread Johan Vos
Increase release version to 15.0.1 Fix for JDK-8255042 - Commit messages: - Increase release version to 15.0.1 Changes: https://git.openjdk.java.net/jfx/pull/325/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=325=00 Issue: