Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v4]

2021-03-02 Thread Abhinay Agarwal
> Add release notes for JavaFX 16 to the repository Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision: 8262460: Sort issues first by sub-component followed by bug id - Changes: - all:

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v2]

2021-03-02 Thread Kevin Rushforth
On Tue, 2 Mar 2021 19:14:24 GMT, Nir Lisker wrote: >> Abhinay Agarwal has updated the pull request with a new target base due to a >> merge or a rebase. > > Changes requested by nlisker (Reviewer). A couple other comments: 1. Previous release notes were sorted first by subcomponent and then

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v3]

2021-03-02 Thread Johan Vos
On Tue, 2 Mar 2021 19:52:31 GMT, Kevin Rushforth wrote: >> There are some "backport" issues that are sort of forward ported but still >> have type backport. For example, issues fixed in 15.0.1 are "backported" to >> 16. > > There are issues in 15 with a backport to 16. I'd be surprised if that

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v3]

2021-03-02 Thread Kevin Rushforth
On Tue, 2 Mar 2021 19:41:45 GMT, Johan Vos wrote: >> All original issues are added to the Release Notes if an issue is a backport >> issue. It seems like there is backport issue against JDK-8246343 with fix >> version `openjfx16`. > > There are some "backport" issues that are sort of forward

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v3]

2021-03-02 Thread Johan Vos
On Tue, 2 Mar 2021 19:18:33 GMT, Abhinay Agarwal wrote: >> doc-files/release-notes-16.md line 20: >> >>> 18: [JDK-8176270](https://bugs.openjdk.java.net/browse/JDK-8176270)|Adding >>> ChangeListener to TextField.selectedTextProperty causes >>> StringOutOfBoundsException|controls >>> 19:

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v3]

2021-03-02 Thread Abhinay Agarwal
On Tue, 2 Mar 2021 19:00:07 GMT, Nir Lisker wrote: >> Abhinay Agarwal has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > > doc-files/release-notes-16.md line

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v2]

2021-03-02 Thread Nir Lisker
On Tue, 2 Mar 2021 18:54:27 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 16 to the repository > > Abhinay Agarwal has updated the pull request with a new target base due to a > merge or a rebase. Changes requested by nlisker (Reviewer). - PR:

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v3]

2021-03-02 Thread Nir Lisker
On Tue, 2 Mar 2021 19:12:39 GMT, Abhinay Agarwal wrote: >> Add release notes for JavaFX 16 to the repository > > Abhinay Agarwal has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v3]

2021-03-02 Thread Abhinay Agarwal
> Add release notes for JavaFX 16 to the repository Abhinay Agarwal has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16 [v2]

2021-03-02 Thread Abhinay Agarwal
> Add release notes for JavaFX 16 to the repository Abhinay Agarwal has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 27 additional commits since the

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16

2021-03-02 Thread Kevin Rushforth
On Tue, 2 Mar 2021 18:48:10 GMT, Kevin Rushforth wrote: >> Add release notes for JavaFX 16 to the repository > > The target branch should be changed to `jfx16` And this means you will need to rebase on top of `jfx16`, so that it doesn't bring in commits from master. - PR:

Re: [jfx16] RFR: 8262460: Create release notes for JavaFX 16

2021-03-02 Thread Kevin Rushforth
On Tue, 2 Mar 2021 18:25:14 GMT, Abhinay Agarwal wrote: > Add release notes for JavaFX 16 to the repository The target branch should be changed to `jfx16` - PR: https://git.openjdk.java.net/jfx/pull/414

RFR: 8262460: Create release notes for JavaFX 16

2021-03-02 Thread Abhinay Agarwal
Add release notes for JavaFX 16 to the repository - Commit messages: - 8262460: Create release notes for JavaFX 16 Changes: https://git.openjdk.java.net/jfx/pull/414/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=414=00 Issue:

Re: Eclipse problem: not compiling module projects

2021-03-02 Thread Jeanette Winzenburg
"from scratch" are the words I feared to hear ;) Probably no way around, thanks Tom! Zitat von Tom Schindl : I setup everything from scratch a few weeks ago and all worked fine: * I first run the gradle build * then imported everything into Eclipse Tom Am 02.03.21 um 14:37 schrieb

Re: Eclipse problem: not compiling module projects

2021-03-02 Thread Tom Schindl
I setup everything from scratch a few weeks ago and all worked fine: * I first run the gradle build * then imported everything into Eclipse Tom Am 02.03.21 um 14:37 schrieb Jeanette Winzenburg: Just a quick question to Eclipse users (who do compile with Eclipse, not with gradle) Problem:

Eclipse problem: not compiling module projects

2021-03-02 Thread Jeanette Winzenburg
Just a quick question to Eclipse users (who do compile with Eclipse, not with gradle) Problem: updated my Eclipse to the december release yesterday, now it doesn't compile (neither automatically, nor forcing a clean build) anything as soon as the module projects are included, neither

Re: Request to backport 7 fixes to 11-dev for 11.0.11

2021-03-02 Thread Kevin Rushforth
Approved. -- Kevin On 3/2/2021 4:53 AM, Johan Vos wrote: Hi Kevin, I request permission to backport the following issues to 11-dev, for the 11.0.11 release: JDK-8258592: Control labels in Dialogs are truncated at certain DPI scaling levels JDK-8256283: IndexOutOfBoundsException when

Request to backport 7 fixes to 11-dev for 11.0.11

2021-03-02 Thread Johan Vos
Hi Kevin, I request permission to backport the following issues to 11-dev, for the 11.0.11 release: JDK-8258592: Control labels in Dialogs are truncated at certain DPI scaling levels JDK-8256283: IndexOutOfBoundsException when sorting a TreeTableView JDK-8165749: java.lang.RuntimeException: