Re: Build error with gradle (command line)

2021-05-18 Thread Nir Lisker
I'm getting this error in Eclipse when it tries to load the tasks, but in the command line I can build and test. I already refreshed the dependencies and cleaned the cache. Did you solve this in Eclipse? On Tue, May 11, 2021 at 1:44 PM Jeanette Winzenburg wrote: > > Thanks Johan, Ajit > >

Re: [jfx11u] RFR: 8266554: Change default macOS min version for aarch64 to 11.0

2021-05-18 Thread Kevin Rushforth
On Tue, 18 May 2021 20:05:03 GMT, Johan Vos wrote: > Require at least MacOSX 11.0 to build on mac-AArch64. > Don't increase minimum SDK version when building on x86-64 (contrary to > JDK-8265031) Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx11u/pull/21

Re: Re: Minimum JDK policy for OpenJFX

2021-05-18 Thread Eric Bresie
Are there any deprecated or removed (1) (2) dependencies that could cause problems? (1) https://jdk.java.net/16/release-notes#removed (2) https://mail.openjdk.java.net/pipermail/jdk-dev/2021-March/005191.html Eric Bresie ebre...@gmail.com (mailto:ebre...@gmail.com) > On May 18, 2021 at 4:42:45

Re: [External] : Re: Minimum JDK policy for OpenJFX

2021-05-18 Thread Kevin Rushforth
You raise a good point about whether or not it should matter if a version is (generally considered to be) an LTS release. I wasn't suggesting that we necessarily wait until the next LTS to consider picking up an important new feature, just that it could be one factor. I also would be very

Re: Minimum JDK policy for OpenJFX

2021-05-18 Thread Nir Lisker
> > there are some advantages in being able to run with the latest JDK LTS > One *potential* issue with this approach is that LTS is not defined in OpenJDK as far as I know. The LTS versions are a business decision of each distributor. For now, they have all aligned on 8, 11, 17, but nothing

Re: [External] : Re: Dependencies on java.desktop

2021-05-18 Thread Kevin Rushforth
As noted in the thread you quoted below, removing the dependency on java.desktop from javafx.base isn't a particularly hard problem, and is tracked by JDK-8240844 [1]. And even though it will require a spec change (meaning a CSR), it doesn't result in any loss of functionality, since in order

Re: Minimum JDK policy for OpenJFX

2021-05-18 Thread Chuck Davis
I use JFX with NetBeans every day with no problems. NetBeans 12.3 and JFX 16 on OpenJDK16 SceneBuilder creates the dialogs. NetBeans writes the code. The NB JFX is too old. You have to update from Maven (which is, itself, still stuck on old versions of JFX -- hasn't been updated for some

Re: Dependencies on java.desktop

2021-05-18 Thread Nir Lisker
I would also be surprised if printing and bean adapters are used much, but what are the options? Rewrite the printing implementation. On Tue, May 18, 2021 at 8:45 PM Tom Schindl wrote: > Uff - I'd like to revisit this topic. As I did some jlink stuff for our > applications adding java.desktop

Re: Minimum JDK policy for OpenJFX

2021-05-18 Thread Matthias Bläsing
Hi, Am Dienstag, dem 18.05.2021 um 08:17 -0700 schrieb Kevin Rushforth: > > In general, we only guarantee that JavaFX N runs on JDK N-1 or later. In > practice, though, we don't bump it for each release, as there are some > advantages in being able to run with the latest JDK LTS. Since JavaFX

[jfx11u] RFR: 8266554: Change default macOS min version for aarch64 to 11.0

2021-05-18 Thread Johan Vos
Require at least MacOSX 11.0 to build on mac-AArch64. Don't increase minimum SDK version when building on x86-64 (contrary to JDK-8265031) - Commit messages: - Increase minimum SDK version when building on AArch64 Changes: https://git.openjdk.java.net/jfx11u/pull/21/files Webrev:

[jfx11u] Integrated: 8257895: Allow building of JavaFX media libs for Apple Silicon

2021-05-18 Thread Johan Vos
On Tue, 18 May 2021 18:27:10 GMT, Johan Vos wrote: > Co-authored-by: Johan Vos > Reviewed-by: jvos, kcr This pull request has now been integrated. Changeset: 7e16449b Author:Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/7e16449b2bdeb093b14c1433459bfeb0e49a9f91 Stats:

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-18 Thread Joeri Sykora
On Thu, 13 May 2021 21:55:59 GMT, Kevin Rushforth wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >>

[jfx11u] RFR: 8257895: Allow building of JavaFX media libs for Apple Silicon

2021-05-18 Thread Johan Vos
Co-authored-by: Johan Vos Reviewed-by: jvos, kcr - Commit messages: - 8257895: Allow building of JavaFX media libs for Apple Silicon Changes: https://git.openjdk.java.net/jfx11u/pull/20/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=20=00 Issue:

[jfx11u] Integrated: 8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568

2021-05-18 Thread Ambarish Rapte
On Tue, 18 May 2021 15:06:05 GMT, Ambarish Rapte wrote: > Fixes a css style regression issue caused by > [JDK-8204568](https://bugs.openjdk.java.net/browse/JDK-8204568). This pull request has now been integrated. Changeset: b2d930e7 Author:Ambarish Rapte URL:

[jfx11u] Integrated: 8264536: Building OpenJFX on Apple AARCH64 not possible

2021-05-18 Thread Johan Vos
On Tue, 18 May 2021 17:11:35 GMT, Johan Vos wrote: > Reviewed-by: kcr This pull request has now been integrated. Changeset: d3ba1cec Author:Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/d3ba1cec162e63bfd850de08e112d8bf43006cf1 Stats: 1 line in 1 file changed: 0 ins;

[jfx11u] Integrated: 8257758: Allow building of JavaFX native libs for Apple Silicon

2021-05-18 Thread Johan Vos
On Tue, 18 May 2021 17:12:17 GMT, Johan Vos wrote: > Reviewed-by: kcr This pull request has now been integrated. Changeset: 37d25bce Author:Johan Vos URL: https://git.openjdk.java.net/jfx11u/commit/37d25bce9a917677381a2675d7d75b5ae3e7165f Stats: 10 lines in 1 file changed: 9

Integrated: 8264219: tools/scripts/build.ps1 is out of date and no longer works

2021-05-18 Thread Kevin Rushforth
On Sat, 8 May 2021 14:13:34 GMT, Kevin Rushforth wrote: > As noted in PR #212 the unused `tools/scripts/build.ps1` script no longer > works. This script was added in support of the Appveyor builds in the old > `javafxports/openjdk-jfx` sandbox repo, which haven't been used in nearly two >

Re: Dependencies on java.desktop

2021-05-18 Thread Tom Schindl
Uff - I'd like to revisit this topic. As I did some jlink stuff for our applications adding java.desktop once more bugged me. I guess the first thing to do is to file a JIRA-Ticket but it really starts to bug me to include java.desktop although I don't plan to use printing (and I guess > 90%

[jfx11u] RFR: 8264536: Building OpenJFX on Apple AARCH64 not possible

2021-05-18 Thread Johan Vos
Reviewed-by: kcr - Commit messages: - 8264536: Building OpenJFX on Apple AARCH64 not possible Changes: https://git.openjdk.java.net/jfx11u/pull/18/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=18=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264536 Stats: 1

[jfx11u] RFR: 8257758: Allow building of JavaFX native libs for Apple Silicon

2021-05-18 Thread Johan Vos
Reviewed-by: kcr - Commit messages: - 8257758: Allow building of JavaFX native libs for Apple Silicon Changes: https://git.openjdk.java.net/jfx11u/pull/19/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=19=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8257758

Re: Minimum JDK policy for OpenJFX

2021-05-18 Thread Michael Strauß
Sounds good, although it is a bit unfortunate that sealed classes will only be un-previewed in JDK 17. I think this feature has great value for reasoning about code, in particular for library development. Do you think we could bump it directly to JDK 17, which I think is very fitting because it's

[jfx11u] RFR: 8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568

2021-05-18 Thread Ambarish Rapte
Fixes a css style regression issue caused by [JDK-8204568](https://bugs.openjdk.java.net/browse/JDK-8204568). - Commit messages: - 8266966: Wrong CSS properties are applied to other nodes after fix for JDK-8204568 Changes: https://git.openjdk.java.net/jfx11u/pull/17/files

Re: Minimum JDK policy for OpenJFX

2021-05-18 Thread Kevin Rushforth
A very timely question. I was already planning to raise this as a discussion after we update our boot JDK to JDK 16 (blocked by the in-progress gradle 7 update), which I hope to do later this week. I think that this is the right time to consider bumping the minimum required version to run

Re: RFR: 8264219: tools/scripts/build.ps1 is out of date and no longer works

2021-05-18 Thread Ambarish Rapte
On Sat, 8 May 2021 14:13:34 GMT, Kevin Rushforth wrote: > As noted in PR #212 the unused `tools/scripts/build.ps1` script no longer > works. This script was added in support of the Appveyor builds in the old > `javafxports/openjdk-jfx` sandbox repo, which haven't been used in nearly two >

Minimum JDK policy for OpenJFX

2021-05-18 Thread Michael Strauß
Currently, JDK 11 is required for the latest version of OpenJFX. What is the policy for bumping this requirement? Does it always correspond to the latest JDK LTS release (the next of which will be JDK 17), or is it independent from the release cycle of OpenJDK?

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v14]

2021-05-18 Thread Jeanette Winzenburg
On Tue, 18 May 2021 10:14:11 GMT, Florian Kirmaier wrote: >> Fixing ListCell editing status is true, when index changes while editing. > > Florian Kirmaier has updated the pull request incrementally with two > additional commits since the last revision: > > - 8264127 >fixed assertion

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v14]

2021-05-18 Thread Jeanette Winzenburg
On Tue, 18 May 2021 10:14:11 GMT, Florian Kirmaier wrote: >> Fixing ListCell editing status is true, when index changes while editing. > > Florian Kirmaier has updated the pull request incrementally with two > additional commits since the last revision: > > - 8264127 >fixed assertion

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v14]

2021-05-18 Thread Florian Kirmaier
> Fixing ListCell editing status is true, when index changes while editing. Florian Kirmaier has updated the pull request incrementally with two additional commits since the last revision: - 8264127 fixed assertion text, exception handler is now installed/uninstalled like in

Re: RFR: 8264127: ListCell editing status is true, when index changes while editing [v13]

2021-05-18 Thread Florian Kirmaier
On Mon, 17 May 2021 08:40:44 GMT, Jeanette Winzenburg wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8264127 >> More changes, simplifications and tests based on CR > >

Re: RFR: 8264219: tools/scripts/build.ps1 is out of date and no longer works

2021-05-18 Thread Pankaj Bansal
On Sat, 8 May 2021 14:13:34 GMT, Kevin Rushforth wrote: > As noted in PR #212 the unused `tools/scripts/build.ps1` script no longer > works. This script was added in support of the Appveyor builds in the old > `javafxports/openjdk-jfx` sandbox repo, which haven't been used in nearly two >