There is an open bug report [1] that I created before the transition to
GitHub that fixes BuildSrc and some apps, I will update it for the latest
changes.
Right now I am waiting to see which folders are still relevant.
[1] https://bugs.openjdk.java.net/browse/JDK-8221708
On Thu, May 20, 2021 at
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with
> This PR adds support for loading images from [inline data
> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
> supported by web browsers. This enables developers to package small images in
> CSS files, rather than separately deploying the images alongside the CSS
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with
> This PR adds support for loading images from [inline data
> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
> supported by web browsers. This enables developers to package small images in
> CSS files, rather than separately deploying the images alongside the CSS
On Fri, 14 May 2021 22:29:25 GMT, Kevin Rushforth wrote:
> You may be right about the scale problem being preexisting. I'll double check
> when I test on Mac next week (both Retina and external screen).
I can confirm that the scaling problem on macOS Retina a preexisting bug (not
related to
> This PR adds support for loading images from [inline data
> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
> supported by web browsers. This enables developers to package small images in
> CSS files, rather than separately deploying the images alongside the CSS
> This PR adds support for loading images from [inline data
> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
> supported by web browsers. This enables developers to package small images in
> CSS files, rather than separately deploying the images alongside the CSS
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with
On Fri, 21 May 2021 13:10:50 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modify test to avoid online resources
>
>
> This PR limits the `tableIndex` value, used by the LZWDecoder algorithm in
> `GIFImageLoader2`, to avoid a potential AIOOB exception that happens on some
> animated GIFs, to the maximum size of the tables used (4096).
>
> In some occasions loading an animated GIF like the one used in the
On Wed, 19 May 2021 20:24:31 GMT, Michael Strauß wrote:
> This PR adds support for loading images from [inline data
> URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
> supported by web browsers. This enables developers to package small images in
> CSS files, rather
On Thu, 20 May 2021 07:18:28 GMT, Ambarish Rapte wrote:
> The same failure was earlier fixed at PR #496, which seems insufficient.
> The changes in this PR were also tried ealier in the PR #496 but later
> removed, as they seemed not necessary.
> Fix is to clean up the test, by removing all
This seems like a very reasonable proposal. I'd like to see it
documented in the Image class, so I'll mark it as needing a CSR.
-- Kevin
On 5/19/2021 1:36 PM, Michael Strauß wrote:
I would like to propose adding support for loading images from inline
data-URIs, as commonly supported by web
This PR adds support for loading images from [inline data
URIs](https://en.wikipedia.org/wiki/Data_URI_scheme), which is also widely
supported by web browsers. This enables developers to package small images in
CSS files, rather than separately deploying the images alongside the CSS file.
Good point about the STYLESHEET_CASPIAN and STYLESHEET_MODENA values.
Here are a few more aspects for discussion:
Any sufficiently sophisticated theme will probably be comprised of
several stylesheets. In fact, the built-in themes are a good example
for that. Since the current API doesn't allow
On Fri, 21 May 2021 11:48:21 GMT, Ajit Ghaisas wrote:
> The javafx.css.Selector and javafx.css.converter.ShapeConverter constructors
> were deprecated for removal in openjfx16.
> This PR removes these constructors (targeted for openjfx17).
Marked as reviewed by pbansal (Committer).
Please file an Enhancement request first, and from that enhancement
create a new CSR. Ideally JBS would prevent direct creation of an issue
with an issuetype of CSR.
As for the feature itself, it seems useful, but will need discussion as
to the value proposition (i.e., cost / benefit), and
Here's a CSR that explains the details of the proposed public API:
https://bugs.openjdk.java.net/browse/JDK-8267540
On Fri, 21 May 2021 13:02:14 GMT, Jose Pereda wrote:
> This PR limits the `tableIndex` value, used by the LZWDecoder algorithm in
> `GIFImageLoader2`, to avoid a potential AIOOB exception that happens on some
> animated GIFs, to the maximum size of the tables used (4096).
>
> In some
On Fri, 21 May 2021 11:48:21 GMT, Ajit Ghaisas wrote:
> The javafx.css.Selector and javafx.css.converter.ShapeConverter constructors
> were deprecated for removal in openjfx16.
> This PR removes these constructors (targeted for openjfx17).
Marked as reviewed by kcr (Lead).
-
PR:
This PR limits the `tableIndex` value, used by the LZWDecoder algorithm in
`GIFImageLoader2`, to avoid a potential AIOOB exception that happens on some
animated GIFs, to the maximum size of the tables used (4096).
In some occasions loading an animated GIF like the one used in the included
On Wed, 19 May 2021 00:48:18 GMT, Marius Hanl
wrote:
> ~~Note: I reported the bug already, waiting for approval. Internal tracking
> id: 9070318. I will update the title as soon as the ticket is created.~~
> EDIT: Changed the title. :)
>
> This PR is fixing a NP, which is thrown when you
The javafx.css.Selector and javafx.css.converter.ShapeConverter constructors
were deprecated for removal in openjfx16.
This PR removes these constructors (targeted for openjfx17).
-
Commit messages:
- 8252783 fix
Changes: https://git.openjdk.java.net/jfx/pull/512/files
Webrev:
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox
wrote:
>> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
>> expected by more accurately mapping from a Mac key code to a Java key code
>> based on the user’s active keyboard layout (the existing code assumes a US
>> QWERTY
On Wed, 19 May 2021 14:15:00 GMT, Marius Hanl
wrote:
>> ~~Note: I reported the bug already, waiting for approval. Internal tracking
>> id: 9070318. I will update the title as soon as the ticket is created.~~
>> EDIT: Changed the title. :)
>>
>> This PR is fixing a NP, which is thrown when you
On Thu, 20 May 2021 11:12:09 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127
> small changes based on
I've been a proponent of a theme implementation for a long time, even before
JavaFX was separated out (had quite a few discussions with Jonathan about it).
So this proposal is great!
On 2021-05-21 06:36, Michael Strauß wrote:
Currently, the two themes shipped with JavaFX (Caspian and Modena)
28 matches
Mail list logo
