Re: [jfx11u] RFR: 8266462: Update copyright years of javafx.web native sources in jfx11u

2021-08-16 Thread Kevin Rushforth
On Mon, 16 Aug 2021 21:55:52 GMT, Kevin Rushforth wrote: > As mentioned in the JBS bug report, this is needed to minimize gratuitous > diffs in the native WebKit sources between mainline and jfx11u. These diffs > can make it hard to see whether there is any substantive diff between the two >

[jfx11u] RFR: 8266462: Update copyright years of javafx.web native sources in jfx11u

2021-08-16 Thread Kevin Rushforth
As mentioned in the JBS bug report, this is needed to minimize gratuitous diffs in the native WebKit sources between mainline and jfx11u. These diffs can make it hard to see whether there is any substantive diff between the two and also can sometimes lead to merge conflicts. In addition to the

Re: RFR: 8272329: Cherry pick GTK WebKit 2.32.3 changes [v2]

2021-08-16 Thread Kevin Rushforth
On Mon, 16 Aug 2021 20:13:03 GMT, Ambarish Rapte wrote: >> Cherry pick the GTK webkit 2.32.3 changes >> https://webkitgtk.org/2021/07/23/webkitgtk2.32.3-released.html > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > >

[jfx11u] Integrated: 8209086: Some javafx.web files are missing GPLv2+Classpath copyright header

2021-08-16 Thread Kevin Rushforth
On Mon, 16 Aug 2021 21:23:56 GMT, Kevin Rushforth wrote: > Clean backport of fix to add missing copyright headers. No changes other than > comments. This pull request has now been integrated. Changeset: 1a021ed4 Author:Kevin Rushforth URL:

[jfx11u] RFR: 8209086: Some javafx.web files are missing GPLv2+Classpath copyright header

2021-08-16 Thread Kevin Rushforth
Clean backport of fix to add missing copyright headers. No changes other than comments. - Commit messages: - 8209086: Some javafx.web files are missing GPLv2+Classpath copyright header Changes: https://git.openjdk.java.net/jfx11u/pull/28/files Webrev:

Re: RFR: 8272329: Cherry pick GTK WebKit 2.32.3 changes [v2]

2021-08-16 Thread Ambarish Rapte
On Mon, 16 Aug 2021 17:53:56 GMT, Johan Vos wrote: >> I think this change was lost during webkit update. and it caused a >> regression [JDK-8269067](https://bugs.openjdk.java.net/browse/JDK-8269067) : >> CSSFilterTest fails intermittently in Windows. >> This change was originally included to

Re: RFR: 8272329: Cherry pick GTK WebKit 2.32.3 changes [v2]

2021-08-16 Thread Ambarish Rapte
> Cherry pick the GTK webkit 2.32.3 changes > https://webkitgtk.org/2021/07/23/webkitgtk2.32.3-released.html Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: revert changes from JDK-8260165 - Changes: - all:

Re: RFR: 8244419: TextAreaSkin: throws UnsupportedOperation on dispose

2021-08-16 Thread Marius Hanl
On Sat, 14 Aug 2021 10:32:00 GMT, Jeanette Winzenburg wrote: > The issue was a glaring contract violation of TextAreaSkin which throws a > UnsupportedOperationException. The fix was to remove the throwing and cleanup > on dispose which implies > > in TextAreaBehavior: > - remove the listener

Re: Why GTK4 glass backend will not (probably) be an #IFDEF

2021-08-16 Thread Thiago Milczarek Sayão
Correction: * Gdk Surface would be used instead of *Gdk*Window. * GtkDrawingArea widget would be used to draw fx data. Also, after further investigation libwayland is a no, too much work, specially because client side decorations. So for wayland we should stick with Gtk (a greater gtk3 version

Gtk3 minimum required version

2021-08-16 Thread Thiago Milczarek Sayão
Hi, Currently the minimum required version is 3.8. Beginning on 3.10 Gtk added support for client-side decorations and the GtkHeaderBar is the default widget to do that. https://docs.gtk.org/gtk3/ctor.HeaderBar.new.html Gtk 3.10 was released Sep/2013. Gtk4 and Gnome apps default to this

Re: RFR: 8272329: Cherry pick GTK WebKit 2.32.3 changes

2021-08-16 Thread Johan Vos
On Mon, 16 Aug 2021 06:59:18 GMT, Ambarish Rapte wrote: >> That is a good question. I believe that was actually introduced because of >> JDK-8260165 (and removed in the next update by commit >> ed0baf5f23aed0d8aaa72645c8e03fde56d0f0cc) >> >> The problem with this 250ms delay is that in case

[jfx11u] Integrated: 8262396: Update Mesa 3-D Headers to version 21.0.3

2021-08-16 Thread Kevin Rushforth
On Mon, 16 Aug 2021 17:37:09 GMT, Kevin Rushforth wrote: > Clean backport of Mesa-3D third-party update. This pull request has now been integrated. Changeset: 330b4fad Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx11u/commit/330b4fadb0f3b76f77f0338f26b90979605518c8

[jfx11u] RFR: 8262396: Update Mesa 3-D Headers to version 21.0.3

2021-08-16 Thread Kevin Rushforth
Clean backport of Mesa-3D third-party update. - Commit messages: - 8262396: Update Mesa 3-D Headers to version 21.0.3 Changes: https://git.openjdk.java.net/jfx11u/pull/27/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=27=00 Issue:

Re: RFR: 8188026: TextFieldXXCell: NPE on calling startEdit [v3]

2021-08-16 Thread Marius Hanl
On Wed, 28 Jul 2021 15:12:45 GMT, Jeanette Winzenburg wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reordered commit > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellStartEditTest.java

Improving/Enhancing Accessibility Support on Windows

2021-08-16 Thread Tom Schindl
Hi, I'd like to inform you that we (BestSolution.at) are currently partnering with another company (dvhaus.de) to allow JavaFX applications leverage the complete Window UI Automation API for OpenJFX applications *running on Windows*. The main target of our work is to provide best

Re: RFR: 8272329: Cherry pick GTK WebKit 2.32.3 changes

2021-08-16 Thread Ambarish Rapte
On Sat, 14 Aug 2021 09:13:25 GMT, Johan Vos wrote: >> modules/javafx.web/src/main/native/Source/WebCore/page/FrameViewLayoutContext.cpp >> line 393: >> >>> 391: const Seconds layoutScheduleThreshold = 250_ms; >>> 392: m_layoutTimer.startOneShot(layoutScheduleThreshold); >>> 393: #else

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation

2021-08-16 Thread Pankaj Bansal
On Sun, 15 Aug 2021 20:10:43 GMT, Thiago Milczarek Sayao wrote: > Weird, It works consistently for me on 20.04. Just tested again to be sure. I am running a 20.04 VM. The test fails for me 60-70% of the time. I will request someone in team to try this once. - PR: