Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue

2021-11-18 Thread Kevin Rushforth
On Thu, 18 Nov 2021 20:58:06 GMT, John Hendrikx wrote: > This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was

Re: RFR: 8276174: Build failure on MacBook Air (M1) in JFX component graphics [v2]

2021-11-18 Thread Kevin Rushforth
On Thu, 18 Nov 2021 17:02:19 GMT, Andreas Heger wrote: >> By changing the value for the clang -arch parameter to "arm64", the jfx >> project compiles on an apple silicon system. Are there any side effects >> which I might be missing in this simple solution? > > Andreas Heger has updated the

RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue

2021-11-18 Thread John Hendrikx
This is an implementation of the proposal in https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker (@nlisker) have been working on. It's a complete implementation including good test coverage. This was based on https://github.com/openjdk/jfx/pull/434 but with a smaller

Re: RFR: 8276174: Build failure on MacBook Air (M1) in JFX component graphics [v2]

2021-11-18 Thread Kevin Rushforth
On Thu, 18 Nov 2021 17:02:19 GMT, Andreas Heger wrote: >> By changing the value for the clang -arch parameter to "arm64", the jfx >> project compiles on an apple silicon system. Are there any side effects >> which I might be missing in this simple solution? > > Andreas Heger has updated the

Re: RFR: 8276174: Build failure on MacBook Air (M1) in JFX component graphics [v2]

2021-11-18 Thread Kevin Rushforth
On Thu, 18 Nov 2021 17:02:19 GMT, Andreas Heger wrote: >> By changing the value for the clang -arch parameter to "arm64", the jfx >> project compiles on an apple silicon system. Are there any side effects >> which I might be missing in this simple solution? > > Andreas Heger has updated the

Re: RFR: 8276174: Build failure on MacBook Air (M1) in JFX component graphics

2021-11-18 Thread Andreas Heger
On Thu, 11 Nov 2021 13:37:37 GMT, Kevin Rushforth wrote: >> By changing the value for the clang -arch parameter to "arm64", the jfx >> project compiles on an apple silicon system. Are there any side effects >> which I might be missing in this simple solution? > > Did you build WebKit and media

Re: RFR: 8276174: Build failure on MacBook Air (M1) in JFX component graphics [v2]

2021-11-18 Thread Andreas Heger
> By changing the value for the clang -arch parameter to "arm64", the jfx > project compiles on an apple silicon system. Are there any side effects which > I might be missing in this simple solution? Andreas Heger has updated the pull request incrementally with one additional commit since the

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-11-18 Thread Tom Schindl
On Thu, 18 Nov 2021 00:55:18 GMT, Nir Lisker wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the number

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-11-18 Thread Marius Hanl
On Wed, 17 Nov 2021 05:34:46 GMT, Abhinay Agarwal wrote: > This work improves the performance of `MultipleSelectionModel` over large > data sets by caching some values and avoiding unnecessary calls to > `SelectedIndicesList#size`. It further improves the performance by reducing > the number