Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-12 Thread Johan Vos
t; and "Ensemble" and I > >> don't see any issue. I did some sanity testing on OL 7.5 as well > >> and things look good to me. > >> > >> Webrev: > >> http://cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.01/ > >> <http:

RE: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-12 Thread Pankaj Bansal
, October 11, 2018 9:17 PM To: Johan Vos; Pankaj Bansal Cc: openjfx-dev@openjdk.java.net Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux I used the wrong bug ID below. Here is the right one: 8189689: JavaFX build fails with gcc 6 [1] Pankaj will send

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Kevin Rushforth
java.net     <mailto:openjfx-dev@openjdk.java.net>     Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional     support for GTK 3 on Linux     I debugged this offline earlier today, and it looks related to a     collision in the glib library. As I mentioned offline, a possible    

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Kevin Rushforth
gt; Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux I debugged this offline earlier today, and it looks related to a collision in the glib library. As I mentioned offline, a possible solution is to remove RTLD_GLOBAL from the dlopen of

RE: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Pankaj Bansal
  From: Johan Vos [mailto:johan@gluonhq.com] Sent: Thursday, October 11, 2018 4:05 PM To: Pankaj Bansal Cc: Kevin Rushforth; openjfx-dev@openjdk.java.net Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux   Hi Pankaj,   What gcc version did you use

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-11 Thread Johan Vos
tober 4, 2018 7:41 AM > To: Pankaj Bansal; openjfx-dev@openjdk.java.net > Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for > GTK 3 on Linux > > I debugged this offline earlier today, and it looks related to a collision > in the glib library. As I mentione

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-10 Thread Johan Vos
> > http://cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.01/ > > > > Regards, > > Pankaj > > > > > > -Original Message- > > From: Kevin Rushforth > > Sent: Thursday, October 4, 2018 7:41 AM > > To: Pankaj Bansal; openjf

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-10 Thread Kevin Rushforth
//cr.openjdk.java.net/~pbansal/gtk3_JFX_backport/webrev.01/ Regards, Pankaj -Original Message- From: Kevin Rushforth Sent: Thursday, October 4, 2018 7:41 AM To: Pankaj Bansal; openjfx-dev@openjdk.java.net Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on

RE: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-10 Thread Pankaj Bansal
rom: Kevin Rushforth Sent: Thursday, October 4, 2018 7:41 AM To: Pankaj Bansal; openjfx-dev@openjdk.java.net Subject: Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux I debugged this offline earlier today, and it looks related to a collision in the glib library. As

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-03 Thread Kevin Rushforth
I debugged this offline earlier today, and it looks related to a collision in the glib library. As I mentioned offline, a possible solution is to remove RTLD_GLOBAL from the dlopen of the libglassgtk{2,3}.so library. I was able to do a full build / test on both GTK 2 and GTK 3 including media

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-03 Thread Kevin Rushforth
My initial testing shows a couple problems which will need to be resolved: 1) I get many GTK warnings relating to Pango when running HelloWebView 2) Running any program that uses media crashes This is on Ubuntu 16.04 LTS using the default GTK 2 mode. -- Kevin On 10/3/2018 3:26 AM, Pankaj

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-03 Thread Kevin Rushforth
Tom, I'll be sure to test SWT interop as part of my review of this fix. -- Kevin On 10/3/2018 4:00 AM, Tom Schindl wrote: Hi, While i can not comment on the change. This is really really great news for all people integrating JavaFX into SWT! Tom On 03.10.18 12:26, Pankaj Bansal wrote: Hi

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-03 Thread Tom Schindl
Hi, While i can not comment on the change. This is really really great news for all people integrating JavaFX into SWT! Tom On 03.10.18 12:26, Pankaj Bansal wrote: > Hi All, > > > > Please review the patch for 8u-dev backport for HYPERLINK >

[8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-03 Thread Pankaj Bansal
Hi All, Please review the patch for 8u-dev backport for HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8087516"JDK-8087516. It adds conditional support for gtk3. Along with the enhancement, following bug fixes have also been included in the backport webrev 1.