This PR only affects iOS native code.
JBS issue: https://bugs.openjdk.java.net/browse/JDK-8232943
Since the `IosGestureSupport` class is only instantiated from the native side,
the proposal is to change in `ios/GlassViewDelegate.m` the use of `FindClass`
in favor of `[GlassHelper
Running on MacOS Catalina, when doing static builds of `libjavafx_font.a` and
linking against this in a JavaFX app compiled with GraalVM native-image, if
default fonts are used, the rendered text is garbled, and a warning message is
printed:
CoreText note: Client requested name
In `GlassApplication.m` for iOS, the method
`Java_com_sun_glass_ui_ios_IosApplication__1leaveNestedEventLoopImpl` has
signature `(Ljava/lang/Object;)V`, however in `IosApplication.java`,
`_leaveNestedEventLoopImpl()` signature doesn't match that.
This PR fixes this.
Commits:
`GlassHelper.m` for iOS contains the public method
`ApplicationNotifyQuitMethod()`, that tries to find via reflection the
`notifyQuit()` method in the `com.sun.glass.ui.Application` class.
But the method `notifyQuit` doesn't exist in that class. However
`notifyWillQuit` exists, and it is used
There is a hardcoded limit to refresh the glass view on iOS at a half rate of
the native refresh rate.
This PR removes that limit.
Since the default value for `frameInterval ` is 1 (which implies refreshing at
the same rate as allowed by the device), doing `setFrameInterval:1` is not
This PR removes unnecessary logging of the scale value during a pinch gesture
on iOS
-
Commits:
- 2cfa3c7b: Remove unnecessary logging
Changes: https://git.openjdk.java.net/jfx/pull/131/files
Webrev: https://webrevs.openjdk.java.net/jfx/131/webrev.00
Issue:
This PR defines a pre-processor in the phong frag files to avoid inline
declaration of #extension when several frags are combined that leads to the
error:
syntax error: #extension must always be before any non-preprocessor tokens
-
Commits:
- 14ccbe6a: Define pre-processor in
This PR enables support for 3D on iOS devices, as they use OpenGL ES 2.0, which
has (limited) support for npot support.
-
Commits:
- 1bef8cf6: Enable 3D support on iOS
Changes: https://git.openjdk.java.net/jfx/pull/92/files
Webrev:
> This PR defines a pre-processor in the phong frag files to avoid inline
> declaration of #extension when several frags are combined that leads to the
> error:
>
> syntax error: #extension must always be before any non-preprocessor tokens
The pull request has been updated with 1 additional
On Fri, 31 Jan 2020 00:51:22 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/resources/com/sun/prism/es2/glsl/diffuse_color.frag
> line 32:
>
>> 31: #extension GL_OES_standard_derivatives : enable
>> 32: #define
This PR comments out too verbose console logging, as it has been done with some
other fprintf calls.
As a follow up of this PR, a custom directive that enables this output if
needed can be considered.
-
Commit messages:
- Comment out verbose logging
Changes:
There are cases when iOS sends one or more NSTouchPhaseMoved for a given touch
event, in between NSTouchPhaseBegan and
NSTouchPhaseEnded , even if the initial event location didn't change.
By default, all these events are emulated as mouse enter/down, drag and up/exit
events.
However, when the
On Mon, 11 May 2020 12:50:48 GMT, Jose Pereda wrote:
> With this PR, we pass directly the 16-bit unsigned short for a character
> (unicode value) to the Java layer, avoiding
> the cast with the C++ 8-bit char, that fails for non-ascii characters like
> euro (€) or quote (")
`VirtualFlow` makes use of `VirtualScrollBar` controls, that are laid out next
to the clipped container region, by
default.
However, when touch is supported, these scrollBars are floating controls laid
out over the container. Therefore, in
this case, when the viewport dimensions are updated,
On Wed, 6 May 2020 23:18:33 GMT, Kevin Rushforth wrote:
>> @aghaisas can you also take a look?
>
> I've asked Ajit to review it (and I presume Johan will review as well?)
>
> It looks like a safe enough fix. Have you tested it on multiple platforms?
Yes, I've tested on Mac OS and Linux (with
With this PR, we pass directly the 16-bit unsigned short for a character
(unicode value) to the Java layer, avoiding
the cast with the C++ 8-bit char, that fails for non-ascii characters like euro
(€) or quote (").
We also avoid the mapping between iOS keys and JavaFX `KeyCode`, except for
There is a visual glitch when the scrollbar controls are laid out on touch
enabled devices.
The first time they are laid out in the wrong location (20 px from right or
bottom), while the next passes are correct
(8 px from right or bottom).
The reason for this glitch is the use of `getWidth()`
On Fri, 8 May 2020 11:25:03 GMT, Jose Pereda wrote:
> There is a visual glitch when the scrollbar controls are laid out on touch
> enabled devices.
>
> The first time they are laid out in the wrong location (20 px from right or
> bottom), while the next passes are correct
>
On Wed, 13 May 2020 09:14:02 GMT, Ajit Ghaisas wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Apply code formatting
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin
fixes that, by
> using the same prefWidth/prefHeight for
> both resizing and relocating.
> It has been tested on Mac OS and Linux (with `-Dcom.sun.javafx.touch=true`),
> and on Android and iOS.
Jose Pereda has updated the pull request incrementally with one additional
commit sinc
On Tue, 5 May 2020 16:49:09 GMT, Jose Pereda wrote:
> `VirtualFlow` makes use of `VirtualScrollBar` controls, that are laid out
> next to the clipped container region, by
> default.
> However, when touch is supported, these scrollBars are floating controls laid
> out ove
Trying to paste on a JavaFX app statically built on Mac OS throws:
Exception in thread "JavaFX Application Thread" java.lang.ClassCastException
at at
com.sun.glass.ui.mac.MacPasteboard._getUTFs(MacPasteboard.java)
Checking the native method signature a `String[][]` type is
On Wed, 20 May 2020 11:47:29 GMT, Jose Pereda wrote:
> Trying to paste on a JavaFX app statically built on Mac OS throws:
>
> Exception in thread "JavaFX Application Thread" java.lang.ClassCastException
> at at
> com.sun.glass.ui.mac.MacPasteboard._g
This PR uses iOS long press gesture to generate a menu event that will trigger
a `ContextMenuEvent`.
Based on this event, input controls will show the ContextMenu (once JDK-8245499
is fixed), and if required, a developer
could add an event handler based on
As a follow-up of JDK-8245456, IosPasteboard throws a ClassCastException when
trying to paste clipboard content on iOS
devices. Same fix apply, using the correct signature.
When retrieving the UTF formats, the native method fails to create the correct
String array, as the total number of
keys
After JDK-8242167, a JavaFX control is used for text input on iOS instead of
the native control, on a touch enabled
device. However, selection handles are not enabled and currently text selection
is not possible at all.
This PR enables handles on iOS as in the rest of the platforms with touch
This PR fixes an issue that happens when adding new items to a `TableView` or
any other control that uses
`VirtualFlow`, if the scroll position is not 0: the virtual flow is slightly
shifted down.
For instance, let's say that a cell has a layoutY of -10.0. After adding a new
item to the table,
This PR removes an old fix (RT-13965/JDK-8113318), which was applied in 2011 to
avoid a memory leak in
`VirtualFlow::sheetChildren`, after new items were constantly added.
With the current VirtualFlow implementation, there are in place the necessary
methods that take care of cleaning or
adding
On Mon, 7 Sep 2020 17:54:31 GMT, Jose Pereda wrote:
> This PR fixes an issue that happens when adding new items to a `TableView` or
> any other control that uses
> `VirtualFlow`, if the scroll position is not 0: the virtual flow is slightly
> shifted down.
> For instance, let's
On Wed, 26 Aug 2020 14:08:37 GMT, dannygonzalez
wrote:
>> @hjohn, agreed regards the issues of adding a listener to each node.
>>
>> Would it be worth doing the additional work of updating PopupWindow and
>> ProgressIndicatorSkin to add their own
>> listeners to make this a pull request that
est has been included. It
> simulates the case of adding new items to the virtual flow after an initial
> scroll. It currently fails after adding a
> few items, and it passes with the changes of this PR.
Jose Pereda has updated the pull request with a new target base due to a merge
or a
On Tue, 8 Sep 2020 11:56:51 GMT, Jose Pereda wrote:
> This PR removes an old fix (RT-13965/JDK-8113318), which was applied in 2011
> to avoid a memory leak in
> `VirtualFlow::sheetChildren`, after new items were constantly added.
> With the current VirtualFlow implementation, there
On Tue, 26 May 2020 11:46:54 GMT, Ajit Ghaisas wrote:
>> Since this touches shared code, I'd like @aghaisas to look at this.
>
> Code changes look OK.
> I think, we need a note in PR description about what testing you have done
> with this fix.
I've edited the PR description with details of
On Tue, 26 May 2020 11:42:46 GMT, Ajit Ghaisas wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add new line at the end of the file
>
> modules/javafx.controls/src/ios/resources/com
f the platforms with touch
> support.
>
> It also tries to accommodate its style to the native style for handles, where
> selection handles have a circle shape and
> are a little bit bigger, and there is no caret handle.
Jose Pereda has updated the pull request incrementally wit
On Thu, 21 May 2020 17:41:02 GMT, Jose Pereda wrote:
> After JDK-8242167, a JavaFX control is used for text input on iOS instead of
> the native control, on a touch enabled
> device. However, selection handles are not enabled and currently text
> selection is not possible at al
As discussed in the [JBS
issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an
already snapped value (either intentionally or by mistake), the result should
be the same, otherwise we'll be jumping unnecessary from a valid pixel to
another pixel.
This PR provides a fix to
On Mon, 26 Oct 2020 10:03:20 GMT, Jeanette Winzenburg
wrote:
>> @kleopatra Thanks for checking.
>>
>> As discussed in the JBS issue, there is a call in
>> `CheckBoxSkin::layoutChildren` that, probably by mistake, calls `snapSizeX`
>> twice, and that gives different results when a different
On Sun, 25 Oct 2020 11:14:43 GMT, Jeanette Winzenburg
wrote:
>> The approach looks good. I'll review it early next week, and also ask
>> @arapte to review.
>
> curious: it this expected to fix the ellipsed checkBox texts? Can verify that
> the test fails/passes before/after the fix, but the
97).
> With the proposed fix, it doesn't fail at all.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Add javadoc to scaledCeil
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/336/files
- new: https://git.openjd
On Tue, 27 Oct 2020 10:16:19 GMT, Jeanette Winzenburg
wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update JBS reference in RegionTest
>
> modules/javafx.graphics/src/test
97).
> With the proposed fix, it doesn't fail at all.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Update JBS reference in RegionTest
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/336/files
- new: https://
On Tue, 27 Oct 2020 10:18:26 GMT, Jeanette Winzenburg
wrote:
>> Looks good.
>>
>> I can confirm that this fixes the problem of `snapSizeXY(snapSizeXY(val)) !=
>> snapSizeXY(val)` and that it fixes the test case from
>> [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592) when
>>
On Tue, 27 Oct 2020 10:44:00 GMT, Johan Vos wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update JBS reference in RegionTest
>
> modules/javafx.graphics/src/main/java/javafx/scene/
On Tue, 27 Oct 2020 10:50:26 GMT, Jeanette Winzenburg
wrote:
>> @kleopatra That's a good question.
>>
>> I already saw it, but given it has private/package private access in a
>> public class, simply trying to test it would imply creating a public access
>> to snapPortionXX.
>> I guess
97).
> With the proposed fix, it doesn't fail at all.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Extend fix to scaledFloor, thought the method is currently unused. No tests
will be provided.
-
Changes:
- all:
97).
> With the proposed fix, it doesn't fail at all.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Apply fix to snapPortionXX methods, extend test.
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/336/files
On Mon, 15 Jun 2020 19:38:19 GMT, Johan Vos wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Call fprintf only if pulse logging was requested
>
> modules/javafx.graphics
On Wed, 8 Apr 2020 08:37:27 GMT, Jose Pereda wrote:
> This PR comments out too verbose console logging, as it has been done with
> some other fprintf calls.
> As a follow up of this PR, a custom directive that enables this output if
> needed can be considered.
This pull request
> This PR comments out too verbose console logging, as it has been done with
> some other fprintf calls.
> As a follow up of this PR, a custom directive that enables this output if
> needed can be considered.
Jose Pereda has updated the pull request incrementally with one additi
On Mon, 15 Jun 2020 19:52:26 GMT, Jose Pereda wrote:
>> modules/javafx.graphics/src/main/native-prism-es2/ios/IOSWindowSystemInterface.m
>> line 86:
>>
>>> 85: if (pulseLoggingRequested) {
>>> 86: fprintf(stderr, "IOSWindowSystemInterfa
On Mon, 8 Jun 2020 09:24:32 GMT, Johan Vos wrote:
>> This PR uses iOS long press gesture to generate a menu event that will
>> trigger a `ContextMenuEvent`.
>>
>> Based on this event, input controls will show the ContextMenu (once
>> JDK-8245499 is fixed), and if required, a developer
>>
On Fri, 22 May 2020 11:45:25 GMT, Jose Pereda wrote:
> This PR uses iOS long press gesture to generate a menu event that will
> trigger a `ContextMenuEvent`.
>
> Based on this event, input controls will show the ContextMenu (once
> JDK-8245499 is fixed), and if required, a de
On Fri, 22 May 2020 13:00:07 GMT, Jose Pereda wrote:
> As a follow-up of JDK-8245456, IosPasteboard throws a ClassCastException when
> trying to paste clipboard content on iOS
> devices. Same fix apply, using the correct signature.
> When retrieving the UTF formats, the native
On Tue, 26 May 2020 20:17:44 GMT, Kevin Rushforth wrote:
>> It would be nice to show this debug info when javafx.pulseLogger is true,
>> and hide it when that property is false. It
>> shows interesting information about the rendering phase, so when that info
>> is requested (by enabling
> This PR comments out too verbose console logging, as it has been done with
> some other fprintf calls.
> As a follow up of this PR, a custom directive that enables this output if
> needed can be considered.
Jose Pereda has updated the pull request incrementally with one additi
On Tue, 22 Sep 2020 09:14:31 GMT, yosbits
wrote:
>> yosbits has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> I commented.
I've run SelectListView and
On Mon, 9 Nov 2020 11:34:25 GMT, Jose Pereda wrote:
> As commented in the [JBS
> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI
> scale 1.0 is used to perform initial calculations of preferred sizes of the
> scene, even if the scale has already a differen
This PR fixes a regression introduced in
[JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592), where scene
initialization was moved after updating output scales. However, in case of
embedded windows (used by `JFXPanel` or `FXCanvas`), the scene has to be
initialized before.
A test
tialized before.
>
> A test has been included. Before applying the fix, the JFXPanel is rendered
> with a garbled image, and after the fix, the rendering is correct.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Add new lin
tialized before.
>
> A test has been included. Before applying the fix, the JFXPanel is rendered
> with a garbled image, and after the fix, the rendering is correct.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision
On Tue, 8 Dec 2020 16:29:52 GMT, Jose Pereda wrote:
> This PR fixes a regression introduced in
> [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592), where scene
> initialization was moved after updating output scales. However, in case of
> embedded windows (used
This PR is a follow up of
[JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592).
When using DPI scaling levels > 1, labels of controls get truncated when they
are added to Dialogs which have an owner Window.
To fix the issue, this PR binds dialog and owner window renderScale X, Y
at the
> rendered text is `Check` when launching the dialog.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Check that the alert exists
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/369/files
- new: https
On Thu, 17 Dec 2020 16:25:05 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Check that the alert exists
>
> tests/system/src/test/java/test/javafx/scene/UI
On Thu, 17 Dec 2020 15:55:58 GMT, Jose Pereda wrote:
> This PR is a follow up of
> [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592).
>
> When using DPI scaling levels > 1, labels of controls get truncated when they
> are added to Dialogs which ha
f the scene, and no workaround is required.
>
> It also provides a system test that can be tested on Linux and Windows.
> Before applying the fix, the `Check` text of the checkboxes is rendered as
> `Che...`. With the fix, the test verifies, for a given UI scale, that the
> rendered text
On Thu, 19 Nov 2020 02:12:05 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use assertTrue instead of try-catch
>
> tests/system/src/test/java/test/javafx/scene/
On Wed, 4 Nov 2020 17:25:16 GMT, Jose Pereda wrote:
> As discussed in the JBS
> [issue](https://bugs.openjdk.java.net/browse/JDK-8177945), there are some
> inconsistencies in the use of `VirtualContainerBase::requestRebuildCells`
> from `VirtualContainerBase::updateItemCou
On Fri, 6 Nov 2020 23:33:08 GMT, Kevin Rushforth wrote:
>> As discussed in the JBS
>> [issue](https://bugs.openjdk.java.net/browse/JDK-8177945), there are some
>> inconsistencies in the use of `VirtualContainerBase::requestRebuildCells`
>> from `VirtualContainerBase::updateItemCount()`, which
his fix, as the cells are rebuilt, the pseudo-class states are clean
> and set all over again, thus the flickering.
>
> For ListView, the test rt_35395 (JDK-8091726) is updated, as now there are
> way less calls to updateItem.
Jose Pereda has updated the pull request incrementally
As commented in the [JBS
issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI scale
1.0 is used to perform initial calculations of preferred sizes of the scene,
even if the scale has already a different value (i.e 175%). As a workaround,
calling `Stage::sizeToScene` fix it,
On Fri, 23 Oct 2020 08:32:59 GMT, Jose Pereda wrote:
> As discussed in the [JBS
> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an
> already snapped value (either intentionally or by mistake), the result
> should be the same, otherwise we'll be jumping
On Wed, 4 Nov 2020 11:12:06 GMT, Johan Vos wrote:
>> Allow the EGL functionality in monocle to leverage EGL-based systems. The
>> low-level specific details about how the EGL calls should be constructed are
>> left out, and a native interface (egl_ext.h) is created that can be mapped
>> to
As discussed in the JBS
[issue](https://bugs.openjdk.java.net/browse/JDK-8177945), there are some
inconsistencies in the use of `VirtualContainerBase::requestRebuildCells` from
`VirtualContainerBase::updateItemCount()`, which is implemented in the
different skin classes for virtualised
On Wed, 4 Nov 2020 16:11:21 GMT, Johan Vos wrote:
>> Allow the EGL functionality in monocle to leverage EGL-based systems. The
>> low-level specific details about how the EGL calls should be constructed are
>> left out, and a native interface (egl_ext.h) is created that can be mapped
>> to
On Wed, 4 Nov 2020 11:12:06 GMT, Johan Vos wrote:
>> Allow the EGL functionality in monocle to leverage EGL-based systems. The
>> low-level specific details about how the EGL calls should be constructed are
>> left out, and a native interface (egl_ext.h) is created that can be mapped
>> to
On Thu, 5 Nov 2020 16:41:09 GMT, Johan Vos wrote:
>> Allow the EGL functionality in monocle to leverage EGL-based systems. The
>> low-level specific details about how the EGL calls should be constructed are
>> left out, and a native interface (egl_ext.h) is created that can be mapped
>> to
On Wed, 6 Jan 2021 17:05:09 GMT, Kevin Rushforth wrote:
>> As commented in the JBS issue, there is one single `dndGesture` object in
>> `Scene`, that can be instantiated from three different ways:
>>
>> - DropTargetListener, on dragEnter
>> - DragGestureListener, on dragGestureRecognized or
As commented in the JBS issue, there is one single `dndGesture` object in
`Scene`, that can be instantiated from three different ways:
- DropTargetListener, on dragEnter
- DragGestureListener, on dragGestureRecognized or
- MouseHandler, processing a right mouse click (these two are mutually
> that was added to the first one, avoiding the RTE.
>
> The existing manual test
> [DndTest](https://github.com/openjdk/jfx/blob/master/tests/manual/dnd/DndTest.java)
> has been used on MacOS to verify the PR.
Jose Pereda has updated the pull request incrementally with one addi
On Fri, 8 Jan 2021 16:04:53 GMT, Kevin Rushforth wrote:
>> This is really an edge case. There can be two gestures at once, an existing
>> one (i.e from TouchPad), with its full drag information, that hasn't
>> finished yet, and a new mouse one.
>>
>> Having a single `dndGesture` object for
On Wed, 6 Jan 2021 16:20:47 GMT, Jose Pereda wrote:
> As commented in the JBS issue, there is one single `dndGesture` object in
> `Scene`, that can be instantiated from three different ways:
>
> - DropTargetListener, on dragEnter
> - DragGestureListener, on dragGe
> This PR modifies the PasswordField's bullet character used on Android, as the
> current unicode code is not supported for most fonts, including Roboto.
Jose Pereda has updated the pull request incrementally with one additional
commit since the last revision:
Address feedback from re
This PR modifies the PasswordField's bullet character used on Android, as the
current unicode code is not supported for most fonts, including Roboto.
-
Commit messages:
- Modify bullet character for PasswordField on Android
Changes: https://git.openjdk.java.net/jfx/pull/537/files
On Fri, 18 Jun 2021 14:21:16 GMT, Kevin Rushforth wrote:
>> This PR modifies the PasswordField's bullet character used on Android, as
>> the current unicode code is not supported for most fonts, including Roboto.
>
>
On Fri, 18 Jun 2021 14:08:25 GMT, Jose Pereda wrote:
> This PR modifies the PasswordField's bullet character used on Android, as the
> current unicode code is not supported for most fonts, including Roboto.
This pull request has now been integrated.
Changeset: 13cffbaa
Author: Jose
On Mon, 17 May 2021 08:30:26 GMT, Ambarish Rapte wrote:
> Issue:
> When css file is added to a `Scene.getStylesheets()` of a Scene which has few
> controls in addition to a Label then css style of a different control gets
> applied to Label after Stage is hidden and shown. This is a regression
On Mon, 17 May 2021 19:35:09 GMT, Ambarish Rapte wrote:
>> Issue:
>> When css file is added to a `Scene.getStylesheets()` of a Scene which has
>> few controls in addition to a Label then css style of a different control
>> gets applied to Label after Stage is hidden and shown. This is a
This PR limits the `tableIndex` value, used by the LZWDecoder algorithm in
`GIFImageLoader2`, to avoid a potential AIOOB exception that happens on some
animated GIFs, to the maximum size of the tables used (4096).
In some occasions loading an animated GIF like the one used in the included
On Fri, 21 May 2021 13:02:14 GMT, Jose Pereda wrote:
> This PR limits the `tableIndex` value, used by the LZWDecoder algorithm in
> `GIFImageLoader2`, to avoid a potential AIOOB exception that happens on some
> animated GIFs, to the maximum size of the tables used (4096).
>
On Wed, 21 Apr 2021 10:42:04 GMT, Jose Pereda wrote:
> Both `GlassDialogs.m` for macOS and `GlassCommonDialogs.c` for Linux use UTF8
> encoding for the file names selected via native FileChooser, and this will
> fail if there are emojis in the file name.
>
> This PR uses th
On Fri, 21 May 2021 13:10:50 GMT, Kevin Rushforth wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modify test to avoid online resources
>
> modules/javafx.graphics/src/tes
to add new values in this case, and therefore,
> there is no risk in limiting the value to 4096.
>
> This PR will prevent the exception and all the frames should load. The
> included test passes now (and fails loading only 10 frames out of 44 without
> the proposed fix).
Jose Pere
On Sun, 23 May 2021 00:31:13 GMT, Nir Lisker wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modify test to avoid online resources
>
> @jperedadnr Since you're looking at this alre
On Mon, 24 May 2021 11:56:35 GMT, Jose Pereda wrote:
> ListPropertyBase::bind, SetPropertyBase::bind, MapPropertyBase::bind have a
> check on whether a different instance of the observable is the same, and this
> PR changes that to check against identity.
>
> Tests are inclu
On Fri, 4 Jun 2021 14:17:19 GMT, Johan Vos wrote:
>> Add EGL cursor implementation (Java + native) and the link to low-level
>> drivers.
>> Fix for JDK-8268120
>
> Johan Vos has updated the pull request incrementally with one additional
> commit since the last revision:
>
> address reviewer
On Thu, 3 Jun 2021 11:41:02 GMT, Johan Vos wrote:
>> Add EGL cursor implementation (Java + native) and the link to low-level
>> drivers.
>> Fix for JDK-8268120
>
> Johan Vos has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix typo after
This PR adds several resource bundles with High Contrast Scheme possible values
for several locales.
These values have been found by installing the required language packages on
Windows 10 Pro 20H2 (build 19042.985), enabling Settings->High Contrast and
finding the high contrast scheme values
ListPropertyBase::bind, SetPropertyBase::bind, MapPropertyBase::bind have a
check on whether a different instance of the observable is the same, and this
PR changes that to check against identity.
Tests are included.
-
Commit messages:
- Check against identity when binding List,
1 - 100 of 233 matches
Mail list logo
