Re: commit: ldap/tests run.in

2005-09-30 Thread Pierangelo Masarati
On Thu, 2005-09-29 at 23:54 +0200, Hallvard B Furuseth wrote: [EMAIL PROTECTED] writes: Modified Files: run.in 1.40 - 1.41 Source scripts/defines.sh _after_ the variables it uses have been set Erm, that referred to some private variables of mine:-) Oh well, the change doesn't hurt.

Updating the test suite (Was: commit: ldap/tests run.in)

2005-09-30 Thread Hallvard B Furuseth
Pierangelo Masarati writes: In any case this is mainly a hack to allow importing the project under AEGIS; I don't either like having to source defines.sh twice only to get few directories. Maybe directories should simply be set up in run and passed to defines.sh thru the environment? I

Re: Updating the test suite

2005-09-30 Thread Pierangelo Masarati
Pierangelo Masarati writes: In any case this is mainly a hack to allow importing the project under AEGIS; I don't either like having to source defines.sh twice only to get few directories. Maybe directories should simply be set up in run and passed to defines.sh thru the environment? I

Re: Updating the test suite

2005-09-30 Thread Hallvard B Furuseth
Pierangelo Masarati writes: Hallvard B Furuseth writes: * Factor a lot of code out to shell functions in defines.sh. (...) Shell functions are fairly portable now, and in any case OpenLDAP uses build/shtool which uses shell functions. (...) You seem to be fairly optimistic about this.

Re: Updating the test suite (Was: commit: ldap/tests run.in)

2005-09-30 Thread Hallvard B Furuseth
Walter Franzini writes: Hallvard B Furuseth wrote: Pierangelo Masarati writes: I suppose ./run could run the scripts by sourcing them instead: test -x $SCRIPT (. $SCRIPT) Then the clean operations at the end of ./run will never be executed. No, the () puts the script in a subprocess.

Re: Updating the test suite

2005-09-30 Thread Hallvard B Furuseth
Pierangelo Masarati writes: test040 is currently specific to back-hdb because only back-hdb supports subtree rename (it could be moved to a backend-specific add-on to test005) That's true. Though if back-newWonderfulDatabase is implemented someday and also supports subtree rename, test005

Re: Updating the test suite (Was: commit: ldap/tests run.in)

2005-09-30 Thread Howard Chu
Hallvard B Furuseth wrote: --- scripts/test021-certificate 29 Sep 2005 20:26:44 - 1.14 +++ scripts/test021-certificate 30 Sep 2005 05:32:50 - 1.15 echo Starting slapd on TCP/IP port $PORT1... +#valgrind -v --gdb-attach=yes --logfile=info --num-callers=16 --leak-check=yes

Re: Updating the test suite (Was: commit: ldap/tests run.in)

2005-09-30 Thread Hallvard B Furuseth
Howard Chu writes: I guess it would be nice to fix things so we don't have to edit the scripts and mess up our commits, but how do you set up the variables in a script that invokes slapd (or any program) multiple times, and you only want special treatment for one specific invocation? Well...

Re: Updating the test suite (Was: commit: ldap/tests run.in)

2005-09-30 Thread Howard Chu
Hallvard B Furuseth wrote: Hallvard B Furuseth writes: I'm not certain how I feel about my own suggestion here, but: Each test could give each program invocation a name which is unique for the test. Always invoke programs with a function Invoke(): Invoke NAME [--bg 'description' |

Re: commit: ldap/servers/slapd syncrepl.c

2005-09-30 Thread Howard Chu
Howard Chu wrote: The basic idea is this - on the provider, set up an accesslog DB for logging changes, in addition to the main database. Set up the syncprov overlay on the logging DB, not the main DB. Thus syncrepl will be propagating full entries as usual, but the content of those entries