Re: Handling bad cn=config updates

2007-10-15 Thread Howard Chu
Howard Chu wrote: Hallvard B Furuseth wrote: Howard Chu writes: The Modify operation has already completed though, there's nothing to return an error message to by then. I see. We do as much pre-checking as possible to validate the syntax of changes before committing them. But here you've

Re: commit: ldap/servers/slapd/back-bdb config.c

2007-10-15 Thread Pierangelo Masarati
Check DB directory validity at config time Of course, there's no guarantee the directory will exist and be writable when really needed ;) Just wanted to note it, I understand it should be considered as likely as someone running rm -rf on the database directory while slapd is running... p.

Re: commit: ldap/servers/slapd/back-bdb config.c

2007-10-15 Thread Howard Chu
Pierangelo Masarati wrote: Check DB directory validity at config time Of course, there's no guarantee the directory will exist and be writable when really needed ;) Just wanted to note it, I understand it should be considered as likely as someone running rm -rf on the database directory while

Re: Handling bad cn=config updates

2007-10-15 Thread Hallvard B Furuseth
Howard Chu wrote: Hallvard B Furuseth wrote: So let me step back a bit: I'd like slapd to send the ModifyResponse _after_ the change has taken effect (or failed to take effect). That's actually the way it has been implemented. Just that in this case, we weren't validating the olcDbDirectory

Re: Handling bad cn=config updates

2007-10-15 Thread Howard Chu
Hallvard B Furuseth wrote: Howard Chu wrote: Hallvard B Furuseth wrote: So let me step back a bit: I'd like slapd to send the ModifyResponse _after_ the change has taken effect (or failed to take effect). That's actually the way it has been implemented. Just that in this case, we weren't