Please provide a git patch. That way I don't have to piece together the
story from the email thread.
Thanks!
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale
Hi Spencer,
On Mon, 2011-06-06 at 14:09 -0700, Spencer Oliver wrote:
[...]
Just for testing have you tried disabling the working area?
If i get a chance i will run some tests tomorrow.
Thanks for reply.
Yes, disabling working area does make flash write successful. Here is
log,
flash
Hi Øyvind,Here are the patches attached.
Laurent
--- On Tue, 6/7/11, Øyvind Harboe oyvind.har...@zylin.com wrote:
From: Øyvind Harboe oyvind.har...@zylin.com
Subject: Re: [Openocd-development] Configuration file for stm32f2xxx
To: Laurent Charpentier laurent_p...@yahoo.com
Cc:
Do an interactive rebase and squash 1+3 together.
git rebase --help
git rebase -i origin/master
= move last commit up below first commit and change pick to s (for
squash).
git format-patch origin/master
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free
Hi Michael,
Am 06/06/2011 02:10 PM, schrieb Laurent Gauch:
/ Yes, this is to decouple the open and init (open the handle, init
// the associated specific layout).
/
Is there case where open is used without init, or init without open?
Actually no. But in the ft2232.c we could have the
Hi Tomek,
First, thank you for giving objective comments on the patch. Much
appreciated from you.
(Much better than the Student code galore from Peter)
Hello Laurent,
Sorry if my comment seems not meritoric, I am not mentioning about
coding style because this leaves a lot to tell in case of
Here are the configuration files for STM32F2xxx to review:
0001-Added-configuration-file-for-stm32f2xxx.patch
Description: Binary data
0002-Added-configuration-file-for-STM3220G-EVAL-board.patch
Description: Binary data
___
Openocd-development mailing
/ Please just use goto to handle errors.
//
// /*When we talk coding style with students, the first comment I have is :
// DO NEVER USE GOTO STATEMENT BUT USE IF ELSE IF ...
/
I'm afraid that's not only doing your students a disservice, but also
their future employers.
Sorry, but I prefer
Hi Andreas,
Thank you for your comment.
It doesn't build. Leftover variable no longer used.
minor issue
Apart from that it seems OK from my limited review. I could agree with the
others that it looks like a needlessly complex fix for a simple missing
free. Maybe there's a bigger picture here
/If our ft2232.c patches are not merged quickly, Amontec Team will certainly
// come with a new specific jtagkey.c API driver instead of the ft2232.c JTAG
// driver.
// The advantage with a specific Amontec JTAGkey API driver in openocd, will be
// to see our patches merged in the minute,
Laurent Gauch wrote:
First, thank you for giving objective comments on the patch.
Much appreciated from you.
(Much better than the Student code galore from Peter)
I imagine that Tomek spent a fair bit of time writing up his
comments in such a clear way.
I did not spend as much time writing my
On Tue, Jun 7, 2011 at 2:37 PM, Laurent Gauch laurent.ga...@amontec.comwrote:
Hi Andreas,
Thank you for your comment.
It doesn't build. Leftover variable no longer used.
minor issue
Apart from that it seems OK from my limited review. I could agree with the
others that it looks like a
Hello all! :-)
From all of the above posts Laurent it looks that you are trying to do
the TRANSPORT job. Please take a look at transport infrastructure. The
interface simply needs to be available for other things to work, so
there is no point in having handle ready with unusable interface. I
can
Hi!
I've investigated the remaining files a bit and... found nothing that
could still be unused inside them...
I post the patch with remaining changes, tell me what the errors are in
your build environment.
4\/3!!
From dcabbc362e50ce9c13acf71eb3516128b25d10fe Mon Sep 17 00:00:00 2001
From:
It builds with normal build options, but fails with -O3:
CFLAGS=-O3 ./configure --enable-dummy
make clean
make -s
=
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../..
-I../../src -I../../src -DPKGDATADIR=\/usr/local/share/openocd\
-I../../jimtcl -I../../jimtcl -O3 -Wall
Strike that. I pushed a fix for that -O3 warning and that
-O3 warning wasn't related to your patch.
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG
Hello world :-)
The work on SWD is almost ready. You can watch the code at [1]. This
is the source tree I am currently working on with KT-LINK interface
and STM32Primer{1,2}. After some fixes and verification its in a few
days it should be merged with OpenOCD source tree. You can already
test,
Hi Tomek,
thanks for working on SWD for OpenOCD.
This is obviously a big change and I hope that everybody on
the list understands that even if this was ready as-is it we
would have to allow plenty of time for everybody to review
this code before it goes into the master branch.
I hope that we
Sure thing Oyvind! I am working on the separate repository that is
publicly available, so anyone can take a look at the code, also the
migration using git should be possible easily. When I consider the
work is definitely finished (soon I hope), I will work on providing
small patches :-)
You may
On Tue, Jun 7, 2011 at 5:02 PM, Øyvind Harboe oyvind.har...@zylin.com wrote:
First thing I tried was to rebase your master branch on
top of origin/master and that didn't work...
Uhm, this is based on a version from March or April... and there are
also some unnecessary changes that should be
On Tue, Jun 7, 2011 at 7:05 PM, Tomek CEDRO tomek.ce...@gmail.com wrote:
On Tue, Jun 7, 2011 at 5:02 PM, Øyvind Harboe oyvind.har...@zylin.com wrote:
First thing I tried was to rebase your master branch on
top of origin/master and that didn't work...
Uhm, this is based on a version from March
Am 06/07/2011 11:23 AM, schrieb Laurent Gauch:
Hi Michael,
Am 06/06/2011 02:10 PM, schrieb Laurent Gauch:
/ Yes, this is to decouple the open and init (open the handle, init
// the associated specific layout).
/
Is there case where open is used without init, or init without open?
I've just posted new compilation od OpenOCD on my website
http://www.freddiechopin.info/index.php/en/articles/34-news/75-dostepna-nowa-rozwojowa-wersja-openocd-wreszcie
I hope to keep up the recent schedule (new compilation every two months).
BTW - is any release planed? 0.4.0 was downloaded
Nobody has stepped up to do the work of being a release
manager.
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
Merged.
Thanks!
--
Øyvind Harboe
Can Zylin Consulting help on your project?
US toll free 1-866-980-3434 / International +47 51 87 40 27
http://www.zylin.com/zy1000.html
ARM7 ARM9 ARM11 XScale Cortex
JTAG debugger and flash programmer
___
25 matches
Mail list logo
