Re: [Openocd-development] [PATCH] nand flash support for s3c64xx

2010-01-14 Thread Øyvind Harboe
On Wed, Jan 13, 2010 at 9:48 PM, Peter Korsgaard jac...@sunsite.dk wrote: Øyvind == Øyvind Harboe oyvind.har...@zylin.com writes:  Øyvind To me this patch looks reasonable. the .c file is basically a bunch  Øyvind of parameters and a few lines of code.  Øyvind Perhaps later the code could be

Re: [Openocd-development] [PATCH] nand flash support for s3c64xx

2010-01-13 Thread Peter Korsgaard
Øyvind == Øyvind Harboe oyvind.har...@zylin.com writes: Øyvind To me this patch looks reasonable. the .c file is basically a bunch Øyvind of parameters and a few lines of code. Øyvind Perhaps later the code could be refactored to share more, but Øyvind pre 0.4 I think there is something to

[Openocd-development] [PATCH] nand flash support for s3c64xx

2010-01-11 Thread Peter Korsgaard
Identical to the existing 2412/2443 support except for the base address and NFCONF value (bit 2 is reserved and should be written as 1 ref UM). Tested on a s3c6410 board, but controller is identical in 6400/6410 except for 8bit MLC ECC support in 6410 which isn't supported by the driver.

Re: [Openocd-development] [PATCH] nand flash support for s3c64xx

2010-01-11 Thread David Brownell
On Monday 11 January 2010, Peter Korsgaard wrote: Identical to the existing 2412/2443 support except for the base address and NFCONF value (bit 2 is reserved and should be written as 1 ref UM). Tested on a s3c6410 board, but controller is identical in 6400/6410 except for 8bit MLC ECC

Re: [Openocd-development] [PATCH] nand flash support for s3c64xx

2010-01-11 Thread Peter Korsgaard
David == David Brownell davi...@pacbell.net writes: Hi,  doc/openocd.texi                        |    3 ++-  src/flash/nand/Makefile.am              |    1 +  src/flash/nand/driver.c                 |    2 ++  src/flash/nand/{s3c2443.c = s3c6400.c} |   28