Re: [Openocd-development] [PATCH 2/5] ft2232: Refactor ft2232_init_*() into ft2232_initone()

2011-06-10 Thread Laurent Gauch
On Thu, Jun 9, 2011 at 10:57 PM, Andreas Fritiofson andreas.fritiofson at gmail.com https://lists.berlios.de/mailman/listinfo/openocd-development wrote: / ft2232_init really refers to init of the openocd driver, while // ft2232_init_{libftdi,ftd2xx} refers to init of the ftdi subsystem

Re: [Openocd-development] [PATCH 2/5] ft2232: Refactor ft2232_init_*() into ft2232_initone()

2011-06-10 Thread Michael Schwingen
Am 06/10/2011 09:21 AM, schrieb Laurent Gauch: Please remember guys also to properly fix the ft2232_quit() as Laurent proposed, this is also necessary to bring interface to default state on quit :-) And not only the specific layout, but the mpsse must be reseted. We have to make sure to

[Openocd-development] [PATCH 2/5] ft2232: Refactor ft2232_init_*() into ft2232_initone()

2011-06-09 Thread Peter Stuge
ft2232.c is compiled either for ftd2xx or for libftdi. The two init functions had slightly different prototypes, making it neccessary to distinguish between them not only at declaration, but also when they were being called. Since the code is only compiled for one library type we can homogenize

Re: [Openocd-development] [PATCH 2/5] ft2232: Refactor ft2232_init_*() into ft2232_initone()

2011-06-09 Thread Andreas Fritiofson
On Thu, Jun 9, 2011 at 12:25 PM, Peter Stuge pe...@stuge.se wrote: + retval = ft2232_initone(ft2232_vid[i], ft2232_pid[i], more, try_more); This is a good start, but what's with the function name?? How about ft2232_init_{device,interface,ftdilib,hardware,handle,whatever}

Re: [Openocd-development] [PATCH 2/5] ft2232: Refactor ft2232_init_*() into ft2232_initone()

2011-06-09 Thread Peter Stuge
Andreas Fritiofson wrote: + retval = ft2232_initone(ft2232_vid[i], ft2232_pid[i], more, try_more); This is a good start, but what's with the function name?? Short. And one from one device. As opposed to try to init *all* supported devices, which is what ft2232_init does.

Re: [Openocd-development] [PATCH 2/5] ft2232: Refactor ft2232_init_*() into ft2232_initone()

2011-06-09 Thread Andreas Fritiofson
On Fri, Jun 10, 2011 at 12:26 AM, Peter Stuge pe...@stuge.se wrote: Andreas Fritiofson wrote: + retval = ft2232_initone(ft2232_vid[i], ft2232_pid[i], more, try_more); This is a good start, but what's with the function name?? Short. And one from one device. As

Re: [Openocd-development] [PATCH 2/5] ft2232: Refactor ft2232_init_*() into ft2232_initone()

2011-06-09 Thread Tomek CEDRO
On Thu, Jun 9, 2011 at 10:57 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: ft2232_init really refers to init of the openocd driver, while ft2232_init_{libftdi,ftd2xx} refers to init of the ftdi subsystem including hardware (using either of the libraries). Different inits, hence one