Re: [Openocd-development] [patch/rfc 1/3] interface: define TMS sequence command

2010-01-15 Thread David Brownell
On Thursday 14 January 2010, Øyvind Harboe wrote: +struct tms_command { +       /** How many bits should be clocked out. */ +       unsigned        num_bits; +       /** The bits to clock out; the LSB is bit 0 of bits[0].  */ +       uint8_t         *bits; Tiny comment: Use

Re: [Openocd-development] [patch/rfc 1/3] interface: define TMS sequence command

2010-01-15 Thread Øyvind Harboe
On Fri, Jan 15, 2010 at 9:00 AM, David Brownell davi...@pacbell.net wrote: On Thursday 14 January 2010, Øyvind Harboe wrote: +struct tms_command { +       /** How many bits should be clocked out. */ +       unsigned        num_bits; +       /** The bits to clock out; the LSB is bit 0 of

[Openocd-development] [patch/rfc 1/3] interface: define TMS sequence command

2010-01-14 Thread David Brownell
For support of SWD we need to be able to clock out special bit sequences over TMS or SWDIO. Create this as a generic operation, not yet called by anything, which is split as usual into: - upper level abstraction ... here, jtag_add_tms_seq(); - midlayer implementation logic hooking that to the

Re: [Openocd-development] [patch/rfc 1/3] interface: define TMS sequence command

2010-01-14 Thread Øyvind Harboe
+struct tms_command { +       /** How many bits should be clocked out. */ +       unsigned        num_bits; +       /** The bits to clock out; the LSB is bit 0 of bits[0].  */ +       uint8_t         *bits; Tiny comment: Use uint32_t here, rather than 8 bits. Why 8 bits? There is no