[Openocd-development] Cleanup in target.c

2009-05-15 Thread Magnus Lundin
This is some thoughts on cleaning up target.c and specifictarget relations. It is not an architectural change, but rather about consistent use of the one we have. A very common pattern is to have something like this target_halt(target_s *target) . Some common cleanup and sanity checking .

Re: [Openocd-development] Cleanup in target.c

2009-05-15 Thread Magnus Lundin
Øyvind Harboe wrote: I think this makes sense. It is roughly along the lines of using a base class where the subclass implements the guts and the base class implements the fn called by normal users. Along the same lines, Michael Bruck was trying to find a reasonable way to reuse the

Re: [Openocd-development] Cleanup in target.c

2009-05-15 Thread Øyvind Harboe
Yes, and no. Many of these changes are only debug messages, so I would categorize them as cleanup without functional impact. So the need to be conservative is rather small here. OK. -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com