Re: [Openocd-development] Remove qP from rtos code?

2011-10-19 Thread Andreas Fritiofson
Sorry for bringing this old thread up (no pun intended). This code got a few minutes of my attention after I browsed through the clang static analysis report someone posted recently. rtos.c was one of the first in the list, and while the bug report probably was a false positive, I noticed some

Re: [Openocd-development] Remove qP from rtos code?

2011-10-19 Thread Evan Hunter
...@fritiofson.net [mailto:andr...@fritiofson.net] On Behalf Of Andreas Fritiofson Sent: Thursday, 20 October 2011 9:13 AM To: Jie Zhang Cc: Evan Hunter; Evan Hunter; openocd-development Subject: Re: [Openocd-development] Remove qP from rtos code? Sorry for bringing this old thread up (no pun intended

Re: [Openocd-development] Remove qP from rtos code?

2011-10-19 Thread Andreas Fritiofson
Hi! On Thu, Oct 20, 2011 at 12:47 AM, Evan Hunter ehun...@broadcom.com wrote: You are right ā€“ Looking at it again, the ā€œqPā€ code looks like I got halfway through implementing it, then found that I should be using qThreadExtraInfo instead. Please feel free to remove it. The only reason I

Re: [Openocd-development] Remove qP from rtos code?

2011-08-31 Thread Jie Zhang
Ping. Jie On Sat, Aug 27, 2011 at 11:01 AM, Jie Zhang jzhang...@gmail.com wrote: Hi Evan, If qThreadExtraInfo is not implemented, qP will be used. But since qThreadExtraInfo has now been implemented, qP should not be needed any more. GDB added qThreadExtraInfo more than 10 years ago. All

Re: [Openocd-development] Remove qP from rtos code?

2011-08-27 Thread Jie Zhang
Hi Evan, If qThreadExtraInfo is not implemented, qP will be used. But since qThreadExtraInfo has now been implemented, qP should not be needed any more. GDB added qThreadExtraInfo more than 10 years ago. All GDB releases since 5.0 will not send out qP packet if the stub supports qThreadExtraInfo.

[Openocd-development] Remove qP from rtos code?

2011-08-25 Thread Jie Zhang
Hi Evan, GDB manual says about qP: Don't use this packet; use the `qThreadExtraInfo' query instead (see below). Since qThreadExtraInfo is already supported in rtos.c, why qP is still needed? Regards, Jie ___ Openocd-development mailing list

Re: [Openocd-development] Remove qP from rtos code?

2011-08-25 Thread Evan Hunter
Backward compatibility is the reason - When I was testing with GDB+eclipse I found that OpenOCD received qP packets sometimes, and I think I implemented it first, before reading that same quotation you mentioned. Then when I implemented qThreadExtraInfo, I figured it was nicer to keep qP