[Openocd-development] adding checkpatch to code review on jenkins

2011-10-25 Thread Øyvind Harboe
Could someone take checkpatch for a spin and report back to the
list on if/how we should use in w/Gerrit+Jenkins review?

-- 
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] adding checkpatch to code review on jenkins

2011-10-25 Thread Spencer Oliver
On Oct 25, 2011 8:34 AM, Øyvind Harboe oyvind.har...@zylin.com wrote:

 Could someone take checkpatch for a spin and reporter back to the
 list on if/how we should use in w/Gerrit+Jenkins review?


I think it is used client side.

Spen
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] adding checkpatch to code review on jenkins

2011-10-25 Thread Øyvind Harboe
On Tue, Oct 25, 2011 at 9:48 AM, Spencer Oliver s...@spen-soft.co.uk wrote:
 On Oct 25, 2011 8:34 AM, Øyvind Harboe oyvind.har...@zylin.com wrote:

 Could someone take checkpatch for a spin and reporter back to the

 list on if/how we should use in w/Gerrit+Jenkins review?


 I think it is used client side.

It certainly can be used on the client side, but I think we should run it on
the server so as to automate the please fix whitespace nits.


-- 
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] jimtcl compile error

2011-10-25 Thread Peter Stuge
billium wrote:
 I am trying to update openocd but it fails to build:
 
 In function `Jim_Nvp_name2value_obj':
 jim-nvp.c:(.text+0xc7): undefined reference to `Jim_String'
 
 This is repeated four times for other instances of Jim_String.
 
 I am using amd64 on Gentoo, with the 999 ebuild which pulls from git.
 Anybody come across this or know what I am doing wrong?

I recall something about the nvp extension moving from jimtcl into
OpenOCD, which I think makes it impossible to package the two
packages separately. This is no good.

Basically you can't build - until at least the ebuild but
possibly also upstream has been fixed. Of course you can submit a bug
report on bugs.gentoo.org for jimtcl. Please include the full build
log, as always when reporting problems.


//Peter
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] jimtcl compile error

2011-10-25 Thread Alexander Stein
On Monday 24 October 2011 20:24:57 billium wrote:
 I am trying to update openocd but it fails to build:
 
 In function `Jim_Nvp_name2value_obj':
 jim-nvp.c:(.text+0xc7): undefined reference to `Jim_String'
 
 This is repeated four times for other instances of Jim_String.
 
 I am using amd64 on Gentoo, with the 999 ebuild which pulls from git.
 Anybody come across this or know what I am doing wrong?
 
 Incidentally there is a member of the the Nashoba Valley Photo Club
 (NVPC) called Jim

As Peter already said, something was moved from jimtcl into openocd. You need 
to recompile dev-lang/jimtcl- and openocd should compile again afterwards.

Regards,
Alexander
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


[Openocd-development] request to change the filename nor/tms470.c/.h

2011-10-25 Thread Mathias K.
Hello,


this is a request to change the filename and (later) the internal names to 
tif05.c/.h / tif05 or
something.

Background:

The TMS470R cpu from TI use the F05 Flash Module. The latest chips TMS470MF and 
TMS570 use the new
F035 Flash Module. The Flash Modules are quite different and the current naming 
is really bad to add
the new Flash Module also the flash name should not rely on the cpu name (in 
this content). I would
prefer tif05.c/.h and tif035.c/.h and for the configuration tif05 / tif035.

What do you think about it?


Regards,

Mathias
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] [PATCH] ft2232: Set PWR_RST and LOOPBACK for xds100v2

2011-10-25 Thread Mathias K.
Hello Kyle,

the patch works with the TMS570 eval. board. You should use gerrit to submit 
the patch.

Short instruction that works for me:

1.) register at http://openocd.zylin.com/ with a OPENID (you need a google or 
yahoo account (or other))
2.) create a ssl certificate and set it in your profile at gerrit and make it 
available to your
local ssh client
3.) choose a USERNAME
4.) clone the current openocd git git clone 
git://openocd.git.sourceforge.net/gitroot/openocd/openocd
5.) change the email and name in the git repo (local or global) to your 
registration set at 1.
6.) execute: git remote add review 
ssh://usern...@openocd.zylin.com:29418/openocd.git (USERNAME is
your registration USERNAME)
7.) execute: git config remote.review.push HEAD:refs/for/master
8.) execute: scp -p -P 29418 usern...@openocd.zylin.com:hooks/commit-msg 
.git/hooks/ (USERNAME is
your registration USERNAME)
9.) apply your changes again
10.) push the changes to review

Hope that i don't miss anything.


Regards,

Mathias


Am 24.10.2011 19:42, schrieb Kyle Manna:
 The CPLD on the xds100v2 expects to see a rising edge on PWR_RST to
 enable the outputs.  This patch creates that transition correctly by
 fixing the direction register for PWR_RST.
 
 THe CPLD will also loop back the data if the LOOPBACK signal is
 asserted.  Set this signal to an output and keep it clear.
 
 This was tested with a TI DM3730 Beagleboard xM.
 
 Signed-off-by: Kyle Manna kyle.ma...@fuel7.com
 ---
  src/jtag/drivers/ft2232.c |   53 
 +
  1 files changed, 39 insertions(+), 14 deletions(-)
 
 diff --git a/src/jtag/drivers/ft2232.c b/src/jtag/drivers/ft2232.c
 index 3cca26d..ceb3c0b 100644
 --- a/src/jtag/drivers/ft2232.c
 +++ b/src/jtag/drivers/ft2232.c
 @@ -3175,40 +3175,65 @@ static int flossjtag_init(void)
   return ftx232_dbus_write();
  }
  
 +/*
 + * The reference schematic from TI for the XDS100v2 has a CPLD on which opens
 + * the door for a number of different configurations
 + *
 + * Known Implementations:
 + * 
 http://processors.wiki.ti.com/images/9/93/TMS570LS20216_USB_STICK_Schematic.pdf
 + *
 + * http://processors.wiki.ti.com/index.php/XDS100 (rev2)
 + *   * CLPD logic: Rising edge to enable outputs (XDS100_PWR_RST)
 + *   * ACBUS3 to transition 0-1 (OE rising edge)
 + *   * CPLD logic: Put the EMU0/1 pins in Hi-Z:
 + *   * ADBUS5/GPIOL1 = EMU_EN = 1
 + *   * ADBUS6/GPIOL2 = EMU0 = 0
 + *   * ACBUS4/SPARE0 = EMU1 = 0
 + *   * CPLD logic: Disable loopback
 + *   * ACBUS6/SPARE2 = LOOPBACK = 0
 + */
 +#define XDS100_nEMU_EN   (15)
 +#define XDS100_nEMU0 (16)
 +
 +#define XDS100_PWR_RST   (13)
 +#define XDS100_nEMU1 (14)
 +#define XDS100_LOOPBACK  (16)
  static int xds100v2_init(void)
  {
 - low_output= 0x3A;
 - low_direction = 0x7B;
 + /* These are in the lower byte */
 + nTRST= 0x10;
 + nTRSTnOE = 0x10;
 +
 + /* These aren't actually used on 14 pin connectors */
 + /* These are in the upper byte */
 + nSRST= 0x01;
 + nSRSTnOE = 0x01;
 +
 + low_output= 0x08 | nTRST | XDS100_nEMU_EN;
 + low_direction = 0x0b | nTRSTnOE | XDS100_nEMU_EN | XDS100_nEMU0;
  
 - /* initialize low byte for jtag */
   if (ft2232_set_data_bits_low_byte(low_output,low_direction) != ERROR_OK)
   {
   LOG_ERROR(couldn't initialize FT2232 with 'xds100v2' layout);
   return ERROR_JTAG_INIT_FAILED;
   }
  
 - nTRST= 0x10;
 - nTRSTnOE = 0x0; /* not output enable for nTRST */
 - nSRST= 0x00;/* TODO: SRST is not supported yet */
 - nSRSTnOE = 0x00;/* no output enable for nSRST */
 -
 - high_output= 0x00;
 - high_direction = 0x59;
 + high_output = 0;
 + high_direction = nSRSTnOE | XDS100_LOOPBACK | XDS100_PWR_RST | 
 XDS100_nEMU1;
  
   /* initialize high byte for jtag */
   if (ft2232_set_data_bits_high_byte(high_output,high_direction) != 
 ERROR_OK)
   {
 - LOG_ERROR(couldn't initialize FT2232 with 'xds100v2' layout);
 + LOG_ERROR(couldn't put CPLD in to reset with 'xds100v2' 
 layout);
   return ERROR_JTAG_INIT_FAILED;
   }
  
 - high_output= 0x86;
 - high_direction = 0x59;
 + high_output |= XDS100_PWR_RST;
  
   /* initialize high byte for jtag */
   if (ft2232_set_data_bits_high_byte(high_output,high_direction) != 
 ERROR_OK)
   {
 - LOG_ERROR(couldn't initialize FT2232 with 'xds100v2' layout);
 + LOG_ERROR(couldn't bring CPLD out of reset with 'xds100v2' 
 layout);
   return ERROR_JTAG_INIT_FAILED;
   }
  
 -- 1.7.5.4

___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


[Openocd-development] New patch to review for openocd: 4205745 stm3220g_eval.cfg: fix CHIPNAME.

2011-10-25 Thread gerrit
This is an automated email from Gerrit.

Marti Bolivar (mboli...@leaflabs.com) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/120

-- gerrit

commit 42057451cb8ed248d28a0ac7d7f876f84234404d
Author: Marti Bolivar mboli...@leaflabs.com
Date:   Tue Oct 25 15:52:10 2011 -0400

stm3220g_eval.cfg: fix CHIPNAME.

The STM3220G-EVAL board has an STM32F207IGH6. (...H6, not ...T6).

Change-Id: Iaf3dae6830c5c0685a1dcd1588d391434bc51be7
Signed-off-by: Marti Bolivar mboli...@leaflabs.com

diff --git a/tcl/board/stm3220g_eval.cfg b/tcl/board/stm3220g_eval.cfg
index 48b57c1..4728432 100644
--- a/tcl/board/stm3220g_eval.cfg
+++ b/tcl/board/stm3220g_eval.cfg
@@ -1,4 +1,4 @@
-# STM3220G-EVAL: This is an STM32F2 eval board with a single STM32F207IGT6
+# STM3220G-EVAL: This is an STM32F2 eval board with a single STM32F207IGH6
 # (128KB) chip.
 # http://www.st.com/internet/evalboard/product/250374.jsp
 
@@ -6,6 +6,6 @@
 set WORKAREASIZE 0x2
 
 # chip name
-set CHIPNAME STM32F207IGT6
+set CHIPNAME STM32F207IGH6
 
 source [find target/stm32f2x.cfg]

-- 
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


[Openocd-development] Gerrit + Jenkins is up

2011-10-25 Thread Øyvind Harboe
We're still working on tweaking a few things, but it is up and running now.



-- 
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] [PATCH] ft2232: Set PWR_RST and LOOPBACK for xds100v2

2011-10-25 Thread Peter Stuge
Mathias K. wrote:
 2.) create a ssl certificate
 and set it in your profile at gerrit and make it available to your local ssh 
 client

SSH private key - not an SSL certificate.

See also
http://openocd.zylin.com/gitweb/?p=openocd.git;a=blob;f=HACKING


//Peter
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] [PATCH] ft2232: Set PWR_RST and LOOPBACK for xds100v2

2011-10-25 Thread Mathias K.
Ups,

sorry, this is our guideline:

http://openocd.sourceforge.net/doc/doxygen/html/index.html


Regards,

Mathias


Am 25.10.2011 22:44, schrieb Mathias K.:
 Hello,
 
 you should update 
 http://openocd.sourceforge.net/doc/doxygen/html/patchguide.html or remove this
 ugly Developer's Guide.
 
 
 Regards,
 
 Mathias
 
 
 Am 25.10.2011 22:32, schrieb Peter Stuge:
 Mathias K. wrote:
 2.) create a ssl certificate
 and set it in your profile at gerrit and make it available to your local 
 ssh client

 SSH private key - not an SSL certificate.

 See also
 http://openocd.zylin.com/gitweb/?p=openocd.git;a=blob;f=HACKING


 //Peter
 ___
 Openocd-development mailing list
 Openocd-development@lists.berlios.de
 https://lists.berlios.de/mailman/listinfo/openocd-development
 
 ___
 Openocd-development mailing list
 Openocd-development@lists.berlios.de
 https://lists.berlios.de/mailman/listinfo/openocd-development

___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


[Openocd-development] New patch to review for openocd: c9b29a7 Add configuration file for ATMEL SAM3N series.

2011-10-25 Thread gerrit
This is an automated email from Gerrit.

Jim Norris (u17...@att.net) just uploaded a new patch set to Gerrit, which you 
can find at http://openocd.zylin.com/121

-- gerrit

commit c9b29a7dfaae65a583024a1ab0b48cd7875f1d69
Author: Jim Norris u17...@att.net
Date:   Tue Oct 25 15:50:13 2011 -0500

Add configuration file for ATMEL SAM3N series.

Change-Id: Id110455ad199229920e6f38807386988c341a9c0
Signed-off-by: Jim Norris u17...@att.net

diff --git a/tcl/target/at91sam3nXX.cfg b/tcl/target/at91sam3nXX.cfg
new file mode 100644
index 000..782d8b9
--- /dev/null
+++ b/tcl/target/at91sam3nXX.cfg
@@ -0,0 +1,30 @@
+
+#
+# Configuration for Atmel's SAM3N series
+#
+
+if { [info exists CHIPNAME] } {
+   set _CHIPNAME $CHIPNAME
+} else {
+   set _CHIPNAME at91sam3n
+}
+
+if { [info exists ENDIAN] } {
+   set _ENDIAN $ENDIAN
+} else {
+   set _ENDIAN little
+}
+
+if { [info exists CPUTAPID ] } {
+   set _CPUTAPID $CPUTAPID
+} else {
+   set _CPUTAPID 0x4ba00477
+}
+
+jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id 
$_CPUTAPID
+
+set _TARGETNAME $_CHIPNAME.cpu
+target create $_TARGETNAME cortex_m3 -endian $_ENDIAN -chain-position 
$_TARGETNAME
+
+set _FLASHNAME $_CHIPNAME.flash
+flash bank flash0 at91sam3 0x0040 0 0 0 $_TARGETNAME

-- 
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


[Openocd-development] New patch to review for openocd: cc5d73e Add configuration file for ATMEL SAM3N-EK board.

2011-10-25 Thread gerrit
This is an automated email from Gerrit.

Jim Norris (u17...@att.net) just uploaded a new patch set to Gerrit, which you 
can find at http://openocd.zylin.com/122

-- gerrit

commit cc5d73ea869503e70e7cf6ce6a30bee7bf874199
Author: Jim Norris u17...@att.net
Date:   Tue Oct 25 15:52:06 2011 -0500

Add configuration file for ATMEL SAM3N-EK board.

Change-Id: I6def4f04b6f0a93b28f05eb6579bcaea7f76cb95
Signed-off-by: Jim Norris u17...@att.net

diff --git a/tcl/board/atmel_sam3n_ek.cfg b/tcl/board/atmel_sam3n_ek.cfg
new file mode 100644
index 000..2ae73eb
--- /dev/null
+++ b/tcl/board/atmel_sam3n_ek.cfg
@@ -0,0 +1,12 @@
+
+#
+# Board configuration for Atmel's SAM3N-EK
+#
+
+reset_config srst_only
+
+set CHIPNAME at91sam3n4c
+
+adapter_khz 32
+
+source [find target/at91sam3nXX.cfg]

-- 
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


[Openocd-development] New patch to review for openocd: 2d7fe5d Add flash wait state support.

2011-10-25 Thread gerrit
This is an automated email from Gerrit.

Jim Norris (u17...@att.net) just uploaded a new patch set to Gerrit, which you 
can find at http://openocd.zylin.com/123

-- gerrit

commit 2d7fe5da261bad5008d163d472933c6603ad6505
Author: Jim Norris u17...@att.net
Date:   Tue Oct 25 16:05:26 2011 -0500

Add flash wait state support.

Change-Id: I477446f9bfb3e910ea3e2414a6e9a75beb14a214
Signed-off-by: Jim Norris u17...@att.net

diff --git a/src/flash/nor/at91sam3.c b/src/flash/nor/at91sam3.c
index c46829e..1421221 100644
--- a/src/flash/nor/at91sam3.c
+++ b/src/flash/nor/at91sam3.c
@@ -22,6 +22,20 @@
  *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA. *
 /
 
+/*
+ * Quirks ...
+ *
+ * AT91SAM3N Series Silicon (SILICON BUG - AT91SAM3N - flash wait state)
+ * The datasheet errate (04-Oct-2010) states for flash writes the
+ * flash wait state (FWS) must be set to a value of 6. It also 
appears
+ * the wait state should be set for reads as well!
+ *
+ * AT91SAM3S Series Silicon (SILICON BUG - AT91SAM3S - flash wait state)
+ * The datasheet errate (09-Feb-2011) states for flash writes the
+ * flash wait state (FWS) must be set to a value of 6. It also 
appears
+ * the wait state should be set for reads as well!
+ */
+
 /* Some of the the lower level code was based on code supplied by
  * ATMEL under this copyright. */
 
@@ -100,6 +114,11 @@
 #define  offset_EFC_FSR   8
 #define  offset_EFC_FRR   12
 
+typedef enum {
+   AT91SAM3N,
+   AT91SAM3S,
+   AT91SAM3U
+} sam3_series;
 
 extern struct flash_driver at91sam3_flash;
 
@@ -200,6 +219,7 @@ struct sam3_chip_details {
// 'runtime' copy of this structure
uint32_t chipid_cidr;
const char *name;
+   sam3_series series;
 
unsigned n_gpnvms;
 #define SAM3_N_NVM_BITS 3
@@ -207,6 +227,7 @@ struct sam3_chip_details {
unsigned  total_flash_size;
unsigned  total_sram_size;
unsigned  n_banks;
+   uint8_t   flash_wait;
 #define SAM3_MAX_FLASH_BANKS 2
// these are initialized from the global const data
struct sam3_bank_private bank[SAM3_MAX_FLASH_BANKS];
@@ -269,10 +290,12 @@ static const struct sam3_chip_details all_sam3_details[] 
= {
{
.chipid_cidr= 0x28100960,
.name   = at91sam3u4e,
+   .series = AT91SAM3U,
.total_flash_size = 256 * 1024,
.total_sram_size  = 52 * 1024,
.n_gpnvms   = 3,
.n_banks= 2,
+   .flash_wait = 0,
 
// System boots at address 0x0
// gpnvm[1] = selects boot code
@@ -325,10 +348,12 @@ static const struct sam3_chip_details all_sam3_details[] 
= {
{
.chipid_cidr= 0x281a0760,
.name   = at91sam3u2e,
+   .series = AT91SAM3U,
.total_flash_size = 128 * 1024,
.total_sram_size  =  36 * 1024,
.n_gpnvms   = 2,
.n_banks= 1,
+   .flash_wait = 0,
 
// System boots at address 0x0
// gpnvm[1] = selects boot code
@@ -364,10 +389,12 @@ static const struct sam3_chip_details all_sam3_details[] 
= {
{
.chipid_cidr= 0x28190560,
.name   = at91sam3u1e,
+   .series = AT91SAM3U,
.total_flash_size = 64 * 1024,
.total_sram_size  = 20 * 1024,
.n_gpnvms   = 2,
.n_banks= 1,
+   .flash_wait = 0,
 
// System boots at address 0x0
// gpnvm[1] = selects boot code
@@ -407,10 +434,12 @@ static const struct sam3_chip_details all_sam3_details[] 
= {
{
.chipid_cidr= 0x28000960,
.name   = at91sam3u4c,
+   .series = AT91SAM3U,
.total_flash_size = 256 * 1024,
.total_sram_size  = 52 * 1024,
.n_gpnvms   = 3,
.n_banks= 2,
+   .flash_wait = 0,
 
// System boots at address 0x0
// gpnvm[1] = selects boot code
@@ -462,10 +491,12 @@ static const struct sam3_chip_details all_sam3_details[] 
= {
{
.chipid_cidr= 0x280a0760,
.name   = at91sam3u2c,
+   .series = AT91SAM3U,
.total_flash_size = 128 * 1024,
.total_sram_size  = 36 * 1024,
.n_gpnvms   = 2,
.n_banks= 1,
+   .flash_wait = 0,
 

[Openocd-development] git gui

2011-10-25 Thread jim norris


For those using a git gui, what are you using?
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


[Openocd-development] git question.....

2011-10-25 Thread jim norris


I do the following...


git add file1.c
git commit file1.c
git push review

git add file2.c
git commit file2.c
git push review

git add file3.c
git commit file3.c
git push review

I then realize I made a mistake in file1.c so...

-- make the change
git add file1.c
git commit --amend file1.c

However, the comment message I see when I do the commit is
from the commit of file3.c. Is this okay? Or did I do something
wrong? I've noticed there's a -C option that indicates to pick
up information from a previous commit. Is that what should be
used?


___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] git gui

2011-10-25 Thread Austin, Alex
I actually use git gui. It's not quite as slick as some other
options, but it has a lot of functionality in it.

 -Original Message-
 From: openocd-development-boun...@lists.berlios.de [mailto:openocd-
 development-boun...@lists.berlios.de] On Behalf Of Peter Stuge
 Sent: Tuesday, October 25, 2011 7:13 PM
 To: openocd-development@lists.berlios.de
 Subject: Re: [Openocd-development] git gui
 
 jim norris wrote:
  For those using a git gui, what are you using?
 
 On which system?
 
 For Windows, there is Git Extensions and TortoiseGit. The Git
 Extensions looked less slick than TortoiseGit last time I looked, but
 TortoisGit on the other hand lacked fundamental functionality.
 
 For Mac, there is GitX which is kinda nice, but also did not have
 enough functionality last time I looked. There was some payware which
 looked nice, but I didn't try it and don't recall the name.
 
 I find that using the CLI is by far the easiest, and all features are
 available.
 
 
 //Peter
 ___
 Openocd-development mailing list
 Openocd-development@lists.berlios.de
 https://lists.berlios.de/mailman/listinfo/openocd-development
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] git question.....

2011-10-25 Thread Christopher Harvey

On 25/10/11 07:57 PM, jim norris wrote:


I do the following...


git add file1.c
git commit file1.c
git push review

git add file2.c
git commit file2.c
git push review

git add file3.c
git commit file3.c
git push review

I then realize I made a mistake in file1.c so...

-- make the change
git add file1.c
git commit --amend file1.c

However, the comment message I see when I do the commit is
from the commit of file3.c. Is this okay? Or did I do something
wrong? I've noticed there's a -C option that indicates to pick
up information from a previous commit. Is that what should be
used?



afaik you can only change the last commit with amend. You'd need to do a 
commit like normal for the last file1.c change, then rebase all the (4) 
commits interactively and merge the last and 1st onesbut then again 
this wouldn't be the first time somebody pointed out to me some easier 
way to do the same thing with git.

___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] git question.....

2011-10-25 Thread Austin, Alex
Does file3 rely on file2, which relies on file1, or are they all
independent? If they're a sequence, then

git checkout -b temp HEAD~2
edit file1.c
git add file1.c
git commit --amend
git checkout original branch
git rebase temp
git push review

You don't need to do individual pushes for each commit, as the
sequence of commits leading up to the head of the branch off of trunk
will create a sequence of patches in Gerrit.

 -Original Message-
 From: openocd-development-boun...@lists.berlios.de [mailto:openocd-
 development-boun...@lists.berlios.de] On Behalf Of jim norris
 Sent: Tuesday, October 25, 2011 6:58 PM
 To: Openocd-development@lists.berlios.de
 Subject: [Openocd-development] git question.
 
 
 I do the following...
 
 
  git add file1.c
  git commit file1.c
  git push review
 
  git add file2.c
  git commit file2.c
  git push review
 
  git add file3.c
  git commit file3.c
  git push review
 
 I then realize I made a mistake in file1.c so...
 
  -- make the change
  git add file1.c
  git commit --amend file1.c
 
 However, the comment message I see when I do the commit is
 from the commit of file3.c. Is this okay? Or did I do something
 wrong? I've noticed there's a -C option that indicates to pick
 up information from a previous commit. Is that what should be
 used?
 
 
 ___
 Openocd-development mailing list
 Openocd-development@lists.berlios.de
 https://lists.berlios.de/mailman/listinfo/openocd-development
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] git question.....

2011-10-25 Thread Austin, Alex
Oh, that should be git rebase -I temp and remove the pick line for
the original commit, so that its replacement will be there instead.

 -Original Message-
 From: openocd-development-boun...@lists.berlios.de [mailto:openocd-
 development-boun...@lists.berlios.de] On Behalf Of Austin, Alex
 Sent: Tuesday, October 25, 2011 8:28 PM
 To: jim norris; Openocd-development@lists.berlios.de
 Subject: Re: [Openocd-development] git question.
 
 Does file3 rely on file2, which relies on file1, or are they all
 independent? If they're a sequence, then
 
   git checkout -b temp HEAD~2
   edit file1.c
   git add file1.c
   git commit --amend
   git checkout original branch
   git rebase temp
   git push review
 
 You don't need to do individual pushes for each commit, as the
 sequence of commits leading up to the head of the branch off of trunk
 will create a sequence of patches in Gerrit.
 
  -Original Message-
  From: openocd-development-boun...@lists.berlios.de [mailto:openocd-
  development-boun...@lists.berlios.de] On Behalf Of jim norris
  Sent: Tuesday, October 25, 2011 6:58 PM
  To: Openocd-development@lists.berlios.de
  Subject: [Openocd-development] git question.
 
 
  I do the following...
 
 
   git add file1.c
   git commit file1.c
   git push review
 
   git add file2.c
   git commit file2.c
   git push review
 
   git add file3.c
   git commit file3.c
   git push review
 
  I then realize I made a mistake in file1.c so...
 
   -- make the change
   git add file1.c
   git commit --amend file1.c
 
  However, the comment message I see when I do the commit is
  from the commit of file3.c. Is this okay? Or did I do something
  wrong? I've noticed there's a -C option that indicates to pick
  up information from a previous commit. Is that what should be
  used?
 
 
  ___
  Openocd-development mailing list
  Openocd-development@lists.berlios.de
  https://lists.berlios.de/mailman/listinfo/openocd-development
 ___
 Openocd-development mailing list
 Openocd-development@lists.berlios.de
 https://lists.berlios.de/mailman/listinfo/openocd-development
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


[Openocd-development] New patch to review for openocd: 75885f4 Add configuration for ATMEL SAM3N series.

2011-10-25 Thread gerrit
This is an automated email from Gerrit.

Jim Norris (u17...@att.net) just uploaded a new patch set to Gerrit, which you 
can find at http://openocd.zylin.com/124

-- gerrit

commit 75885f412340321dac7d89edb3edcaefe9902d18
Author: Jim Norris u17...@att.net
Date:   Tue Oct 25 20:48:35 2011 -0500

Add configuration for ATMEL SAM3N series.

Change-Id: Iac498ab37e59127b989f29a1c4167ab29d625b05
Signed-off-by: Jim Norris u17...@att.net

diff --git a/tcl/target/at91sam3nXX.cfg b/tcl/target/at91sam3nXX.cfg
new file mode 100644
index 000..29c5ddc
--- /dev/null
+++ b/tcl/target/at91sam3nXX.cfg
@@ -0,0 +1,24 @@
+
+#
+# Configuration for Atmel's SAM3N series
+#
+
+if { [info exists CHIPNAME] } {
+   set _CHIPNAME $CHIPNAME
+} else {
+   set _CHIPNAME at91sam3n
+}
+
+if { [info exists CPUTAPID ] } {
+   set _CPUTAPID $CPUTAPID
+} else {
+   set _CPUTAPID 0x4ba00477
+}
+
+jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id 
$_CPUTAPID
+
+set _TARGETNAME $_CHIPNAME.cpu
+target create $_TARGETNAME cortex_m3 -endian $_ENDIAN -chain-position 
$_TARGETNAME
+
+set _FLASHNAME $_CHIPNAME.flash
+flash bank flash0 at91sam3 0x0040 0 0 0 $_TARGETNAME

-- 
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


[Openocd-development] New patch to review for openocd: 8fe27c6 Add configuration for ATMEL SAM3N-EK board.

2011-10-25 Thread gerrit
This is an automated email from Gerrit.

Jim Norris (u17...@att.net) just uploaded a new patch set to Gerrit, which you 
can find at http://openocd.zylin.com/125

-- gerrit

commit 8fe27c6b570eec0fc0ae92c5c880ecab8f2babc7
Author: Jim Norris u17...@att.net
Date:   Tue Oct 25 20:49:12 2011 -0500

Add configuration for ATMEL SAM3N-EK board.

Change-Id: I525f6c346cace4e54f47659c5a7aceb29ee4baf2
Signed-off-by: Jim Norris u17...@att.net

diff --git a/tcl/board/atmel_sam3n_ek.cfg b/tcl/board/atmel_sam3n_ek.cfg
new file mode 100644
index 000..2ae73eb
--- /dev/null
+++ b/tcl/board/atmel_sam3n_ek.cfg
@@ -0,0 +1,12 @@
+
+#
+# Board configuration for Atmel's SAM3N-EK
+#
+
+reset_config srst_only
+
+set CHIPNAME at91sam3n4c
+
+adapter_khz 32
+
+source [find target/at91sam3nXX.cfg]

-- 
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


[Openocd-development] Does openocd support cortex A5?

2011-10-25 Thread Richard LIU
Best Regards
Richard LIU
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] git gui

2011-10-25 Thread Øyvind Harboe
On Wed, Oct 26, 2011 at 2:12 AM, Peter Stuge pe...@stuge.se wrote:
 jim norris wrote:
 For those using a git gui, what are you using?

 On which system?

 For Windows, there is Git Extensions and TortoiseGit. The Git
 Extensions looked less slick than TortoiseGit last time I looked, but
 TortoisGit on the other hand lacked fundamental functionality.

I recommend Gerrit. Gerrit makes a lot of the nastier concepts,
like interactive rebasing and communication easier.

From my experience TortoiseGit is a step down the wrong path.

It makes things easier than possible, i.e. it tosses hard concepts
out of the window. Where is the interactive rebase functionality?

I find that Eclipse EGit is starting to become useful and there is a
lot of development push on EGit.




-- 
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development


Re: [Openocd-development] git question.....

2011-10-25 Thread Øyvind Harboe
Use interactive rebasing:

git rebase --help

When you're done rebasing, just type git push review and all the updated
patches will be updated in gerrit.

-- 
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development