[Openocd-development] [PATCH] debug: debug entry error propagation

2010-07-19 Thread Øyvind Harboe
Signed-off-by: Øyvind Harboe oyvind.har...@zylin.com --- src/target/arm11.c |2 +- src/target/arm720t.c | 22 ++- src/target/arm7_9_common.c | 14 ++-- src/target/arm7_9_common.h |2 +- src/target/arm920t.c | 48

Re: [Openocd-development] [PATCH] debug: debug entry error propagation

2010-07-19 Thread Andreas Fritiofson
Considering the huge number of identical if (retval != ERROR_OK) return retval; added in this and your other patches, maybe we should reuse the CHECK_RETVAL macro from arm11.h as a general mechanism to reduce the clutter? It may not be the best of practices to return from a macro, but rules are

Re: [Openocd-development] [PATCH] debug: debug entry error propagation

2010-07-19 Thread Øyvind Harboe
On Mon, Jul 19, 2010 at 9:56 PM, Andreas Fritiofson andreas.fritiof...@gmail.com wrote: Considering the huge number of identical if (retval != ERROR_OK) return retval; added in this and your other patches, maybe we should reuse the CHECK_RETVAL macro from arm11.h as a general mechanism to