Re: [Openocd-development] JimTCL and Fedora RPMs

2011-12-15 Thread Spencer Oliver 
On 15 December 2011 05:44, Dean Glazeski dngl...@gmail.com wrote:
 Hey guys,

 Long time no see.  Recently, I got a bug request through Red Hat bugs to
 package the newer version of OpenOCD for Fedora.  It's been a while, but it
 finally kicked me in gear to take care of it (seeing as 0.5.0 was released
 quite a while ago).

 As I was working on the package, I noticed some issues with the compiler and
 tools detection in JimTCL.  Most importantly, it doesn't check for just the
 tool name, ie 'ld', if host and/or build are set in the configure line.  In
 my case, rpmbuild likes to set these options, but it isn't really a cross
 compile job (although it may be once I request a build in Fedora's systems).

 At any rate, I've attached the patch (perhaps kludge) that I'm using in the
 build to make JimTCL build properly.  I'm going to hold the RPM until I get
 word from you guys about whether this is a bug or if I should be posting
 this to another mailing list.

 Also, rpmlint picked up that the FSF address in your COPYING file is
 incorrect.  Patch attached as well.

 // Dean Glazeski


Thanks,

The jimtcl tweaks i will forward onto Steve for comment.

Cheers
Spen
--- jimtcl/autosetup/cc.tcl.bak	2011-12-14 20:54:36.612369362 -0600
+++ jimtcl/autosetup/cc.tcl	2011-12-14 21:15:43.173535171 -0600
@@ -240,7 +240,10 @@
 		set TOOL [string toupper $tool]
 		set exe [get-env $TOOL [get-define cross]$tool]
 		if {![find-executable $exe]} {
-			user-error Failed to find $exe
+set exe $tool
+if {![find-executable $exe]} {
+			user-error Failed to find $exe
+}
 		}
 		define $TOOL $exe
 	}
@@ -620,7 +623,7 @@
 	set try [list [get-env CC ]]
 } else {
 	# Try some reasonable options
-	set try [list [get-define cross]cc [get-define cross]gcc]
+	set try [list [get-define cross]cc [get-define cross]gcc cc gcc]
 }
 define CC [find-an-executable {*}$try]
 if {[get-define CC] eq } {
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

[Openocd-development] JimTCL and Fedora RPMs

2011-12-14 Thread Dean Glazeski 
Hey guys,

Long time no see.  Recently, I got a bug request through Red Hat bugs to
package the newer version of OpenOCD for Fedora.  It's been a while, but it
finally kicked me in gear to take care of it (seeing as 0.5.0 was released
quite a while ago).

As I was working on the package, I noticed some issues with the compiler
and tools detection in JimTCL.  Most importantly, it doesn't check for just
the tool name, ie 'ld', if host and/or build are set in the configure
line.  In my case, rpmbuild likes to set these options, but it isn't really
a cross compile job (although it may be once I request a build in Fedora's
systems).

At any rate, I've attached the patch (perhaps kludge) that I'm using in the
build to make JimTCL build properly.  I'm going to hold the RPM until I get
word from you guys about whether this is a bug or if I should be posting
this to another mailing list.

Also, rpmlint picked up that the FSF address in your COPYING file is
incorrect.  Patch attached as well.

// Dean Glazeski
--- COPYING.orig	2011-12-14 21:41:38.679088677 -0600
+++ COPYING	2011-12-14 21:42:14.742637819 -0600
@@ -2,7 +2,7 @@
 		   Version 2, June 1991
 
  Copyright (C) 1989, 1991 Free Software Foundation, Inc.
-   59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
  Everyone is permitted to copy and distribute verbatim copies
  of this license document, but changing it is not allowed.
 
--- jimtcl/autosetup/cc.tcl.bak	2011-12-14 20:54:36.612369362 -0600
+++ jimtcl/autosetup/cc.tcl	2011-12-14 21:15:43.173535171 -0600
@@ -240,7 +240,10 @@
 		set TOOL [string toupper $tool]
 		set exe [get-env $TOOL [get-define cross]$tool]
 		if {![find-executable $exe]} {
-			user-error Failed to find $exe
+set exe $tool
+if {![find-executable $exe]} {
+			user-error Failed to find $exe
+}
 		}
 		define $TOOL $exe
 	}
@@ -620,7 +623,7 @@
 	set try [list [get-env CC ]]
 } else {
 	# Try some reasonable options
-	set try [list [get-define cross]cc [get-define cross]gcc]
+	set try [list [get-define cross]cc [get-define cross]gcc cc gcc]
 }
 define CC [find-an-executable {*}$try]
 if {[get-define CC] eq } {
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] JimTCL and Fedora RPMs

2011-12-14 Thread Øyvind Harboe 
Please read latest HACKING and push to gerrit for review.

Thanks!



-- 
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development