[openssl-dev] [openssl.org #4674] Openssl 1.1.0 passwd bug & feature request

2016-09-14 Thread Richard Levitte via RT
And finally got committed to master, with all suggested fixups. Closing this ticket. Cheers, Richard On Wed Sep 14 02:09:15 2016, levitte wrote: > Issue 2 is implemented in https://github.com/openssl/openssl/pull/1572 > > Please try it out. > > Cheers, > Richard > > On Tue Sep 13 22:32:37 2016,

[openssl-dev] [openssl.org #4674] Openssl 1.1.0 passwd bug & feature request

2016-09-13 Thread Richard Levitte via RT
Done! On Wed Sep 14 03:16:11 2016, bkhow...@gmail.com wrote: > Richard, > I had taken a crack at this and got to the point of actually > needing > sha2crypt(). I compared your changes to mine, which is all pretty > predictable so matched line by line. The only exception is 203, which > is >

[openssl-dev] [openssl.org #4674] Openssl 1.1.0 passwd bug & feature request

2016-09-13 Thread Richard Levitte via RT
Those test vectors are already in test/recipes/20-test_passwd.t On Wed Sep 14 02:58:09 2016, bkhow...@gmail.com wrote: > Thanks Richard, > Quick work on issue 1, I git cloned & tested it, works as > expected. > I downloaded the pull above, built it and it appears to work. > > I found test vectors

Re: [openssl-dev] [openssl.org #4674] Openssl 1.1.0 passwd bug & feature request

2016-09-13 Thread Brian Howson via RT
Richard, I had taken a crack at this and got to the point of actually needing sha2crypt(). I compared your changes to mine, which is all pretty predictable so matched line by line. The only exception is 203, which is because it's entirely redundant as the max_pwlen defaults to 256. So

Re: [openssl-dev] [openssl.org #4674] Openssl 1.1.0 passwd bug & feature request

2016-09-13 Thread Brian Howson via RT
Thanks Richard, Quick work on issue 1, I git cloned & tested it, works as expected. I downloaded the pull above, built it and it appears to work. I found test vectors in the specification document here: https://www.akkadia.org/drepper/sha-crypt.html openssl passwd -5 -salt

[openssl-dev] [openssl.org #4674] Openssl 1.1.0 passwd bug & feature request

2016-09-13 Thread Richard Levitte via RT
Issue 2 is implemented in https://github.com/openssl/openssl/pull/1572 Please try it out. Cheers, Richard On Tue Sep 13 22:32:37 2016, levitte wrote: > Issue 1 now resolved, fix pushed to master branch as well as > OpenSSL_1_1_0-stable. > > Issue 2 remaining. > > Cheers, > Richard > > On Tue

[openssl-dev] [openssl.org #4674] Openssl 1.1.0 passwd bug & feature request

2016-09-13 Thread Richard Levitte via RT
Issue 1 now resolved, fix pushed to master branch as well as OpenSSL_1_1_0-stable. Issue 2 remaining. Cheers, Richard On Tue Sep 13 20:32:18 2016, levitte wrote: > I can confirm issue one and raise you one: it's not just on Windows > > On it. > > Cheers, > Richard > > On Tue Sep 13 17:23:48

[openssl-dev] [openssl.org #4674] Openssl 1.1.0 passwd bug & feature request

2016-09-13 Thread Richard Levitte via RT
A note for the future: since this is really two issues, they should be one ticket each. I'll let this one slip by, 'cause it's relatively simple to fix both. However, please understand that while issue 1 will be fixed in OpenSSL 1.1.0a, issue 2 will not appear before OpenSSL 1.1.1. Cheers,

[openssl-dev] [openssl.org #4674] Openssl 1.1.0 passwd bug & feature request

2016-09-13 Thread Richard Levitte via RT
I can confirm issue one and raise you one: it's not just on Windows On it. Cheers, Richard On Tue Sep 13 17:23:48 2016, bkhow...@gmail.com wrote: > This may be two requests, one a bug and one a feature request. > > Issue 1: openssl 1.1.0 passwd on Windows 64 doesn't generate MD5 passwords > (-1

[openssl-dev] [openssl.org #4674] Openssl 1.1.0 passwd bug & feature request

2016-09-13 Thread Brian Howson via RT
This may be two requests, one a bug and one a feature request. Issue 1: openssl 1.1.0 passwd on Windows 64 doesn't generate MD5 passwords (-1 / -apr1), returns "". I haven't tested other platforms. See output below. Issue 2: openssl 1.1.0 passwd doesn't support newer password hashing