Re: [openssl.org #3490] bug report: SRP still broken in 1.0.1 snapshot

2014-08-13 Thread John Foley
The first chunk in the s3_lib.c patch doesn't apply. But the second chunk does (shown below). When applying this to 1.0.1 stable, it appears to resolve the problem. @@ -4357,8 +4359,13 @@ SSL_CIPHER *ssl3_choose_cipher(SSL *s, STACK_OF(SSL_CIPHER) *clnt, emask_k =

Re: [openssl.org #3490] bug report: SRP still broken in 1.0.1 snapshot

2014-08-13 Thread Kurt Roeckx via RT
On Tue, Aug 12, 2014 at 08:36:06PM +0200, Kurt Roeckx wrote: On Tue, Aug 12, 2014 at 08:22:38PM +0200, John Foley via RT wrote: The first chunk in the s3_lib.c patch doesn't apply. But the second chunk does (shown below). When applying this to 1.0.1 stable, it appears to resolve the

Re: [openssl.org #3490] bug report: SRP still broken in 1.0.1 snapshot

2014-08-13 Thread John Foley via RT
Thank you. On 08/13/2014 01:39 PM, Kurt Roeckx via RT wrote: On Tue, Aug 12, 2014 at 08:36:06PM +0200, Kurt Roeckx wrote: On Tue, Aug 12, 2014 at 08:22:38PM +0200, John Foley via RT wrote: The first chunk in the s3_lib.c patch doesn't apply. But the second chunk does (shown below). When

Re: [openssl.org #3490] bug report: SRP still broken in 1.0.1 snapshot

2014-08-13 Thread John Foley
Thank you. On 08/13/2014 01:39 PM, Kurt Roeckx via RT wrote: On Tue, Aug 12, 2014 at 08:36:06PM +0200, Kurt Roeckx wrote: On Tue, Aug 12, 2014 at 08:22:38PM +0200, John Foley via RT wrote: The first chunk in the s3_lib.c patch doesn't apply. But the second chunk does (shown below). When

Re: [openssl.org #3490] bug report: SRP still broken in 1.0.1 snapshot

2014-08-12 Thread Kurt Roeckx via RT
On Tue, Aug 12, 2014 at 01:26:30AM +0200, John Foley via RT wrote: The commit into 1.0.1 didn't include the changes to s3_lib.c. SRP is still broken on this branch. Are there any plans to fix this? Can you confirm that that commit from master fixes things for you? On Aug 11, 2014, at

Re: [openssl.org #3490] bug report: SRP still broken in 1.0.1 snapshot

2014-08-12 Thread John Foley via RT
The first chunk in the s3_lib.c patch doesn't apply. But the second chunk does (shown below). When applying this to 1.0.1 stable, it appears to resolve the problem. @@ -4357,8 +4359,13 @@ SSL_CIPHER *ssl3_choose_cipher(SSL *s, STACK_OF(SSL_CIPHER) *clnt, emask_k =

Re: [openssl.org #3490] bug report: SRP still broken in 1.0.1 snapshot

2014-08-12 Thread Kurt Roeckx
On Tue, Aug 12, 2014 at 08:22:38PM +0200, John Foley via RT wrote: The first chunk in the s3_lib.c patch doesn't apply. But the second chunk does (shown below). When applying this to 1.0.1 stable, it appears to resolve the problem. @@ -4357,8 +4359,13 @@ SSL_CIPHER *ssl3_choose_cipher(SSL

[openssl.org #3490] bug report: SRP still broken in 1.0.1 snapshot

2014-08-11 Thread John Foley via RT
The fix discussed in this thread appears to be incomplete: http://marc.info/?l=openssl-usersm=140752401023837w=2 This fix works for SRP cipher suites that uses RSA for DSA, which includes 6 of the 9 supported SRP cipher suites. But the three SRP cipher suites that don't rely on a server-side

Re: [openssl.org #3490] bug report: SRP still broken in 1.0.1 snapshot

2014-08-11 Thread Kurt Roeckx via RT
On Mon, Aug 11, 2014 at 11:09:51PM +0200, John Foley via RT wrote: The fix discussed in this thread appears to be incomplete: http://marc.info/?l=openssl-usersm=140752401023837w=2 This fix works for SRP cipher suites that uses RSA for DSA, which includes 6 of the 9 supported SRP cipher

Re: [openssl.org #3490] bug report: SRP still broken in 1.0.1 snapshot

2014-08-11 Thread John Foley via RT
The commit into 1.0.1 didn't include the changes to s3_lib.c. SRP is still broken on this branch. Are there any plans to fix this? On Aug 11, 2014, at 6:41 PM, Kurt Roeckx via RT r...@openssl.org wrote: On Mon, Aug 11, 2014 at 11:09:51PM +0200, John Foley via RT wrote: The fix discussed