Re: Random number generator, uninitialised data and valgrind.

2006-05-02 Thread Marco Roeland
On Tuesday May 2nd 2006 at 00:34 Ulf Möller wrote: Not much. If it helps with debugging, I'm in favor of removing them. (However the last time I checked, valgrind reported thousands of bogus error messages. Has that situation gotten better?) I recently compiled vanilla OpenSSL 0.9.8a with

Re: Random number generator, uninitialised data and valgrind.

2006-05-02 Thread Kurt Roeckx
On Tue, May 02, 2006 at 12:34:12AM +0200, Ulf Möller wrote: Kurt Roeckx schrieb: What I currently see as best option is to actually comment out those 2 lines of code. But I have no idea what effect this really has on the RNG. The only effect I see is that the pool might receive less

Re: Random number generator, uninitialised data and valgrind.

2006-05-02 Thread Kurt Roeckx
On Tue, May 02, 2006 at 08:08:10AM +0200, Marco Roeland wrote: On Tuesday May 2nd 2006 at 00:34 Ulf Möller wrote: Not much. If it helps with debugging, I'm in favor of removing them. (However the last time I checked, valgrind reported thousands of bogus error messages. Has that

Random number generator, uninitialised data and valgrind.

2006-05-01 Thread Kurt Roeckx
Hi, When debbuging applications that make use of openssl using valgrind, it can show alot of warnings about doing a conditional jump based on an unitialised value. Those unitialised values are generated in the random number generator. It's adding an unintialiased buffer to the pool. The code

Re: Random number generator, uninitialised data and valgrind.

2006-05-01 Thread Ulf Möller
Kurt Roeckx schrieb: What I currently see as best option is to actually comment out those 2 lines of code. But I have no idea what effect this really has on the RNG. The only effect I see is that the pool might receive less entropy. But on the other hand, I'm not even sure how much entropy

Re: Random number generator, uninitialised data and valgrind.

2006-05-01 Thread Geoff Thorpe
Umm... On May 1, 2006 03:14 pm, Kurt Roeckx wrote: The code in question that has the problem are the following 2 pieces of code in crypto/rand/md_rand.c: 247: MD_Update(m,buf,j); 467: #ifndef PURIFY MD_Update(m,buf,j); /* purify complains */ #endif