[openssl.org #3112] OpenSSL Documentation Bugs

2013-08-20 Thread Dustin Oprea via RT
Page: http://www.openssl.org/docs/crypto/ecdsa.html (1) intret; ECDSA_SIG *sig; EC_KEY*eckey = EC_KEY_new(); if (eckey == NULL) { /* error */ } key-group = EC_GROUP_new_by_nid(NID_secp192k1); if (key-group == NULL) { /* error */ }

[openssl.org #3113] OpenSSL’s DH implementation uses an unnecessarily long exponent, leading to significant performance loss

2013-08-20 Thread Gueron, Shay via RT
Hello all, OpenSSL’s DH implementation uses an unnecessarily long exponent, leading to significant performance loss OpenSSL handles the Diffie Hellman (DH) protocol in a very conservative way. By default, the length of the private key equals to the bit-length of the prime modulus. For

[openssl.org #3113] OpenSSL’s DH implementation uses an unnecessarily long exponent, leading to significant performance loss

2013-08-20 Thread Stephen Henson via RT
On Tue Aug 20 09:00:56 2013, shay.gue...@intel.com wrote: OpenSSL’s DH implementation uses an unnecessarily long exponent, leading to significant performance loss OpenSSL handles the Diffie Hellman (DH) protocol in a very conservative way. By default, the length of the private key equals

[openssl.org #3114] Bug report: Spelling error in apps/ocsp.c

2013-08-20 Thread joac...@secworks.se via RT
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Aloha! I believe there is a typo in the response from the ocsp app. This nit is present in OpenSSL 1.0.1e. Example: openssl ocsp -issuer ca_cert.pem -serial 751447 -url http://ocsp.startssl.com/sub/class1/server/ca Error querying OCSP responsder

[PATCH 0/2] Avoid NULL pointer dereference in several places

2013-08-20 Thread Xufeng Zhang
Hello All, Automatic tool detects there are several potential NULL pointer dereference in openssl source code, please help me review the attached two patches. Thanks, Xufeng Xufeng Zhang (2): openssl: avoid NULL pointer dereference in EVP_DigestInit_ex() openssl: avoid NULL pointer

[PATCH 1/2] openssl: avoid NULL pointer dereference in EVP_DigestInit_ex()

2013-08-20 Thread Xufeng Zhang
We should avoid accessing the type pointer if it's NULL, this could happen if ctx-digest is not NULL. --- crypto/evp/digest.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/crypto/evp/digest.c b/crypto/evp/digest.c index 982ba2b..96122ea 100644 --- a/crypto/evp/digest.c

[PATCH 0/2] Avoid NULL pointer dereference in several places

2013-08-20 Thread Xufeng Zhang
Hello All, Automatic tool detects there are several potential NULL pointer dereference in openssl source code, please help me review the attached two patches. Thanks, Xufeng Xufeng Zhang (2): openssl: avoid NULL pointer dereference in EVP_DigestInit_ex() openssl: avoid NULL pointer

[PATCH 2/2] openssl: avoid NULL pointer dereference in dh_pub_encode()/dsa_pub_encode()

2013-08-20 Thread Xufeng Zhang
We should avoid accessing the pointer if ASN1_STRING_new() allocates memory failed. --- crypto/dh/dh_ameth.c |6 ++ crypto/dsa/dsa_ameth.c |5 + 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/crypto/dh/dh_ameth.c b/crypto/dh/dh_ameth.c index 141c09b..784746b

Re: [PATCH 0/2] Avoid NULL pointer dereference in several places

2013-08-20 Thread Xufeng Zhang
Sorry, looks like this patchset has been resend, please ignore one of them. Thanks, Xufeng On 08/21/2013 10:54 AM, Xufeng Zhang wrote: Hello All, Automatic tool detects there are several potential NULL pointer dereference in openssl source code, please help me review the attached two