Re: freefunc - name clash with Python.h

2020-06-15 Thread Jordan Brown
On 6/15/2020 12:37 AM, Viktor Dukhovni wrote: > OpenSSL SHOULD NOT include parameter names in public headers. It would be sort of, maybe, OK to use names with an appropriate prefix.  That wouldn't be perfect, but it would be better. -- Jordan Brown, Oracle ZFS Storage Appliance, Oracle Solaris

Re: freefunc - name clash with Python.h

2020-06-15 Thread Viktor Dukhovni
On Mon, Jun 15, 2020 at 06:07:20AM +, Jordan Brown wrote: > Supplying names for the arguments in function prototypes makes them > easier to read, but risks namespace problems. Yes, which I why, some time back, I argued unsuccessfuly that we SHOULD NOT use parameter names in public headers in

Re: freefunc - name clash with Python.h

2020-06-15 Thread Jordan Brown
On 6/14/2020 2:54 AM, Dr. Matthias St. Pierre wrote: > I don't see any reason to change our code, IMHO the clash is Python's > fault: it declares a global typedef with a short name that has no > python-specific prefix. That is indeed rude, but the symbol could equally well have been introduced by