Re: [Openstack] Keystone's Swift Integration

2012-03-20 Thread Chmouel Boudjnah
Hi Maru, Sorry I have been taking long to come to you on this, I have revived review 4529[1] which add the swift tests. I was talking to termie about it sometime ago and the way we decided to do is to skip the tests if Swift is not installed[2]. Feel free to add stubs as this is not ideal. I

Re: [Openstack] Keystone's Swift Integration

2012-03-20 Thread Maru Newby
Hi Chmouel, Skipping for now is pragmatic, but I'd definitely want to implement stubs after your change lands to ensure that unit tests always run. I vote for implementing support for unauthenticated access asap. Anonymous access to Swift is a very important use case, and not having it means

Re: [Openstack] Keystone's Swift Integration

2012-03-20 Thread Chmouel Boudjnah
Hi Maru, I probably can land something by tomorrow or thursday and we can see what the keystone peoples would want to do with it. since this part of the code don't affect much keystone core, I have hope this could land before essex release. The main problem was that it needed a bit of shuffling

[Openstack] Keystone's Swift Integration

2012-03-19 Thread Maru Newby
I'd like to write unit tests for keystone.middleware.swift_auth in advance of some functional changes (adding support for unauthenticated container sync and referrer access). It appears that swift_auth lacks unit tests, though. Is this due to its dependency on swift, or is there another