Re: [openstack-dev] [Fuel] fake threads in tests

2015-02-18 Thread Evgeniy L
Hi Przemyslaw, Thanks for bringing up the topic. A long time ago we had similar topic, I agree that the way it works now is not good at all, because it leads to a lot of problems, I remember the time when our tests were randomly broken because of deadlocks and race conditions with fake thread.

Re: [openstack-dev] [Fuel] fake threads in tests

2015-02-18 Thread Przemyslaw Kaminski
Yes, I agree, basically the logic of introducing promises (or fake threads or whatever they are called) should be tested itself too. Basically what this is all about is mocking Astute and be able to easily program it's responses in tests. P. On 02/18/2015 09:27 AM, Evgeniy L wrote: Hi

Re: [openstack-dev] [Fuel] fake threads in tests

2015-02-16 Thread Przemyslaw Kaminski
On 02/16/2015 01:55 PM, Jay Pipes wrote: On 02/16/2015 06:54 AM, Przemyslaw Kaminski wrote: Hello, This somehow relates to [1]: in integration tests we have a class called FakeThread. It is responsible for spawning threads to simulate asynchronous tasks in fake env. In

Re: [openstack-dev] [Fuel] fake threads in tests

2015-02-16 Thread Jay Pipes
On 02/16/2015 08:18 AM, Przemyslaw Kaminski wrote: On 02/16/2015 01:55 PM, Jay Pipes wrote: On 02/16/2015 06:54 AM, Przemyslaw Kaminski wrote: Hello, This somehow relates to [1]: in integration tests we have a class called FakeThread. It is responsible for spawning threads to simulate

Re: [openstack-dev] [Fuel] fake threads in tests

2015-02-16 Thread Jay Pipes
On 02/16/2015 06:54 AM, Przemyslaw Kaminski wrote: Hello, This somehow relates to [1]: in integration tests we have a class called FakeThread. It is responsible for spawning threads to simulate asynchronous tasks in fake env. In BaseIntegrationTest class we have a method called

[openstack-dev] [Fuel] fake threads in tests

2015-02-16 Thread Przemyslaw Kaminski
Hello, This somehow relates to [1]: in integration tests we have a class called FakeThread. It is responsible for spawning threads to simulate asynchronous tasks in fake env. In BaseIntegrationTest class we have a method called _wait_for_threads that waits for all fake threads to terminate. In