Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-09 Thread Roman Prykhodchenko
Thank you guys for all your help! Special thanks to Robert who helped to find a workaround for an issue [1] that didn’t let us use testr for Fuel Client. The patch [2] was merged and both unit and functional tests are launched by subunit and the data is maintained by testrepository. Please

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-08 Thread Roman Prykhodchenko
Folks, Since we’ve reached the consensus here I’d like to invite you to review the patch [1] that replaces py.test with testr without making debuging or running specific tests harder. Please also note that it has a dependency which needs to be reviewed and merged first one. 1.

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-07 Thread Thomas Herve
On Wed, Oct 7, 2015 at 12:59 PM, Roman Prykhodchenko wrote: > What I can extract now from this thread is that Fuel should switch to > testr because of the following reasons: > > - Diversity of tools is a bad idea on a project scale > - testrepository and related components are

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-07 Thread Roman Prykhodchenko
What I can extract now from this thread is that Fuel should switch to testr because of the following reasons: - Diversity of tools is a bad idea on a project scale - testrepository and related components are used in OpenStack Infra environment for much more tasks than just running tests -

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-07 Thread Thomas Goirand
On 10/07/2015 02:06 AM, Monty Taylor wrote: > The Big Tent has absolutely no change in opinion about eliminating > diversity of tools. OpenStack has ALWAYS striven to reduce diversity of > tools. Big Tent applies OpenStack to more things that request to be part > of OpenStack. > > Nothing has

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-07 Thread Yuriy Taraday
On Wed, Oct 7, 2015 at 12:51 AM Monty Taylor wrote: > On 10/06/2015 10:52 AM, Sebastian Kalinowski wrote: > > I've already wrote in the review that caused this thread that I do not > want > > to blindly follow rules for using one or another. We should always > consider > >

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-07 Thread Roman Prykhodchenko
Yuri, sticking to global requirements and interacting deeper with OpenStack Infra are up-to-date objectives for Fuel and those are pretty much technical question. However, software development is not only solving technical tasks, it also incorporates interaction between people and other teams

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-07 Thread Yuriy Taraday
On Wed, Oct 7, 2015 at 3:14 AM Monty Taylor wrote: > On 10/06/2015 06:01 PM, Thomas Goirand wrote: > > On 10/06/2015 01:14 PM, Yuriy Taraday wrote: > >> On Mon, Oct 5, 2015 at 5:40 PM Roman Prykhodchenko >> > wrote: > >> > >>

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-07 Thread Michal Rostecki
On Wed, Oct 7, 2015 at 12:59 PM, Roman Prykhodchenko wrote: > What I can extract now from this thread is that Fuel should switch to testr > because of the following reasons: > > - Diversity of tools is a bad idea on a project scale We already have diversity about frameworks (or

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-07 Thread Roman Prykhodchenko
Michał, some comments in-line >> - testrepository and related components are used in OpenStack Infra >> environment for much more tasks than just running tests > > If by "more tasks" you mean parallel testing, py.test also has a > possibility to do that by pytest-xdist. As Monthy mentioned,

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-06 Thread Sebastian Kalinowski
I've already wrote in the review that caused this thread that I do not want to blindly follow rules for using one or another. We should always consider technical requirements. And I do not see a reason to leave py.test (and nobody show me such reason) and replace it with something else.

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-06 Thread Monty Taylor
On 10/06/2015 10:52 AM, Sebastian Kalinowski wrote: I've already wrote in the review that caused this thread that I do not want to blindly follow rules for using one or another. We should always consider technical requirements. And I do not see a reason to leave py.test (and nobody show me such

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-06 Thread Davanum Srinivas
Sebastian, I am really hoping that the items Monty listed below are enough. Also, if you are interested, folks do use other things for running their tests especially to find problems when testr hides some errors. Example, please see:

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-06 Thread Monty Taylor
On 10/06/2015 06:01 PM, Thomas Goirand wrote: On 10/06/2015 01:14 PM, Yuriy Taraday wrote: On Mon, Oct 5, 2015 at 5:40 PM Roman Prykhodchenko > wrote: Atm I have the following pros. and cons. regarding testrepository: pros.: 1. It’s

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-06 Thread Thomas Goirand
On 10/06/2015 01:14 PM, Yuriy Taraday wrote: > On Mon, Oct 5, 2015 at 5:40 PM Roman Prykhodchenko > wrote: > > Atm I have the following pros. and cons. regarding testrepository: > > pros.: > > 1. It’s ”standard" in OpenStack so using it

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-06 Thread Yuriy Taraday
On Mon, Oct 5, 2015 at 5:40 PM Roman Prykhodchenko wrote: > Atm I have the following pros. and cons. regarding testrepository: > > pros.: > > 1. It’s ”standard" in OpenStack so using it gives Fuel more karma and > moves it more under big tent > I don't think that big tent model

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-06 Thread Igor Kalnitsky
Hey Roman, > It’s ”standard" in OpenStack so using it gives Fuel more karma > and moves it more under big tent As far as I understand it doesn't affect our movement under big tent. > It’s in global requirements, so it doesn’t cause dependency hell Honestly I have no idea how py.test caused a

Re: [openstack-dev] [Fuel] py.test vs testrepository

2015-10-05 Thread Robert Collins
On 6 October 2015 at 03:34, Roman Prykhodchenko wrote: > Disclaimer: > I didn’t want to fire up this war but it silently hit one of my patches so > now I think it’s better to spread it to a wide audience. > > > When I was dealing with one of the regular dependency hell in Fuel

[openstack-dev] [Fuel] py.test vs testrepository

2015-10-05 Thread Roman Prykhodchenko
Disclaimer: I didn’t want to fire up this war but it silently hit one of my patches so now I think it’s better to spread it to a wide audience. When I was dealing with one of the regular dependency hell in Fuel Client I noticed, that stuff which is not in global requirements may make the