Re: [openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-27 Thread Thierry Carrez
Sean Dague wrote: Looks good, my only question is on how we signal the translation team that we're breaking string freeze for this, or even if we have a mechanism for that. It's documented at: https://wiki.openstack.org/wiki/StringFreeze At this point you shoud raise a thread on the ML (with

Re: [openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-26 Thread Michael Davies
On Mon, Sep 23, 2013 at 6:20 PM, Thierry Carrez thie...@openstack.org wrote: Monty Taylor wrote: On 09/20/2013 02:47 PM, Michael Still wrote: Before https://review.openstack.org/#/c/46867/ if file injection of a mandatory file fails, nova just silently ignores the failure, which is

Re: [openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-26 Thread Joe Gordon
On Thu, Sep 26, 2013 at 3:12 PM, Michael Davies mich...@the-davies.netwrote: On Mon, Sep 23, 2013 at 6:20 PM, Thierry Carrez thie...@openstack.org wrote: Monty Taylor wrote: On 09/20/2013 02:47 PM, Michael Still wrote: Before https://review.openstack.org/#/c/46867/ if file injection of

Re: [openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-26 Thread Sean Dague
Looks good, my only question is on how we signal the translation team that we're breaking string freeze for this, or even if we have a mechanism for that. On Thu, Sep 26, 2013 at 6:29 PM, Joe Gordon joe.gord...@gmail.com wrote: On Thu, Sep 26, 2013 at 3:12 PM, Michael Davies

Re: [openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-25 Thread Christopher Yeoh
On Mon, Sep 23, 2013 at 10:56 PM, Russell Bryant rbry...@redhat.com wrote: On 09/21/2013 12:02 AM, Pádraig Brady wrote: On 09/20/2013 10:47 PM, Michael Still wrote: Before https://review.openstack.org/#/c/46867/ if file injection of a mandatory file fails, nova just silently ignores the

Re: [openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-25 Thread Thierry Carrez
Christopher Yeoh wrote: On Mon, Sep 23, 2013 at 10:56 PM, Russell Bryant rbry...@redhat.com mailto:rbry...@redhat.com wrote: I agree with Monty and Thierry that ideally file injection should DIAF everywhere. On that note, have we done anything with that in the v3 API? I propose

Re: [openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-25 Thread Daniel P. Berrange
On Wed, Sep 25, 2013 at 12:02:03PM +0200, Thierry Carrez wrote: Christopher Yeoh wrote: On Mon, Sep 23, 2013 at 10:56 PM, Russell Bryant rbry...@redhat.com mailto:rbry...@redhat.com wrote: I agree with Monty and Thierry that ideally file injection should DIAF everywhere. On that

Re: [openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-23 Thread Russell Bryant
On 09/21/2013 12:02 AM, Pádraig Brady wrote: On 09/20/2013 10:47 PM, Michael Still wrote: Before https://review.openstack.org/#/c/46867/ if file injection of a mandatory file fails, nova just silently ignores the failure, which is clearly wrong. For reference, the original code you're

[openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-20 Thread Michael Still
Before https://review.openstack.org/#/c/46867/ if file injection of a mandatory file fails, nova just silently ignores the failure, which is clearly wrong. However, that review now can't land because its revealed another failure in the file injection code via tempest, which is... Should file

Re: [openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-20 Thread Monty Taylor
On 09/20/2013 02:47 PM, Michael Still wrote: Before https://review.openstack.org/#/c/46867/ if file injection of a mandatory file fails, nova just silently ignores the failure, which is clearly wrong. However, that review now can't land because its revealed another failure in the file

Re: [openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

2013-09-20 Thread Pádraig Brady
On 09/20/2013 10:47 PM, Michael Still wrote: Before https://review.openstack.org/#/c/46867/ if file injection of a mandatory file fails, nova just silently ignores the failure, which is clearly wrong. For reference, the original code you're adjusting is https://review.openstack.org/#/c/18900